From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Cross Subject: [PATCH 04/10] binder: use freezable blocking calls Date: Mon, 29 Apr 2013 14:45:40 -0700 Message-ID: <1367271946-7239-5-git-send-email-ccross@android.com> References: <1367271946-7239-1-git-send-email-ccross@android.com> Return-path: Received: from mail-qe0-f74.google.com ([209.85.128.74]:49961 "EHLO mail-qe0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758199Ab3D2Vpw (ORCPT ); Mon, 29 Apr 2013 17:45:52 -0400 Received: by mail-qe0-f74.google.com with SMTP id a11so145756qen.1 for ; Mon, 29 Apr 2013 14:45:52 -0700 (PDT) In-Reply-To: <1367271946-7239-1-git-send-email-ccross@android.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , arve@android.com, Colin Cross , Greg Kroah-Hartman , Al Viro , "Eric W. Biederman" , Sachin Kamat , devel@driverdev.osuosl.org Avoid waking up every thread sleeping in a binder call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross --- drivers/staging/android/binder.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 24456a0..af8fba4 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -2140,13 +2141,13 @@ retry: if (!binder_has_proc_work(proc, thread)) ret = -EAGAIN; } else - ret = wait_event_interruptible_exclusive(proc->wait, binder_has_proc_work(proc, thread)); + ret = wait_event_freezable_exclusive(proc->wait, binder_has_proc_work(proc, thread)); } else { if (non_block) { if (!binder_has_thread_work(thread)) ret = -EAGAIN; } else - ret = wait_event_interruptible(thread->wait, binder_has_thread_work(thread)); + ret = wait_event_freezable(thread->wait, binder_has_thread_work(thread)); } binder_lock(__func__); -- 1.8.2.1