From: Olivier Langlois <olivier@trillion01.com>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
David Miller <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 06/10] posix-cpu-timers: fix wrong timer initialization
Date: Tue, 30 Apr 2013 09:34:54 -0400 [thread overview]
Message-ID: <1367328894.8833.49.camel@Wailaba2> (raw)
In-Reply-To: <1367291838-5490-7-git-send-email-kosaki.motohiro@gmail.com>
On Mon, 2013-04-29 at 23:17 -0400, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> Currently glibc's rt/tst-cputimer1 testcase is spradically fail because
> a timer created by timer_create() may fire earlier than it's specified.
>
> posix_cpu_timer_set() uses "val" as current time for three purpose. 1)
> initialize sig->cputimer. 2) calculation "old" val. 3) calculations an
> expires time.
>
> (1) and (2) should be used only committed time (i.e. without delta_exec)
> because run_posix_cpu_timers() don't care of delta_exec and we need
> consistency. But (3) need exact current time (aka cpu clock time) beucase
> an expires should be "now + timeout" by definition.
>
> This patch makes separete two kind of "now".
>
Kosaki,
I must admit that this solution is simpler to what I originally
proposed.
good work!
Olivier
next prev parent reply other threads:[~2013-04-30 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 3:17 [PATCH v3 0/7] posix-cpu-timers fixlet kosaki.motohiro
2013-04-30 3:17 ` [PATCH 01/10] events: Protect access via task_subsys_state_check() kosaki.motohiro
2013-04-30 3:17 ` [PATCH 02/10] vm: add no-mmu vm_iomap_memory() stub kosaki.motohiro
2013-04-30 3:17 ` [PATCH 03/10] ARM: OMAP4: hwmod data: make 'ocp2scp_usb_phy_phy_48m" as the main clock kosaki.motohiro
2013-04-30 3:17 ` [PATCH 04/10] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting kosaki.motohiro
2013-04-30 3:38 ` KOSAKI Motohiro
2013-04-30 3:17 ` [PATCH 05/10] posix-cpu-timers: fix acounting delta_exec twice kosaki.motohiro
2013-04-30 3:17 ` [PATCH 06/10] posix-cpu-timers: fix wrong timer initialization kosaki.motohiro
2013-04-30 13:34 ` Olivier Langlois [this message]
2013-04-30 3:17 ` [PATCH 07/10] posix-cpu-timers: timer functions must use timer time instead of clock time kosaki.motohiro
2013-04-30 3:17 ` [PATCH 08/10] posix-cpu-timers: check_thread_timers() uses task_sched_runtime() kosaki.motohiro
2013-04-30 3:17 ` [PATCH 09/10] sched: task_sched_runtime introduce micro optimization kosaki.motohiro
2013-05-01 11:00 ` Peter Zijlstra
2013-05-01 11:50 ` Paul Turner
2013-05-01 18:55 ` KOSAKI Motohiro
2013-05-01 18:42 ` KOSAKI Motohiro
2013-04-30 3:17 ` [PATCH 10/10] posix-cpu-timers: cleanup cpu_{clock,timer}_sample{,_group} kosaki.motohiro
2013-05-01 11:01 ` [PATCH v3 0/7] posix-cpu-timers fixlet Peter Zijlstra
2013-05-01 18:45 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367328894.8833.49.camel@Wailaba2 \
--to=olivier@trillion01.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.