From: Scott Wood <scottwood@freescale.com>
To: "Chen, Tiejun" <Tiejun.Chen@windriver.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"agraf@suse.de" <agraf@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [v1][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size
Date: Tue, 30 Apr 2013 18:36:04 -0500 [thread overview]
Message-ID: <1367364964.24133.18@snotra> (raw)
In-Reply-To: <82C960D7DF4A1F47B94FC1C67A29BEE3669325EA@ALA-MBB.corp.ad.wrs.com> (from Tiejun.Chen@windriver.com on Tue Apr 30 18:31:41 2013)
On 04/30/2013 06:31:41 PM, Chen, Tiejun wrote:
> > function that gets called later. The comment doesn't make
>
> Are you saying I should replace cpu_to_be64(params->ram_size) with
> cpu_to_be64(ram_size) directly in ppce500_load_device_tree()?
No, I'm saying to reword (or eliminate) the confusing comment.
> But as I understand we should sync this global argument after we
> fixup something associated to that since params->ram_size may impact
> on something else in the future.
...and we just hope that nothing uses it for anything important before
the fixup. :-P
-Scott
next prev parent reply other threads:[~2013-04-30 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 10:30 [Qemu-devel] [v1][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size Tiejun Chen
2013-04-29 19:18 ` [Qemu-devel] [Qemu-ppc] [v1][PATCH " Scott Wood
2013-04-30 9:53 ` Alexander Graf
2013-04-30 12:04 ` Andreas Färber
2013-04-30 23:54 ` Chen, Tiejun
2013-05-01 0:29 ` Alexander Graf
2013-04-30 23:03 ` Chen, Tiejun
2013-04-30 23:08 ` Scott Wood
2013-04-30 23:31 ` Chen, Tiejun
2013-04-30 23:36 ` Scott Wood [this message]
2013-04-30 23:46 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367364964.24133.18@snotra \
--to=scottwood@freescale.com \
--cc=Tiejun.Chen@windriver.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.