All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/9] mxs: spl_mem_init: Remove unneeded DRAM configurations
Date: Wed,  1 May 2013 18:44:47 -0300	[thread overview]
Message-ID: <1367444689-31301-8-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1367444689-31301-1-git-send-email-festevam@gmail.com>

From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to write to DRAM_CTL8 register prior to nitialize_dram_values().

Fix a comment related to writing to DRAM_CTL8.

Also, DRAM_CTL18 register on mx23 does not contain DRAM init complete bit, so
remove this setting as this is also not done by FSL bootlets code.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
index 1c509d6..cde883d 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
@@ -262,12 +262,9 @@ static void mx23_mem_init(void)
 	 * Configure the DRAM registers
 	 */
 
-	/* Clear START and SREFRESH bit from DRAM_CTL8 */
-	clrbits_le32(MXS_DRAM_BASE + 0x20, (1 << 16) | (1 << 8));
-
 	initialize_dram_values();
 
-	/* Set START bit in DRAM_CTL16 */
+	/* Set START bit in DRAM_CTL8 */
 	setbits_le32(MXS_DRAM_BASE + 0x20, 1 << 16);
 
 	clrbits_le32(MXS_DRAM_BASE + 0x40, 1 << 17);
@@ -279,10 +276,6 @@ static void mx23_mem_init(void)
 
 	setbits_le32(MXS_DRAM_BASE + 0x40, 1 << 19);
 	setbits_le32(MXS_DRAM_BASE + 0x40, 1 << 11);
-
-	/* Wait for bit 10 (DRAM init complete) in DRAM_CTL18 */
-	while (!(readl(MXS_DRAM_BASE + 0x48) & (1 << 10)))
-		;
 }
 #endif
 
-- 
1.7.9.5

  parent reply	other threads:[~2013-05-01 21:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 21:44 [U-Boot] [PATCH 0/9] mx23: Make DDR initialization stable Fabio Estevam
2013-05-01 21:44 ` [U-Boot] [PATCH 1/9] mxs: Make the names of the elements of mxs_pinctrl_regs shorter Fabio Estevam
2013-05-01 23:26   ` Marek Vasut
2013-05-01 23:52     ` Fabio Estevam
2013-05-02  0:12       ` Marek Vasut
2013-05-01 21:44 ` [U-Boot] [PATCH 2/9] mx23: regs-pinctrl.h: Add pinctrl support for mx23 Fabio Estevam
2013-05-01 23:27   ` Marek Vasut
2013-05-01 23:52     ` Fabio Estevam
2013-05-02  0:13       ` Marek Vasut
2013-05-02  0:28         ` Fabio Estevam
2013-05-02  1:44           ` Marek Vasut
2013-05-01 21:44 ` [U-Boot] [PATCH 3/9] mx23evk: Fix DDR pin iomux settings Fabio Estevam
2013-05-01 23:28   ` Marek Vasut
2013-05-01 23:56     ` Fabio Estevam
2013-05-02  0:13       ` Marek Vasut
2013-05-01 21:44 ` [U-Boot] [PATCH 4/9] mx23_olinuxino: " Fabio Estevam
2013-05-01 23:28   ` Marek Vasut
2013-05-01 23:53     ` Fabio Estevam
2013-05-02  0:14       ` Marek Vasut
2013-05-02  2:34         ` Fabio Estevam
2013-05-01 21:44 ` [U-Boot] [PATCH 5/9] mx23evk: Disable the internal pad keepers Fabio Estevam
2013-05-01 21:44 ` [U-Boot] [PATCH 6/9] mx23_olinuxino: " Fabio Estevam
2013-05-01 21:44 ` Fabio Estevam [this message]
2013-05-01 23:29   ` [U-Boot] [PATCH 7/9] mxs: spl_mem_init: Remove unneeded DRAM configurations Marek Vasut
2013-05-01 23:54     ` Fabio Estevam
2013-05-02  0:15       ` Marek Vasut
2013-05-02  0:24         ` Fabio Estevam
2013-05-01 21:44 ` [U-Boot] [PATCH 8/9] mxs: spl_mem_init: Skip the initialization of some DRAM_CTL registers Fabio Estevam
2013-05-01 23:30   ` Marek Vasut
2013-05-05 14:40   ` Stefano Babic
2013-05-01 21:44 ` [U-Boot] [PATCH 9/9] mxs: spl_mem_init: Change EMI port priority Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367444689-31301-8-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.