All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: bjorn@mork.no, netdev@vger.kernel.org, dlstevens@us.ibm.com,
	stephen@networkplumber.org
Subject: Re: [Patch net-next v7 4/6] vxlan: add ipv6 support
Date: Thu, 02 May 2013 15:55:37 +0800	[thread overview]
Message-ID: <1367481337.2415.21.camel@cr0> (raw)
In-Reply-To: <20130430.150547.2297961494334074636.davem@davemloft.net>

On Tue, 2013-04-30 at 15:05 -0400, David Miller wrote:
> Your patch has had large, major, shortcomings every single iteration.

This is due to people including you only point out one problem per
iteration, for some reason I don't understand...

For example, you pointed out IPv6=M issue in v5, and then pointed out
disable_ipv6 issue in v6. Until you pointed them out, I even wasn't
aware of them. All the problems I have fixed, except the naming of
struct fields which I still don't agree, exist in v1, there is no
regression since v1.

As always, it is _highly_ appreciated if all of you can point as many
issues as you can in a single iteration, so that I can fix them all in
one update (if I can fix), this also saves me _a lot_ of time,
obviously.

So, I even don't understand what you are complaining about. :) I am
trying my best to address all the issues you pointed out including the
one that I don't agree at all, except the one I can't fix right now
(scope id). If anything I can improve on my side, please explicitly let
me know.

Again, I am _not_ an IPv6 expert, I am sure there are still some other
issues like disable_ipv6 that I am still not aware of, so please don't
expect me to be able to fix all bugs alone at one time, I am trying to
fix them one by one, and this is the best that I can do.

Thanks.

  reply	other threads:[~2013-05-02  7:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30  8:43 [Patch net-next v7 0/6] vxlan: add ipv6 support Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 1/6] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 2/6] ipv6: export a stub for ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 3/6] ipv6: export in6addr_loopback to modules Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 4/6] vxlan: add ipv6 support Cong Wang
2013-04-30  9:17   ` Bjørn Mork
2013-04-30  9:25     ` Cong Wang
2013-04-30 10:33       ` Bjørn Mork
2013-04-30 19:06         ` David Miller
2013-05-02  8:05         ` Cong Wang
2013-05-02  8:10           ` David Miller
2013-05-02 12:45           ` Bjørn Mork
2013-05-03  3:02             ` Cong Wang
2013-04-30 19:05       ` David Miller
2013-05-02  7:55         ` Cong Wang [this message]
2013-04-30  9:38     ` Cong Wang
2013-04-30 18:58       ` David Miller
2013-04-30 19:04     ` David Miller
2013-04-30  8:43 ` [Patch net-next v7 5/6] vxlan: respect disable_ipv6 sysctl Cong Wang
2013-04-30 12:27   ` Sergei Shtylyov
2013-04-30  8:43 ` [Patch net-next v7 6/6] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-04-30 19:00 ` [Patch net-next v7 0/6] vxlan: add ipv6 support David Miller
2013-05-02  7:02   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367481337.2415.21.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.