From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wirelss <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH] mac80211: clean up mesh RCU warning
Date: Fri, 03 May 2013 08:41:04 +0200 [thread overview]
Message-ID: <1367563264.9430.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1367536279-14241-1-git-send-email-thomas@cozybit.com> (sfid-20130503_011325_779040_E2BD5BC1)
On Thu, 2013-05-02 at 16:11 -0700, Thomas Pedersen wrote:
> When running a kernel with CONFIG_PROVE_RCU, the minstrel
> rate update code would complain about being called without
> the RCU read lock held. This is because
> mesh_sta_info_init() may or may not have been called under
> RCU read lock. Perform some bureaucratic critical section
> toggling to always call mesh_sta_info_init() under RCU,
> and silence this warning.
This was discussed in another thread a while ago, but unfortunately
nothing came out of it. I really don't think this is the right solution,
since the code that this calls doesn't even use rcu_dereference()
properly.
Felix, please come up with a proper fix soon, otherwise I'm going to
revert your changes for 3.10.
johannes
prev parent reply other threads:[~2013-05-03 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 23:11 [PATCH] mac80211: clean up mesh RCU warning Thomas Pedersen
2013-05-03 6:41 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367563264.9430.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.