diff for duplicates of <1367604287.19391.2@snotra> diff --git a/a/1.txt b/N1/1.txt index 2e414e0..ebaeaae 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,76 +1,76 @@ On 05/03/2013 11:11:10 AM, Mihai Caraman wrote: -> A change in the generic code highlighted that we were running with +> A change in the generic code highlighted that we were running with =20 > IRQs > (soft) enabled on Book3E 64-bit when trying to restart interrupts from > handle_exit(). This is a lesson to configure lockdep often :) -> -> There is no reason to exit guest with soft_enabled = 1, a +>=20 +> There is no reason to exit guest with soft_enabled =3D=3D 1, a =20 > local_irq_enable() -> call will do this for us so get rid of kvmppc_layz_ee() calls. With +> call will do this for us so get rid of kvmppc_layz_ee() calls. With =20 > this fix -> we eliminate irqs_disabled() warnings and some guest and host hangs +> we eliminate irqs_disabled() warnings and some guest and host hangs =20 > revealed > under stress tests, but guests still exhibit some unresponsiveness. -> -> The unresponsiveness has to do with the fact that +>=20 +> The unresponsiveness has to do with the fact that =20 > arch_local_irq_restore() > does not guarantees to hard enable interrupts. -Could you elaborate? If the saved IRQ state was "enabled", why -wouldn't arch_local_irq_restore() hard-enable IRQs? The last thing it +Could you elaborate? If the saved IRQ state was "enabled", why =20 +wouldn't arch_local_irq_restore() hard-enable IRQs? The last thing it =20 does is __hard_irq_enable(). Where is the arch_local_irq_restore() instance you're talking about? > To do so replace exception > function calls like timer_interrupt() with irq_happened flags. The -> local_irq_enable() call takes care of replaying them and lets the +> local_irq_enable() call takes care of replaying them and lets the =20 > interrupts > hard enabled. -Not sure what you mean by "lets the interrupts hard enabled"... Do you -mean the EE bit in regs->msr, as opposed to the EE bit in the current +Not sure what you mean by "lets the interrupts hard enabled"... Do you =20 +mean the EE bit in regs->msr, as opposed to the EE bit in the current =20 MSR? > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> > --- > arch/powerpc/kvm/booke.c | 9 +++------ > 1 files changed, 3 insertions(+), 6 deletions(-) -> +>=20 > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 1020119..82f155e 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c -> @@ -673,7 +673,6 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, +> @@ -673,7 +673,6 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, =20 > struct kvm_vcpu *vcpu) -> ret = s; +> ret =3D s; > goto out; > } > - kvmppc_lazy_ee_enable(); -> +>=20 > kvm_guest_enter(); -> -> @@ -789,16 +788,16 @@ static void kvmppc_restart_interrupt(struct +>=20 +> @@ -789,16 +788,16 @@ static void kvmppc_restart_interrupt(struct =20 > kvm_vcpu *vcpu, > switch (exit_nr) { > case BOOKE_INTERRUPT_EXTERNAL: > kvmppc_fill_pt_regs(®s); > - do_IRQ(®s); -> + local_paca->irq_happened |= PACA_IRQ_EE; +> + local_paca->irq_happened |=3D PACA_IRQ_EE; > break; > case BOOKE_INTERRUPT_DECREMENTER: > kvmppc_fill_pt_regs(®s); > - timer_interrupt(®s); -> + local_paca->irq_happened |= PACA_IRQ_DEC; +> + local_paca->irq_happened |=3D PACA_IRQ_DEC; > break; > #if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64) > case BOOKE_INTERRUPT_DOORBELL: > kvmppc_fill_pt_regs(®s); > - doorbell_exception(®s); -> + local_paca->irq_happened |= PACA_IRQ_DBELL; +> + local_paca->irq_happened |=3D PACA_IRQ_DBELL; > break; > #endif Aren't you breaking 32-bit here? --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index ac5c874..3c02805 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,89 +1,89 @@ "ref\01367597470-22214-1-git-send-email-mihai.caraman@freescale.com\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs\0" - "Date\0Fri, 03 May 2013 18:04:47 +0000\0" + "Date\0Fri, 3 May 2013 13:04:47 -0500\0" "To\0Mihai Caraman <mihai.caraman@freescale.com>\0" - "Cc\0kvm-ppc@vger.kernel.org" - kvm@vger.kernel.org + "Cc\0Mihai Caraman <mihai.caraman@freescale.com>" linuxppc-dev@lists.ozlabs.org - " Mihai Caraman <mihai.caraman@freescale.com>\0" + kvm@vger.kernel.org + " kvm-ppc@vger.kernel.org\0" "\00:1\0" "b\0" "On 05/03/2013 11:11:10 AM, Mihai Caraman wrote:\n" - "> A change in the generic code highlighted that we were running with \n" + "> A change in the generic code highlighted that we were running with =20\n" "> IRQs\n" "> (soft) enabled on Book3E 64-bit when trying to restart interrupts from\n" "> handle_exit(). This is a lesson to configure lockdep often :)\n" - "> \n" - "> There is no reason to exit guest with soft_enabled = 1, a \n" + ">=20\n" + "> There is no reason to exit guest with soft_enabled =3D=3D 1, a =20\n" "> local_irq_enable()\n" - "> call will do this for us so get rid of kvmppc_layz_ee() calls. With \n" + "> call will do this for us so get rid of kvmppc_layz_ee() calls. With =20\n" "> this fix\n" - "> we eliminate irqs_disabled() warnings and some guest and host hangs \n" + "> we eliminate irqs_disabled() warnings and some guest and host hangs =20\n" "> revealed\n" "> under stress tests, but guests still exhibit some unresponsiveness.\n" - "> \n" - "> The unresponsiveness has to do with the fact that \n" + ">=20\n" + "> The unresponsiveness has to do with the fact that =20\n" "> arch_local_irq_restore()\n" "> does not guarantees to hard enable interrupts.\n" "\n" - "Could you elaborate? If the saved IRQ state was \"enabled\", why \n" - "wouldn't arch_local_irq_restore() hard-enable IRQs? The last thing it \n" + "Could you elaborate? If the saved IRQ state was \"enabled\", why =20\n" + "wouldn't arch_local_irq_restore() hard-enable IRQs? The last thing it =20\n" "does is __hard_irq_enable().\n" "\n" "Where is the arch_local_irq_restore() instance you're talking about?\n" "\n" "> To do so replace exception\n" "> function calls like timer_interrupt() with irq_happened flags. The\n" - "> local_irq_enable() call takes care of replaying them and lets the \n" + "> local_irq_enable() call takes care of replaying them and lets the =20\n" "> interrupts\n" "> hard enabled.\n" "\n" - "Not sure what you mean by \"lets the interrupts hard enabled\"... Do you \n" - "mean the EE bit in regs->msr, as opposed to the EE bit in the current \n" + "Not sure what you mean by \"lets the interrupts hard enabled\"... Do you =20\n" + "mean the EE bit in regs->msr, as opposed to the EE bit in the current =20\n" "MSR?\n" "\n" "> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>\n" "> ---\n" "> arch/powerpc/kvm/booke.c | 9 +++------\n" "> 1 files changed, 3 insertions(+), 6 deletions(-)\n" - "> \n" + ">=20\n" "> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c\n" "> index 1020119..82f155e 100644\n" "> --- a/arch/powerpc/kvm/booke.c\n" "> +++ b/arch/powerpc/kvm/booke.c\n" - "> @@ -673,7 +673,6 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, \n" + "> @@ -673,7 +673,6 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, =20\n" "> struct kvm_vcpu *vcpu)\n" - "> \t\tret = s;\n" + "> \t\tret =3D s;\n" "> \t\tgoto out;\n" "> \t}\n" "> -\tkvmppc_lazy_ee_enable();\n" - "> \n" + ">=20\n" "> \tkvm_guest_enter();\n" - "> \n" - "> @@ -789,16 +788,16 @@ static void kvmppc_restart_interrupt(struct \n" + ">=20\n" + "> @@ -789,16 +788,16 @@ static void kvmppc_restart_interrupt(struct =20\n" "> kvm_vcpu *vcpu,\n" "> \tswitch (exit_nr) {\n" "> \tcase BOOKE_INTERRUPT_EXTERNAL:\n" "> \t\tkvmppc_fill_pt_regs(®s);\n" "> -\t\tdo_IRQ(®s);\n" - "> +\t\tlocal_paca->irq_happened |= PACA_IRQ_EE;\n" + "> +\t\tlocal_paca->irq_happened |=3D PACA_IRQ_EE;\n" "> \t\tbreak;\n" "> \tcase BOOKE_INTERRUPT_DECREMENTER:\n" "> \t\tkvmppc_fill_pt_regs(®s);\n" "> -\t\ttimer_interrupt(®s);\n" - "> +\t\tlocal_paca->irq_happened |= PACA_IRQ_DEC;\n" + "> +\t\tlocal_paca->irq_happened |=3D PACA_IRQ_DEC;\n" "> \t\tbreak;\n" "> #if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64)\n" "> \tcase BOOKE_INTERRUPT_DOORBELL:\n" "> \t\tkvmppc_fill_pt_regs(®s);\n" "> -\t\tdoorbell_exception(®s);\n" - "> +\t\tlocal_paca->irq_happened |= PACA_IRQ_DBELL;\n" + "> +\t\tlocal_paca->irq_happened |=3D PACA_IRQ_DBELL;\n" "> \t\tbreak;\n" "> #endif\n" "\n" "Aren't you breaking 32-bit here?\n" "\n" - -Scott + -Scott= -98dd7084a4f61bac67c82f3f8905d60d1a3759ce6adc98c32dc004d076a83581 +084e38bcc3d232f8155c49b7bd14ff07b6eb29385530f0e5e0cff4da70810a77
diff --git a/a/1.txt b/N2/1.txt index 2e414e0..e6284bb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,7 +4,7 @@ On 05/03/2013 11:11:10 AM, Mihai Caraman wrote: > (soft) enabled on Book3E 64-bit when trying to restart interrupts from > handle_exit(). This is a lesson to configure lockdep often :) > -> There is no reason to exit guest with soft_enabled = 1, a +> There is no reason to exit guest with soft_enabled == 1, a > local_irq_enable() > call will do this for us so get rid of kvmppc_layz_ee() calls. With > this fix diff --git a/a/content_digest b/N2/content_digest index ac5c874..f1c7620 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,11 +1,11 @@ "ref\01367597470-22214-1-git-send-email-mihai.caraman@freescale.com\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs\0" - "Date\0Fri, 03 May 2013 18:04:47 +0000\0" + "Date\0Fri, 3 May 2013 13:04:47 -0500\0" "To\0Mihai Caraman <mihai.caraman@freescale.com>\0" - "Cc\0kvm-ppc@vger.kernel.org" - kvm@vger.kernel.org - linuxppc-dev@lists.ozlabs.org + "Cc\0<kvm-ppc@vger.kernel.org>" + <kvm@vger.kernel.org> + <linuxppc-dev@lists.ozlabs.org> " Mihai Caraman <mihai.caraman@freescale.com>\0" "\00:1\0" "b\0" @@ -15,7 +15,7 @@ "> (soft) enabled on Book3E 64-bit when trying to restart interrupts from\n" "> handle_exit(). This is a lesson to configure lockdep often :)\n" "> \n" - "> There is no reason to exit guest with soft_enabled = 1, a \n" + "> There is no reason to exit guest with soft_enabled == 1, a \n" "> local_irq_enable()\n" "> call will do this for us so get rid of kvmppc_layz_ee() calls. With \n" "> this fix\n" @@ -86,4 +86,4 @@ "\n" -Scott -98dd7084a4f61bac67c82f3f8905d60d1a3759ce6adc98c32dc004d076a83581 +abfc462e430fc1bf3b7a4c6b5000ea379c14c6bf7e416c46c76a1c78f78ebaf3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.