Re: Resource assignment oddities

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Sun, 2013-05-05 at 00:09 -0700, Yinghai Lu wrote:
> Yes, there is something wrong
> 
> pci 0001:01:00.0: BAR 8: can't assign mem (size 0x800000)
> 
> as bridge only can support 32bit mmio non-pref.

Right, that looks wrong, why can't it assign it ? That's what I haven't
figured out yet. There should be plenty of space still available.

> There is one bug for arch other than x86, but it should not be related.
> 
> in pci_bus_alloc_resource()
> 
> |        /* don't allocate too high if the pref mem doesn't support 64bit*/
> |        if (!(res->flags & IORESOURCE_MEM_64))
> |                max = PCIBIOS_MAX_MEM_32;
> 
> we should call pcibios_resource_to_bus ... to make
> sure that actual bus addr is still 32bit

Or the other way around but yes, I see your point however ...

> But i'm confused, Did you happen to define your own
>     PCIBIOS_MAX_MEM_32 ?
> as default one should be -1 other than x86.

Right, it is -1. Oh well, I'll sprinkle some printk's around tomorrow (or
ask Gavin to do it :-)

Thanks !

Cheers,
Ben.