All of lore.kernel.org
 help / color / mirror / Atom feed
From: chenlibo.3@gmail.com
To: grant.likely@linaro.org, rob.herring@calxeda.com
Cc: linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Libo Chen <libo.chen@huawei.com>
Subject: [PATCH] bestcomm: no need to free when kzalloc fail
Date: Sun,  5 May 2013 01:38:24 -0700	[thread overview]
Message-ID: <1367743104-3448-1-git-send-email-libo.chen@huawei.com> (raw)

From: Libo Chen <libo.chen@huawei.com>

There is no need to free bcom_eng if kzalloc fail

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/dma/bestcomm/bestcomm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c
index a8c2e29..300ee2d 100644
--- a/drivers/dma/bestcomm/bestcomm.c
+++ b/drivers/dma/bestcomm/bestcomm.c
@@ -400,7 +400,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op)
 		printk(KERN_ERR DRIVER_NAME ": "
 			"Can't allocate state structure\n");
 		rv = -ENOMEM;
-		goto error_sramclean;
+		goto error_kzalloc;
 	}
 
 	/* Save the node */
@@ -449,6 +449,7 @@ error_release:
 	release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma));
 error_sramclean:
 	kfree(bcom_eng);
+error_kzalloc:
 	bcom_sram_cleanup();
 error_ofput:
 	of_node_put(op->dev.of_node);
-- 
1.8.1.2

             reply	other threads:[~2013-05-05  8:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-05  8:38 chenlibo.3 [this message]
2013-05-22  4:49 ` [PATCH] bestcomm: no need to free when kzalloc fail Libo Chen
2013-05-22  4:49   ` Libo Chen
2013-05-22  4:58   ` Li Zefan
2013-05-22  4:58     ` Li Zefan
2013-05-22  6:03     ` Libo Chen
2013-05-22  6:03       ` Libo Chen
     [not found]   ` <519C4E4D.1060101-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-22  6:06     ` Benjamin Herrenschmidt
2013-05-22  6:06       ` Benjamin Herrenschmidt
2013-05-22  6:35       ` Libo Chen
2013-05-22  6:35         ` Libo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367743104-3448-1-git-send-email-libo.chen@huawei.com \
    --to=chenlibo.3@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=libo.chen@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.