diff for duplicates of <1367884257.3398.9@snotra> diff --git a/a/1.txt b/N1/1.txt index 23020a4..cf9eeac 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,11 @@ On 05/05/2013 10:13:17 PM, tiejun.chen wrote: > On 05/06/2013 11:10 AM, Tiejun Chen wrote: ->> For the external interrupt, the decrementer exception and the =20 +>> For the external interrupt, the decrementer exception and the >> doorbell ->> excpetion, we also need to soft-disable interrupts while doing as =20 +>> excpetion, we also need to soft-disable interrupts while doing as >> host >> interrupt handlers since the DO_KVM hook is always performed to skip ->> EXCEPTION_COMMON then miss this original chance with the 'ints' =20 +>> EXCEPTION_COMMON then miss this original chance with the 'ints' >> (INTS_DISABLE). http://patchwork.ozlabs.org/patch/241344/ @@ -17,14 +17,14 @@ http://patchwork.ozlabs.org/patch/241412/ >> --- >> arch/powerpc/kvm/bookehv_interrupts.S | 9 +++++++++ >> 1 file changed, 9 insertions(+) ->>=20 ->> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S =20 +>> +>> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S >> b/arch/powerpc/kvm/bookehv_interrupts.S >> index e8ed7d6..2fd62bf 100644 >> --- a/arch/powerpc/kvm/bookehv_interrupts.S >> +++ b/arch/powerpc/kvm/bookehv_interrupts.S >> @@ -33,6 +33,8 @@ ->>=20 +>> >> #ifdef CONFIG_64BIT >> #include <asm/exception-64e.h> >> +#include <asm/hw_irq.h> @@ -38,14 +38,14 @@ http://patchwork.ozlabs.org/patch/241412/ >> mr r14, r4 /* Save vcpu pointer. */ >> +#ifdef CONFIG_64BIT >> + /* Should we soft-disable interrupts? */ ->> + andi. r6, r5, BOOKE_INTERRUPT_EXTERNAL | =20 +>> + andi. r6, r5, BOOKE_INTERRUPT_EXTERNAL | >> BOOKE_INTERRUPT_DECREMENTER | BOOKE_INTERRUPT_DOORBELL >> + beq skip_soft_dis >> + SOFT_DISABLE_INTS(r7,r8) >> +skip_soft_dis: >> +#endif -Why wouldn't we always disable them? kvmppc_handle_exit() will enable =20 +Why wouldn't we always disable them? kvmppc_handle_exit() will enable interrupts when it's ready. --Scott= +-Scott diff --git a/a/content_digest b/N1/content_digest index f3d4cae..c37d101 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,12 +11,12 @@ "b\0" "On 05/05/2013 10:13:17 PM, tiejun.chen wrote:\n" "> On 05/06/2013 11:10 AM, Tiejun Chen wrote:\n" - ">> For the external interrupt, the decrementer exception and the =20\n" + ">> For the external interrupt, the decrementer exception and the \n" ">> doorbell\n" - ">> excpetion, we also need to soft-disable interrupts while doing as =20\n" + ">> excpetion, we also need to soft-disable interrupts while doing as \n" ">> host\n" ">> interrupt handlers since the DO_KVM hook is always performed to skip\n" - ">> EXCEPTION_COMMON then miss this original chance with the 'ints' =20\n" + ">> EXCEPTION_COMMON then miss this original chance with the 'ints' \n" ">> (INTS_DISABLE).\n" "\n" "http://patchwork.ozlabs.org/patch/241344/\n" @@ -28,14 +28,14 @@ ">> ---\n" ">> arch/powerpc/kvm/bookehv_interrupts.S | 9 +++++++++\n" ">> 1 file changed, 9 insertions(+)\n" - ">>=20\n" - ">> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S =20\n" + ">> \n" + ">> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S \n" ">> b/arch/powerpc/kvm/bookehv_interrupts.S\n" ">> index e8ed7d6..2fd62bf 100644\n" ">> --- a/arch/powerpc/kvm/bookehv_interrupts.S\n" ">> +++ b/arch/powerpc/kvm/bookehv_interrupts.S\n" ">> @@ -33,6 +33,8 @@\n" - ">>=20\n" + ">> \n" ">> #ifdef CONFIG_64BIT\n" ">> #include <asm/exception-64e.h>\n" ">> +#include <asm/hw_irq.h>\n" @@ -49,16 +49,16 @@ ">> \tmr\tr14, r4 /* Save vcpu pointer. */\n" ">> +#ifdef CONFIG_64BIT\n" ">> +\t/* Should we soft-disable interrupts? */\n" - ">> +\tandi.\tr6, r5, BOOKE_INTERRUPT_EXTERNAL | =20\n" + ">> +\tandi.\tr6, r5, BOOKE_INTERRUPT_EXTERNAL | \n" ">> BOOKE_INTERRUPT_DECREMENTER | BOOKE_INTERRUPT_DOORBELL\n" ">> +\tbeq\tskip_soft_dis\n" ">> +\tSOFT_DISABLE_INTS(r7,r8)\n" ">> +skip_soft_dis:\n" ">> +#endif\n" "\n" - "Why wouldn't we always disable them? kvmppc_handle_exit() will enable =20\n" + "Why wouldn't we always disable them? kvmppc_handle_exit() will enable \n" "interrupts when it's ready.\n" "\n" - -Scott= + -Scott -b38a811f38993b5c948d6370c36ce04a57ff5c73077c13ff73efbd251dad0b36 +2e0bd34d1aa7f973abdf0a9a787bda10e5b29c9ca6d1aebb3d04dbf272c4a1d8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.