From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH RFC iproute2] Add VF link state control Date: Wed, 08 May 2013 11:24:46 -0500 Message-ID: <1368030286.1664.16.camel@dcbw.foobar.com> References: <1368020717-22194-1-git-send-email-ogerlitz@mellanox.com> <1368020717-22194-4-git-send-email-ogerlitz@mellanox.com> <20130508091753.0be79e6c@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Or Gerlitz , netdev@vger.kernel.org, amirv@mellanox.com, ronye@mellanox.com To: Stephen Hemminger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45467 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756129Ab3EHQYp (ORCPT ); Wed, 8 May 2013 12:24:45 -0400 In-Reply-To: <20130508091753.0be79e6c@nehalam.linuxnetplumber.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2013-05-08 at 09:17 -0700, Stephen Hemminger wrote: > On Wed, 8 May 2013 16:45:17 +0300 > Or Gerlitz wrote: > > > From: Rony Efraim > > > > Add link state per VF command > > > > Signed-off-by: Rony Efraim > > Isn't this redundant with OPERSTATE and LOWER_DOWN? I was going to say it was mostly redundant with the "set carrier from userspace" patches from jpirko last December, but since a VF doesn't appear to always have a netdev, it seems that functionality has to be special-cased for VFs instead of being generic :( Dan