diff for duplicates of <1368225837.19683.13@snotra> diff --git a/a/1.txt b/N1/1.txt index ac09731..fec9bf8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,24 +1,24 @@ On 05/10/2013 12:01:19 AM, Bhushan Bharat-R65777 wrote: -> -> +>=20 +>=20 > > -----Original Message----- -> > From: kvm-ppc-owner@vger.kernel.org +> > From: kvm-ppc-owner@vger.kernel.org =20 > [mailto:kvm-ppc-owner@vger.kernel.org] On > > Behalf Of Scott Wood > > Sent: Friday, May 10, 2013 8:40 AM > > To: Alexander Graf; Benjamin Herrenschmidt -> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; +> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; =20 > linuxppc-dev@lists.ozlabs.org; > > Wood Scott-B07421 > > Subject: [PATCH v2 2/4] kvm/ppc/booke64: Fix lazy ee handling in > > kvmppc_handle_exit() > > > > EE is hard-disabled on entry to kvmppc_handle_exit(), so call -> > hard_irq_disable() so that PACA_IRQ_HARD_DIS is set, and +> > hard_irq_disable() so that PACA_IRQ_HARD_DIS is set, and =20 > soft_enabled > > is unset. > > -> > Without this, we get warnings such as +> > Without this, we get warnings such as =20 > arch/powerpc/kernel/time.c:300, > > and sometimes host kernel hangs. > > @@ -31,21 +31,21 @@ On 05/10/2013 12:01:19 AM, Bhushan Bharat-R65777 wrote: > > index 1020119..705fc5c 100644 > > --- a/arch/powerpc/kvm/booke.c > > +++ b/arch/powerpc/kvm/booke.c -> > @@ -833,6 +833,11 @@ int kvmppc_handle_exit(struct kvm_run *run, +> > @@ -833,6 +833,11 @@ int kvmppc_handle_exit(struct kvm_run *run, =20 > struct kvm_vcpu > > *vcpu, -> > int r = RESUME_HOST; +> > int r =3D RESUME_HOST; > > int s; > > > > +#ifdef CONFIG_PPC64 -> > + WARN_ON(local_paca->irq_happened != 0); +> > + WARN_ON(local_paca->irq_happened !=3D 0); > > +#endif > > + hard_irq_disable(); -> -> It is not actually to hard disable as EE is already clear but to make +>=20 +> It is not actually to hard disable as EE is already clear but to make =20 > it looks like hard_disable to host. Right? > If so, should we write a comment here on why we are doing this? Yes, I can add a comment. --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index bd254c6..00e6510 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,38 +3,36 @@ "ref\06A3DF150A5B70D4F9B66A25E3F7C888D0700F847@039-SN2MPN1-011.039d.mgd.msft.net\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH v2 2/4] kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()\0" - "Date\0Fri, 10 May 2013 22:43:57 +0000\0" + "Date\0Fri, 10 May 2013 17:43:57 -0500\0" "To\0Bhushan Bharat-R65777 <R65777@freescale.com>\0" "Cc\0Wood Scott-B07421 <B07421@freescale.com>" + kvm@vger.kernel.org <kvm@vger.kernel.org> Alexander Graf <agraf@suse.de> - Benjamin Herrenschmidt <benh@kernel.crashing.org> kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org> - kvm@vger.kernel.org <kvm@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - " Wood Scott-B07421 <B07421@freescale.com>\0" + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 05/10/2013 12:01:19 AM, Bhushan Bharat-R65777 wrote:\n" - "> \n" - "> \n" + ">=20\n" + ">=20\n" "> > -----Original Message-----\n" - "> > From: kvm-ppc-owner@vger.kernel.org \n" + "> > From: kvm-ppc-owner@vger.kernel.org =20\n" "> [mailto:kvm-ppc-owner@vger.kernel.org] On\n" "> > Behalf Of Scott Wood\n" "> > Sent: Friday, May 10, 2013 8:40 AM\n" "> > To: Alexander Graf; Benjamin Herrenschmidt\n" - "> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; \n" + "> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; =20\n" "> linuxppc-dev@lists.ozlabs.org;\n" "> > Wood Scott-B07421\n" "> > Subject: [PATCH v2 2/4] kvm/ppc/booke64: Fix lazy ee handling in\n" "> > kvmppc_handle_exit()\n" "> >\n" "> > EE is hard-disabled on entry to kvmppc_handle_exit(), so call\n" - "> > hard_irq_disable() so that PACA_IRQ_HARD_DIS is set, and \n" + "> > hard_irq_disable() so that PACA_IRQ_HARD_DIS is set, and =20\n" "> soft_enabled\n" "> > is unset.\n" "> >\n" - "> > Without this, we get warnings such as \n" + "> > Without this, we get warnings such as =20\n" "> arch/powerpc/kernel/time.c:300,\n" "> > and sometimes host kernel hangs.\n" "> >\n" @@ -47,23 +45,23 @@ "> > index 1020119..705fc5c 100644\n" "> > --- a/arch/powerpc/kvm/booke.c\n" "> > +++ b/arch/powerpc/kvm/booke.c\n" - "> > @@ -833,6 +833,11 @@ int kvmppc_handle_exit(struct kvm_run *run, \n" + "> > @@ -833,6 +833,11 @@ int kvmppc_handle_exit(struct kvm_run *run, =20\n" "> struct kvm_vcpu\n" "> > *vcpu,\n" - "> > \tint r = RESUME_HOST;\n" + "> > \tint r =3D RESUME_HOST;\n" "> > \tint s;\n" "> >\n" "> > +#ifdef CONFIG_PPC64\n" - "> > +\tWARN_ON(local_paca->irq_happened != 0);\n" + "> > +\tWARN_ON(local_paca->irq_happened !=3D 0);\n" "> > +#endif\n" "> > +\thard_irq_disable();\n" - "> \n" - "> It is not actually to hard disable as EE is already clear but to make \n" + ">=20\n" + "> It is not actually to hard disable as EE is already clear but to make =20\n" "> it looks like hard_disable to host. Right?\n" "> If so, should we write a comment here on why we are doing this?\n" "\n" "Yes, I can add a comment.\n" "\n" - -Scott + -Scott= -6b7070712a6c82bafae9bdc9c855bebd0eb735a8e98b3eae25d6c684b9c032d9 +6dfd86096214800370b7ce7dad476209d887c90ac7e652324cadbccd0755d531
diff --git a/a/content_digest b/N2/content_digest index bd254c6..f49a120 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\06A3DF150A5B70D4F9B66A25E3F7C888D0700F847@039-SN2MPN1-011.039d.mgd.msft.net\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH v2 2/4] kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()\0" - "Date\0Fri, 10 May 2013 22:43:57 +0000\0" + "Date\0Fri, 10 May 2013 17:43:57 -0500\0" "To\0Bhushan Bharat-R65777 <R65777@freescale.com>\0" "Cc\0Wood Scott-B07421 <B07421@freescale.com>" Alexander Graf <agraf@suse.de> @@ -66,4 +66,4 @@ "\n" -Scott -6b7070712a6c82bafae9bdc9c855bebd0eb735a8e98b3eae25d6c684b9c032d9 +e43ca6c1203e554850331ba1e3748e6da82f99ce9d82c45c04ea68c0ae93e73b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.