diff for duplicates of <1368226403.19683.15@snotra> diff --git a/a/1.txt b/N1/1.txt index 420fe8f..e0bdba8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ On 05/10/2013 12:01:38 AM, Bhushan Bharat-R65777 wrote: -> -> +>=20 +>=20 > > -----Original Message----- -> > From: kvm-ppc-owner@vger.kernel.org +> > From: kvm-ppc-owner@vger.kernel.org =20 > [mailto:kvm-ppc-owner@vger.kernel.org] On > > Behalf Of Scott Wood > > Sent: Friday, May 10, 2013 8:40 AM > > To: Alexander Graf; Benjamin Herrenschmidt -> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; +> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; =20 > linuxppc-dev@lists.ozlabs.org; > > Wood Scott-B07421 > > Subject: [PATCH v2 4/4] kvm/ppc: IRQ disabling cleanup @@ -15,43 +15,43 @@ On 05/10/2013 12:01:38 AM, Bhushan Bharat-R65777 wrote: > > - WARN_ON_ONCE(!irqs_disabled()); > > + WARN_ON(irqs_disabled()); > > + hard_irq_disable(); -> -> Here we hard disable in kvmppc_prepare_to_enter(), so my comment in +>=20 +> Here we hard disable in kvmppc_prepare_to_enter(), so my comment in =20 > other patch about interrupt loss is no more valid. -> +>=20 > So here -> MSR.EE = 0 -> local_paca->soft_enabled = 0 -> local_paca->irq_happened |= PACA_IRQ_HARD_DIS; -> +> MSR.EE =3D 0 +> local_paca->soft_enabled =3D 0 +> local_paca->irq_happened |=3D PACA_IRQ_HARD_DIS; +>=20 > > + > > while (true) { > > if (need_resched()) { > > local_irq_enable(); -> +>=20 > This will make the state: -> MSR.EE = 1 -> local_paca->soft_enabled = 1 -> local_paca->irq_happened = PACA_IRQ_HARD_DIS; //same as before -> -> Is that a valid state where interrupts are fully enabled and +> MSR.EE =3D 1 +> local_paca->soft_enabled =3D 1 +> local_paca->irq_happened =3D PACA_IRQ_HARD_DIS; //same as before +>=20 +> Is that a valid state where interrupts are fully enabled and =20 > irq_happend in not 0? -PACA_IRQ_HARD_DIS will have been cleared by local_irq_enable(), as +PACA_IRQ_HARD_DIS will have been cleared by local_irq_enable(), as =20 Tiejun pointed out. > int kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu) > { -> int r = 0; +> int r =3D 0; > WARN_ON_ONCE(!irqs_disabled()); -> +>=20 > kvmppc_core_check_exceptions(vcpu); -> +>=20 > if (vcpu->requests) { > /* Exception delivery raised request; start over */ > return 1; > } -> +>=20 > if (vcpu->arch.shared->msr & MSR_WE) { > local_irq_enable(); > kvm_vcpu_block(vcpu); @@ -60,10 +60,10 @@ Tiejun pointed out. > ^^^ > We do not require hard_irq_disable() here? -Yes, that should be changed to hard_irq_disable(), and I'll add a -WARN_ON to double check that interrupts are hard-disabled (eventually -we'll probably want to make these critical-path assertions dependent on -a debug option...). It doesn't really matter all that much, though, +Yes, that should be changed to hard_irq_disable(), and I'll add a =20 +WARN_ON to double check that interrupts are hard-disabled (eventually =20 +we'll probably want to make these critical-path assertions dependent on =20 +a debug option...). It doesn't really matter all that much, though, =20 since we don't have MSR_WE on any 64-bit booke chips. :-) --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index b2f94fc..41b6595 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,27 +3,25 @@ "ref\06A3DF150A5B70D4F9B66A25E3F7C888D0700F859@039-SN2MPN1-011.039d.mgd.msft.net\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH v2 4/4] kvm/ppc: IRQ disabling cleanup\0" - "Date\0Fri, 10 May 2013 22:53:23 +0000\0" + "Date\0Fri, 10 May 2013 17:53:23 -0500\0" "To\0Bhushan Bharat-R65777 <R65777@freescale.com>\0" "Cc\0Wood Scott-B07421 <B07421@freescale.com>" + kvm@vger.kernel.org <kvm@vger.kernel.org> Alexander Graf <agraf@suse.de> - Benjamin Herrenschmidt <benh@kernel.crashing.org> kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org> - kvm@vger.kernel.org <kvm@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - " Wood Scott-B07421 <B07421@freescale.com>\0" + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 05/10/2013 12:01:38 AM, Bhushan Bharat-R65777 wrote:\n" - "> \n" - "> \n" + ">=20\n" + ">=20\n" "> > -----Original Message-----\n" - "> > From: kvm-ppc-owner@vger.kernel.org \n" + "> > From: kvm-ppc-owner@vger.kernel.org =20\n" "> [mailto:kvm-ppc-owner@vger.kernel.org] On\n" "> > Behalf Of Scott Wood\n" "> > Sent: Friday, May 10, 2013 8:40 AM\n" "> > To: Alexander Graf; Benjamin Herrenschmidt\n" - "> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; \n" + "> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; =20\n" "> linuxppc-dev@lists.ozlabs.org;\n" "> > Wood Scott-B07421\n" "> > Subject: [PATCH v2 4/4] kvm/ppc: IRQ disabling cleanup\n" @@ -31,43 +29,43 @@ "> > -\tWARN_ON_ONCE(!irqs_disabled());\n" "> > +\tWARN_ON(irqs_disabled());\n" "> > +\thard_irq_disable();\n" - "> \n" - "> Here we hard disable in kvmppc_prepare_to_enter(), so my comment in \n" + ">=20\n" + "> Here we hard disable in kvmppc_prepare_to_enter(), so my comment in =20\n" "> other patch about interrupt loss is no more valid.\n" - "> \n" + ">=20\n" "> So here\n" - "> MSR.EE = 0\n" - "> local_paca->soft_enabled = 0\n" - "> local_paca->irq_happened |= PACA_IRQ_HARD_DIS;\n" - "> \n" + "> MSR.EE =3D 0\n" + "> local_paca->soft_enabled =3D 0\n" + "> local_paca->irq_happened |=3D PACA_IRQ_HARD_DIS;\n" + ">=20\n" "> > +\n" "> > \twhile (true) {\n" "> > \t\tif (need_resched()) {\n" "> > \t\t\tlocal_irq_enable();\n" - "> \n" + ">=20\n" "> This will make the state:\n" - "> MSR.EE = 1\n" - "> local_paca->soft_enabled = 1\n" - "> local_paca->irq_happened = PACA_IRQ_HARD_DIS; //same as before\n" - "> \n" - "> Is that a valid state where interrupts are fully enabled and \n" + "> MSR.EE =3D 1\n" + "> local_paca->soft_enabled =3D 1\n" + "> local_paca->irq_happened =3D PACA_IRQ_HARD_DIS; //same as before\n" + ">=20\n" + "> Is that a valid state where interrupts are fully enabled and =20\n" "> irq_happend in not 0?\n" "\n" - "PACA_IRQ_HARD_DIS will have been cleared by local_irq_enable(), as \n" + "PACA_IRQ_HARD_DIS will have been cleared by local_irq_enable(), as =20\n" "Tiejun pointed out.\n" "\n" "> int kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu)\n" "> {\n" - "> int r = 0;\n" + "> int r =3D 0;\n" "> WARN_ON_ONCE(!irqs_disabled());\n" - "> \n" + ">=20\n" "> kvmppc_core_check_exceptions(vcpu);\n" - "> \n" + ">=20\n" "> if (vcpu->requests) {\n" "> /* Exception delivery raised request; start over */\n" "> return 1;\n" "> }\n" - "> \n" + ">=20\n" "> if (vcpu->arch.shared->msr & MSR_WE) {\n" "> local_irq_enable();\n" "> kvm_vcpu_block(vcpu);\n" @@ -76,12 +74,12 @@ "> ^^^\n" "> We do not require hard_irq_disable() here?\n" "\n" - "Yes, that should be changed to hard_irq_disable(), and I'll add a \n" - "WARN_ON to double check that interrupts are hard-disabled (eventually \n" - "we'll probably want to make these critical-path assertions dependent on \n" - "a debug option...). It doesn't really matter all that much, though, \n" + "Yes, that should be changed to hard_irq_disable(), and I'll add a =20\n" + "WARN_ON to double check that interrupts are hard-disabled (eventually =20\n" + "we'll probably want to make these critical-path assertions dependent on =20\n" + "a debug option...). It doesn't really matter all that much, though, =20\n" "since we don't have MSR_WE on any 64-bit booke chips. :-)\n" "\n" - -Scott + -Scott= -f785d66e4641c3ff265cdbd0d9d265880bcbb226e307f91d6bc33fe4ae28c1bd +2b1711509f7073511ef6686b4edc894f9dc477b2673ea85b2e89672c39440910
diff --git a/a/content_digest b/N2/content_digest index b2f94fc..45c4089 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\06A3DF150A5B70D4F9B66A25E3F7C888D0700F859@039-SN2MPN1-011.039d.mgd.msft.net\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH v2 4/4] kvm/ppc: IRQ disabling cleanup\0" - "Date\0Fri, 10 May 2013 22:53:23 +0000\0" + "Date\0Fri, 10 May 2013 17:53:23 -0500\0" "To\0Bhushan Bharat-R65777 <R65777@freescale.com>\0" "Cc\0Wood Scott-B07421 <B07421@freescale.com>" Alexander Graf <agraf@suse.de> @@ -84,4 +84,4 @@ "\n" -Scott -f785d66e4641c3ff265cdbd0d9d265880bcbb226e307f91d6bc33fe4ae28c1bd +b5d11214bfbd89a1b7d76d7061daaa065f6d920004c4362bce948385362400c2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.