From: Matthew Garrett <matthew.garrett@nebula.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Emmanuel Grumbach <egrumbach@gmail.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Roman Yepishev <roman.yepishev@gmail.com>,
"Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
Mike Miller <mike.miller@hp.com>,
"iss_storagedev@hp.com" <iss_storagedev@hp.com>,
Guo-Fu Tseng <cooldavid@cooldavid.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Francois Romieu <romieu@fr.zoreil.com>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"aacraid@adaptec.com" <aacraid@adaptec.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: is L1 really disabled in iwlwifi
Date: Sat, 11 May 2013 20:22:11 +0000 [thread overview]
Message-ID: <1368303730.2425.47.camel@x230> (raw)
In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan>
T24gU2F0LCAyMDEzLTA1LTExIGF0IDIyOjI2ICswMjAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90
ZToNCj4gT24gRnJpZGF5LCBNYXkgMTAsIDIwMTMgMDQ6NTI6NTcgUE0gQmpvcm4gSGVsZ2FhcyB3
cm90ZToNCj4gPiBJIHByb3Bvc2UgdGhlIGZvbGxvd2luZyBwYXRjaC4gIEFueSBjb21tZW50cz8N
Cj4gDQo+IEluIG15IG9waW5pb24gdGhpcyBpcyBkYW5nZXJvdXMsIGJlY2F1c2UgaXQgb3BlbnMg
dXMgdG8gYnVncyB0aGF0IHJpZ2h0IG5vdw0KPiBhcmUgcHJldmVudGVkIGZyb20gaGFwcGVuaW5n
IGR1ZSB0byB0aGUgd2F5IHRoZSBjb2RlIHdvcmtzLg0KDQpSaWdodCwgSSdtIGFsc28gbm90IGVu
dGlyZWx5IGNvbWZvcnRhYmxlIHdpdGggdGhpcy4gVGhlIGN1cnJlbnQNCmJlaGF2aW91ciBtYXkg
YmUgY29uZnVzaW5nLCBidXQgd2UgY291bGQgcmVkdWNlIHRoYXQgYnkgcmVuYW1pbmcgdGhlDQpm
dW5jdGlvbnMuIEknbSBzdGlsbCBub3QgY2xlYXIgb24gd2hldGhlciBhbnlvbmUncyBhY3R1YWxs
eSBzZWVpbmcNCnByb2JsZW1zIGNhdXNlZCBieSB0aGUgZXhpc3RpbmcgYmVoYXZpb3VyLg0KDQot
LSANCk1hdHRoZXcgR2FycmV0dCB8IG1qZzU5QHNyY2YudWNhbS5vcmcNCg==
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Emmanuel Grumbach <egrumbach@gmail.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Roman Yepishev <roman.yepishev@gmail.com>,
"Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
Mike Miller <mike.miller@hp.com>,
"iss_storagedev@hp.com" <iss_storagedev@hp.com>,
Guo-Fu Tseng <cooldavid@cooldavid.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Francois Romieu <romieu@fr.zoreil.com>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"aacraid@adaptec.com" <aacraid@adaptec.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: is L1 really disabled in iwlwifi
Date: Sat, 11 May 2013 20:22:11 +0000 [thread overview]
Message-ID: <1368303730.2425.47.camel@x230> (raw)
In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 759 bytes --]
On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote:
> On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote:
> > I propose the following patch. Any comments?
>
> In my opinion this is dangerous, because it opens us to bugs that right now
> are prevented from happening due to the way the code works.
Right, I'm also not entirely comfortable with this. The current
behaviour may be confusing, but we could reduce that by renaming the
functions. I'm still not clear on whether anyone's actually seeing
problems caused by the existing behaviour.
--
Matthew Garrett | mjg59@srcf.ucam.org
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Emmanuel Grumbach <egrumbach@gmail.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Roman Yepishev <roman.yepishev@gmail.com>,
"Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
Mike Miller <mike.miller@hp.com>,
"iss_storagedev@hp.com" <iss_storagedev@hp.com>,
Guo-Fu Tseng <cooldavid@cooldavid.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Francois Romieu <romieu@fr.zoreil.com>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"aacraid@adaptec.com" <aacraid@adaptec.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: is L1 really disabled in iwlwifi
Date: Sat, 11 May 2013 20:22:11 +0000 [thread overview]
Message-ID: <1368303730.2425.47.camel@x230> (raw)
In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan>
On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote:
> On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote:
> > I propose the following patch. Any comments?
>
> In my opinion this is dangerous, because it opens us to bugs that right now
> are prevented from happening due to the way the code works.
Right, I'm also not entirely comfortable with this. The current
behaviour may be confusing, but we could reduce that by renaming the
functions. I'm still not clear on whether anyone's actually seeing
problems caused by the existing behaviour.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-05-11 20:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 8:41 is L1 really disabled in iwlwifi Emmanuel Grumbach
2013-03-04 13:44 ` John W. Linville
2013-03-04 13:49 ` Stanislaw Gruszka
2013-03-04 14:57 ` Emmanuel Grumbach
2013-03-04 15:11 ` John W. Linville
2013-03-04 15:48 ` Stanislaw Gruszka
2013-03-04 17:58 ` Emmanuel Grumbach
2013-03-17 15:59 ` Roman Yepishev
2013-03-29 18:24 ` Bjorn Helgaas
2013-03-30 18:38 ` Emmanuel Grumbach
2013-03-30 21:26 ` Bjorn Helgaas
2013-04-02 11:10 ` Emmanuel Grumbach
2013-04-02 11:12 ` Emmanuel Grumbach
2013-04-07 12:23 ` Emmanuel Grumbach
2013-04-08 16:28 ` Bjorn Helgaas
2013-04-09 5:29 ` Emmanuel Grumbach
2013-04-30 10:57 ` Emmanuel Grumbach
2013-04-30 22:45 ` Bjorn Helgaas
2013-04-30 22:55 ` Matthew Garrett
2013-05-01 8:31 ` Emmanuel Grumbach
2013-05-01 17:13 ` Bjorn Helgaas
2013-05-10 22:52 ` Bjorn Helgaas
2013-05-10 22:52 ` Bjorn Helgaas
2013-05-11 20:26 ` Rafael J. Wysocki
2013-05-11 20:26 ` Rafael J. Wysocki
2013-05-11 20:22 ` Matthew Garrett [this message]
2013-05-11 20:22 ` Matthew Garrett
2013-05-11 20:22 ` Matthew Garrett
2013-05-16 22:55 ` Bjorn Helgaas
2013-05-17 5:49 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368303730.2425.47.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=aacraid@adaptec.com \
--cc=bhelgaas@google.com \
--cc=cooldavid@cooldavid.org \
--cc=egrumbach@gmail.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mike.miller@hp.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=rjw@sisk.pl \
--cc=roman.yepishev@gmail.com \
--cc=romieu@fr.zoreil.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.