From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-db8lp0185.outbound.messaging.microsoft.com ([213.199.154.185]:28726 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879Ab3EKUWU (ORCPT ); Sat, 11 May 2013 16:22:20 -0400 From: Matthew Garrett To: "Rafael J. Wysocki" CC: Bjorn Helgaas , Emmanuel Grumbach , Stanislaw Gruszka , "linux-pci@vger.kernel.org" , linux-wireless , John Linville , Roman Yepishev , "Guy, Wey-Yi" , Mike Miller , "iss_storagedev@hp.com" , Guo-Fu Tseng , "netdev@vger.kernel.org" , Francois Romieu , "nic_swsd@realtek.com" , "aacraid@adaptec.com" , "linux-kernel@vger.kernel.org" Subject: Re: is L1 really disabled in iwlwifi Date: Sat, 11 May 2013 20:22:11 +0000 Message-ID: <1368303730.2425.47.camel@x230> References: <20130510225257.GA10847@google.com> <1725435.3DlCxYF2FV@vostro.rjw.lan> In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: T24gU2F0LCAyMDEzLTA1LTExIGF0IDIyOjI2ICswMjAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToNCj4gT24gRnJpZGF5LCBNYXkgMTAsIDIwMTMgMDQ6NTI6NTcgUE0gQmpvcm4gSGVsZ2FhcyB3 cm90ZToNCj4gPiBJIHByb3Bvc2UgdGhlIGZvbGxvd2luZyBwYXRjaC4gIEFueSBjb21tZW50cz8N Cj4gDQo+IEluIG15IG9waW5pb24gdGhpcyBpcyBkYW5nZXJvdXMsIGJlY2F1c2UgaXQgb3BlbnMg dXMgdG8gYnVncyB0aGF0IHJpZ2h0IG5vdw0KPiBhcmUgcHJldmVudGVkIGZyb20gaGFwcGVuaW5n IGR1ZSB0byB0aGUgd2F5IHRoZSBjb2RlIHdvcmtzLg0KDQpSaWdodCwgSSdtIGFsc28gbm90IGVu dGlyZWx5IGNvbWZvcnRhYmxlIHdpdGggdGhpcy4gVGhlIGN1cnJlbnQNCmJlaGF2aW91ciBtYXkg YmUgY29uZnVzaW5nLCBidXQgd2UgY291bGQgcmVkdWNlIHRoYXQgYnkgcmVuYW1pbmcgdGhlDQpm dW5jdGlvbnMuIEknbSBzdGlsbCBub3QgY2xlYXIgb24gd2hldGhlciBhbnlvbmUncyBhY3R1YWxs eSBzZWVpbmcNCnByb2JsZW1zIGNhdXNlZCBieSB0aGUgZXhpc3RpbmcgYmVoYXZpb3VyLg0KDQot LSANCk1hdHRoZXcgR2FycmV0dCB8IG1qZzU5QHNyY2YudWNhbS5vcmcNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754207Ab3EKUWW (ORCPT ); Sat, 11 May 2013 16:22:22 -0400 Received: from mail-db8lp0185.outbound.messaging.microsoft.com ([213.199.154.185]:28726 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879Ab3EKUWU (ORCPT ); Sat, 11 May 2013 16:22:20 -0400 X-Forefront-Antispam-Report: CIP:157.56.236.101;KIP:(null);UIP:(null);IPV:NLI;H:BY2PRD0510HT005.namprd05.prod.outlook.com;RD:none;EFVD:NLI X-SpamScore: -5 X-BigFish: PS-5(zz98dI9371I936eI1432Idf9Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzz8275dhz2fh2a8h668h839h93fhd24hd2bhf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1d0ch1d2eh1d3fh1155h) From: Matthew Garrett To: "Rafael J. Wysocki" CC: Bjorn Helgaas , Emmanuel Grumbach , Stanislaw Gruszka , "linux-pci@vger.kernel.org" , linux-wireless , John Linville , Roman Yepishev , "Guy, Wey-Yi" , Mike Miller , "iss_storagedev@hp.com" , Guo-Fu Tseng , "netdev@vger.kernel.org" , Francois Romieu , "nic_swsd@realtek.com" , "aacraid@adaptec.com" , "linux-kernel@vger.kernel.org" Subject: Re: is L1 really disabled in iwlwifi Thread-Topic: is L1 really disabled in iwlwifi Thread-Index: AQHORfSKftx1y5ISNk+G0CEFeiZmAZjvX74AgACg4YCAAJHNgIAOg+SAgAFphoD///6uAA== Date: Sat, 11 May 2013 20:22:11 +0000 Message-ID: <1368303730.2425.47.camel@x230> References: <20130510225257.GA10847@google.com> <1725435.3DlCxYF2FV@vostro.rjw.lan> In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.4] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r4BKMTKu027420 On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote: > On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote: > > I propose the following patch. Any comments? > > In my opinion this is dangerous, because it opens us to bugs that right now > are prevented from happening due to the way the code works. Right, I'm also not entirely comfortable with this. The current behaviour may be confusing, but we could reduce that by renaming the functions. I'm still not clear on whether anyone's actually seeing problems caused by the existing behaviour. -- Matthew Garrett | mjg59@srcf.ucam.org {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: is L1 really disabled in iwlwifi Date: Sat, 11 May 2013 20:22:11 +0000 Message-ID: <1368303730.2425.47.camel@x230> References: <20130510225257.GA10847@google.com> <1725435.3DlCxYF2FV@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Bjorn Helgaas , Emmanuel Grumbach , Stanislaw Gruszka , "linux-pci@vger.kernel.org" , linux-wireless , John Linville , Roman Yepishev , "Guy, Wey-Yi" , Mike Miller , "iss_storagedev@hp.com" , Guo-Fu Tseng , "netdev@vger.kernel.org" , Francois Romieu , "nic_swsd@realtek.com" , "aacraid@adaptec.com" , "linux-kernel@vger.kernel.org" To: "Rafael J. Wysocki" Return-path: In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan> Content-Language: en-US Content-ID: Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org T24gU2F0LCAyMDEzLTA1LTExIGF0IDIyOjI2ICswMjAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToNCj4gT24gRnJpZGF5LCBNYXkgMTAsIDIwMTMgMDQ6NTI6NTcgUE0gQmpvcm4gSGVsZ2FhcyB3 cm90ZToNCj4gPiBJIHByb3Bvc2UgdGhlIGZvbGxvd2luZyBwYXRjaC4gIEFueSBjb21tZW50cz8N Cj4gDQo+IEluIG15IG9waW5pb24gdGhpcyBpcyBkYW5nZXJvdXMsIGJlY2F1c2UgaXQgb3BlbnMg dXMgdG8gYnVncyB0aGF0IHJpZ2h0IG5vdw0KPiBhcmUgcHJldmVudGVkIGZyb20gaGFwcGVuaW5n IGR1ZSB0byB0aGUgd2F5IHRoZSBjb2RlIHdvcmtzLg0KDQpSaWdodCwgSSdtIGFsc28gbm90IGVu dGlyZWx5IGNvbWZvcnRhYmxlIHdpdGggdGhpcy4gVGhlIGN1cnJlbnQNCmJlaGF2aW91ciBtYXkg YmUgY29uZnVzaW5nLCBidXQgd2UgY291bGQgcmVkdWNlIHRoYXQgYnkgcmVuYW1pbmcgdGhlDQpm dW5jdGlvbnMuIEknbSBzdGlsbCBub3QgY2xlYXIgb24gd2hldGhlciBhbnlvbmUncyBhY3R1YWxs eSBzZWVpbmcNCnByb2JsZW1zIGNhdXNlZCBieSB0aGUgZXhpc3RpbmcgYmVoYXZpb3VyLg0KDQot LSANCk1hdHRoZXcgR2FycmV0dCB8IG1qZzU5QHNyY2YudWNhbS5vcmcNCg==