All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/p1022ds: boot from SD card/SPI flash with SPL
Date: Mon, 13 May 2013 09:47:36 -0500	[thread overview]
Message-ID: <1368456456.8202.4@snotra> (raw)
In-Reply-To: <B3A295C5BD5B13458B2F5C6AFAD910466E1F76@039-SN2MPN1-021.039d.mgd.msft.net> (from B40530@freescale.com on Mon May 13 05:17:40 2013)

On 05/13/2013 05:17:40 AM, Zhang Ying-B40530 wrote:
> 
> > diff --git a/spl/Makefile b/spl/Makefile
> > index b5a8de7..3a3b868 100644
> > --- a/spl/Makefile
> > +++ b/spl/Makefile
> > @@ -51,6 +51,9 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o
> >  endif
> >  ifeq ($(CPU),mpc85xx)
> >  LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o
> > +ifdef CONFIG_SPL_INIT_DDR_SUPPORT
> > +LIBS-y += arch/powerpc/cpu/mpc8xxx/ddr/libddr.o
> > +endif
> 
> Why isn't this handled as part of lib8xxx.o?  We should avoid putting
> hardware-specific things in generic Makefiles.  There ones that are
> already there should be fixed at some point.
> [Zhang Ying]
> Do you mean that all things of the directory "  
> arch/powerpc/cpu/mpc8xxx/ddr "
> will be moved to the directory "arch/powerpc/cpu/mpc8xxx/"?

No.  I meant that arch/powerpc/cpu/mpc8xxx/Makefile should contain the  
LIBS addition for the subdirectory, but apparently it doesn't work that  
way even in non-SPL.  So ignore this; it's more of a future makefile  
cleanup issue.

-Scott

      reply	other threads:[~2013-05-13 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 10:04 [U-Boot] [PATCH] powerpc/p1022ds: boot from SD card/SPI flash with SPL ying.zhang at freescale.com
2013-05-09  0:12 ` Scott Wood
2013-05-10  8:44   ` Zhang Ying-B40530
2013-05-11  0:45     ` Scott Wood
2013-05-13 10:17   ` Zhang Ying-B40530
2013-05-13 14:47     ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368456456.8202.4@snotra \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.