From: Lad Prabhakar <prabhakar.csengg@gmail.com>
To: LMML <linux-media@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata
Date: Wed, 15 May 2013 17:27:17 +0530 [thread overview]
Message-ID: <1368619042-28252-2-git-send-email-prabhakar.csengg@gmail.com> (raw)
In-Reply-To: <1368619042-28252-1-git-send-email-prabhakar.csengg@gmail.com>
From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
This patch removes init_enable option from pdata, the init_enable
was intended that the device should start streaming video immediately
but ideally the bridge drivers should call s_stream explicitly for such
devices to start video.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-kernel@vger.kernel.org
Cc: davinci-linux-open-source@linux.davincidsp.com
---
drivers/media/i2c/ths7303.c | 4 +---
include/media/ths7303.h | 2 --
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c
index 65853ee..8cddcd0 100644
--- a/drivers/media/i2c/ths7303.c
+++ b/drivers/media/i2c/ths7303.c
@@ -356,9 +356,7 @@ static int ths7303_setup(struct v4l2_subdev *sd)
int ret;
u8 mask;
- state->stream_on = pdata->init_enable;
-
- mask = state->stream_on ? 0xff : 0xf8;
+ mask = 0xf8;
ret = ths7303_write(sd, THS7303_CHANNEL_1, pdata->ch_1 & mask);
if (ret)
diff --git a/include/media/ths7303.h b/include/media/ths7303.h
index 980ec51..a7b4929 100644
--- a/include/media/ths7303.h
+++ b/include/media/ths7303.h
@@ -30,13 +30,11 @@
* @ch_1: Bias value for channel one.
* @ch_2: Bias value for channel two.
* @ch_3: Bias value for channel three.
- * @init_enable: initalize on init.
*/
struct ths7303_platform_data {
u8 ch_1;
u8 ch_2;
u8 ch_3;
- u8 init_enable;
};
#endif
--
1.7.4.1
next prev parent reply other threads:[~2013-05-15 11:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 11:57 [PATCH 0/6] media: i2c: ths7303 feature enhancement and cleanup Lad Prabhakar
2013-05-15 11:57 ` Lad Prabhakar [this message]
2013-05-16 22:37 ` [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata Sakari Ailus
2013-05-17 4:56 ` Prabhakar Lad
2013-05-15 11:57 ` [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata Lad Prabhakar
2013-05-15 11:57 ` Lad Prabhakar
2013-05-15 12:05 ` Laurent Pinchart
2013-05-15 12:05 ` Laurent Pinchart
2013-05-15 12:11 ` Prabhakar Lad
2013-05-15 12:11 ` Prabhakar Lad
2013-05-16 11:48 ` Prabhakar Lad
2013-05-16 11:48 ` Prabhakar Lad
2013-05-16 11:54 ` Laurent Pinchart
2013-05-16 11:54 ` Laurent Pinchart
2013-05-23 9:10 ` Prabhakar Lad
2013-05-23 9:10 ` Prabhakar Lad
2013-05-15 11:57 ` [PATCH 3/6] media: i2c: ths7303: remove unnecessary function ths7303_setup() Lad Prabhakar
2013-05-15 11:57 ` [PATCH 4/6] media: i2c: ths7303: make the pdata as a constant pointer Lad Prabhakar
2013-05-15 11:57 ` [PATCH 5/6] media: i2c: ths7303: add support for asynchronous probing Lad Prabhakar
2013-05-15 11:57 ` [PATCH 6/6] media: i2c: ths7303: add OF support Lad Prabhakar
2013-05-23 8:51 ` [PATCH 0/6] media: i2c: ths7303 feature enhancement and cleanup Hans Verkuil
2013-05-23 9:07 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368619042-28252-2-git-send-email-prabhakar.csengg@gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.