From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 8/9] for-each-ref: merge show_ref into show_refs
Date: Sun, 19 May 2013 17:27:14 +0700 [thread overview]
Message-ID: <1368959235-27777-9-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1368959235-27777-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
builtin/for-each-ref.c | 39 +++++++++++++++++++--------------------
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index a9d189c..1390da8 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -989,29 +989,12 @@ static void emit(struct strbuf *sb, const char *cp, const char *ep)
}
}
-static void show_ref(struct strbuf *sb, struct refinfo *info,
- const char *format, int quote_style)
-{
- const char *cp, *sp, *ep;
-
- for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) {
- ep = strchr(sp, ')');
- if (cp < sp)
- emit(sb, cp, sp);
- print_value(sb, info, parse_atom(sp + 2, ep), quote_style);
- }
- if (*cp) {
- sp = cp + strlen(cp);
- emit(sb, cp, sp);
- }
- strbuf_addch(sb, '\n');
-}
-
static void show_refs(struct refinfo **refs, int maxcount,
const char *format, int quote_style)
{
struct strbuf *sb;
- int i;
+ const char *cp, *sp, *ep;
+ int i, atom;
sb = xmalloc(sizeof(*sb) * maxcount);
for (i = 0; i < maxcount; i++) {
@@ -1022,8 +1005,24 @@ static void show_refs(struct refinfo **refs, int maxcount,
}
}
+ for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) {
+ ep = strchr(sp, ')');
+ if (cp < sp) {
+ for (i = 0; i < maxcount; i++)
+ emit(sb + i, cp, sp);
+ }
+ atom = parse_atom(sp + 2, ep);
+ for (i = 0; i < maxcount; i++)
+ print_value(sb + i, refs[i], atom, quote_style);
+ }
+ if (*cp) {
+ sp = cp + strlen(cp);
+ for (i = 0; i < maxcount; i++)
+ emit(sb + i, cp, sp);
+ }
+
for (i = 0; i < maxcount; i++) {
- show_ref(sb + i, refs[i], format, quote_style);
+ strbuf_addch(sb + i, '\n');
fputs(sb[i].buf, stdout);
strbuf_release(sb + i);
}
--
1.8.2.83.gc99314b
next prev parent reply other threads:[~2013-05-19 10:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 10:27 [PATCH/WIP 0/9] for-each-ref format improvements Nguyễn Thái Ngọc Duy
2013-05-19 10:27 ` [PATCH 1/9] quote.c: make sq_quote_print a slight wrapper of sq_quote_buf Nguyễn Thái Ngọc Duy
2013-05-19 11:39 ` Felipe Contreras
2013-05-19 10:27 ` [PATCH 2/9] for-each-ref: convert to use *_quote_buf instead of _quote_print Nguyễn Thái Ngọc Duy
2013-05-19 11:39 ` Felipe Contreras
2013-05-19 10:27 ` [PATCH 3/9] for-each-ref: avoid printing each element directly to stdout Nguyễn Thái Ngọc Duy
2013-05-19 11:17 ` Ramkumar Ramachandra
2013-05-19 11:58 ` Duy Nguyen
2013-05-19 10:27 ` [PATCH 4/9] for-each-ref: add %(current) for current branch marker Nguyễn Thái Ngọc Duy
2013-05-19 11:14 ` Ramkumar Ramachandra
2013-05-19 10:27 ` [PATCH 5/9] for-each-ref: add %(tracking[:upstream]) for tracking info Nguyễn Thái Ngọc Duy
2013-05-19 11:18 ` Ramkumar Ramachandra
2013-05-19 11:38 ` Felipe Contreras
2013-05-19 11:43 ` Duy Nguyen
2013-05-19 11:48 ` Ramkumar Ramachandra
2013-05-19 12:03 ` Felipe Contreras
2013-05-19 10:27 ` [PATCH 6/9] for-each-ref: add %(color:...) Nguyễn Thái Ngọc Duy
2013-05-19 11:25 ` Ramkumar Ramachandra
2013-05-19 10:27 ` [PATCH 7/9] for-each-ref: prepoplulate all atoms before show_ref() Nguyễn Thái Ngọc Duy
2013-05-19 10:27 ` Nguyễn Thái Ngọc Duy [this message]
2013-05-19 10:27 ` [PATCH 9/9] for-each-ref: support %(...:aligned) for left alignment Nguyễn Thái Ngọc Duy
2013-05-19 11:32 ` Ramkumar Ramachandra
2013-05-19 11:41 ` Duy Nguyen
2013-05-19 11:11 ` [PATCH/WIP 0/9] for-each-ref format improvements Ramkumar Ramachandra
2013-05-19 11:36 ` Felipe Contreras
2013-05-19 11:54 ` Duy Nguyen
2013-05-19 12:08 ` Ramkumar Ramachandra
2013-05-19 12:28 ` Duy Nguyen
2013-05-19 13:07 ` Ramkumar Ramachandra
2013-05-20 4:29 ` Junio C Hamano
2013-05-21 17:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368959235-27777-9-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.