Re: [PATCH v6 2/5] cifs: Autogenerate SMB2 error mapping table

[David Howells <dhowells@redhat.com>]

ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev> wrote:

> David, what do you think of the modifications? Call le32_to_cpu() to get a
> cpu-endian value before comparison.

In fact, you could store the cpu-endian values in the table.  It's only
accessed by this routine (and the kunit test).  Either:

+    print(OUT_FILE "{ /*$code*/ le32_to_cpu($status), $error, \"$full_status\" },\n");

or:

+    print(OUT_FILE "{ $code, $error, \"$full_status\" },\n");

as $code is the hex status value.  You don't really need to include $status -
except that that uses the enum symbol - as the corresponding status name(s)
are included in $full_status.

David