From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 Patch] GFS2: Eliminate gfs2_rg_lops
Date: Wed, 22 May 2013 11:40:46 +0100 [thread overview]
Message-ID: <1369219246.2719.16.camel@menhir> (raw)
In-Reply-To: <1625679141.21422798.1369148044562.JavaMail.root@redhat.com>
Hi,
Added to the -nmw tree. Thanks,
Steve.
On Tue, 2013-05-21 at 10:54 -0400, Bob Peterson wrote:
> Hi,
>
> With recent changes to the transactions, it appears that we
> are no longer using the "log ops" for resource groups. Since the
> log commit code processes the array of log ops, eliminating this
> should be marginally better for performance. Therefore this patch
> eliminates it.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> fs/gfs2/lops.c | 5 -----
> fs/gfs2/lops.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index e069041..0457768 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -850,10 +850,6 @@ const struct gfs2_log_operations gfs2_revoke_lops = {
> .lo_name = "revoke",
> };
>
> -const struct gfs2_log_operations gfs2_rg_lops = {
> - .lo_name = "rg",
> -};
> -
> const struct gfs2_log_operations gfs2_databuf_lops = {
> .lo_before_commit = databuf_lo_before_commit,
> .lo_after_commit = databuf_lo_after_commit,
> @@ -865,7 +861,6 @@ const struct gfs2_log_operations gfs2_databuf_lops = {
> const struct gfs2_log_operations *gfs2_log_ops[] = {
> &gfs2_databuf_lops,
> &gfs2_buf_lops,
> - &gfs2_rg_lops,
> &gfs2_revoke_lops,
> NULL,
> };
> diff --git a/fs/gfs2/lops.h b/fs/gfs2/lops.h
> index 87e062e..9ca2e64 100644
> --- a/fs/gfs2/lops.h
> +++ b/fs/gfs2/lops.h
> @@ -23,7 +23,6 @@
> extern const struct gfs2_log_operations gfs2_glock_lops;
> extern const struct gfs2_log_operations gfs2_buf_lops;
> extern const struct gfs2_log_operations gfs2_revoke_lops;
> -extern const struct gfs2_log_operations gfs2_rg_lops;
> extern const struct gfs2_log_operations gfs2_databuf_lops;
>
> extern const struct gfs2_log_operations *gfs2_log_ops[];
>
prev parent reply other threads:[~2013-05-22 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <871458792.21418809.1369147754601.JavaMail.root@redhat.com>
2013-05-21 14:54 ` [Cluster-devel] [GFS2 Patch] GFS2: Eliminate gfs2_rg_lops Bob Peterson
2013-05-22 10:40 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369219246.2719.16.camel@menhir \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.