From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: Hibernation broken since commit 274ad65c9d02 ("drm/radeon: hard reset r600 and newer GPU when hibernating.") Date: Thu, 15 Sep 2016 11:04:25 -0400 (EDT) Message-ID: <1369221908.859909.1473951865913.JavaMail.zimbra@redhat.com> References: <87a8fmq355.fsf@turtle.gmx.de> <688782233.2035106.1473128731891.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 547ED6E1A6 for ; Thu, 15 Sep 2016 15:04:32 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Alex Deucher , lkml , Sven Joachim , Maling list - DRI developers , Christian =?utf-8?Q?K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org PiBPbiBNb24sIFNlcCA1LCAyMDE2IGF0IDEwOjI1IFBNLCBKZXJvbWUgR2xpc3NlIDxqZ2xpc3Nl QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4+IFJlY2VudGx5IEkgZ290IG15c2VsZiBhIG5ldyBsYXB0 b3Agd2l0aCB0aGUgZm9sbG93aW5nIGludGVncmF0ZWQgR1BVOgo+ID4+Cj4gPj4gMDA6MDEuMCBW R0EgY29tcGF0aWJsZSBjb250cm9sbGVyOiBBZHZhbmNlZCBNaWNybyBEZXZpY2VzLCBJbmMuIFtB TUQvQVRJXQo+ID4+IE11bGxpbnMgW1JhZGVvbiBSMyBHcmFwaGljc10gKHJldiA0MCkKPiA+Pgo+ ID4+IEkgZm91bmQgdGhhdCBoaWJlcm5hdGlvbiBpcyBicm9rZW4gaW4gTGludXggNC43KyAoaXQg d29ya3MgaW4gTGludXggNC42KQo+ID4+IGFuZCBiaXNlY3RlZCBpdCB0byBjb21taXQgMjc0YWQ2 NWM5ZDAyICgiZHJtL3JhZGVvbjogaGFyZCByZXNldCByNjAwIGFuZAo+ID4+IG5ld2VyIEdQVSB3 aGVuIGhpYmVybmF0aW5nLiIpLgo+ID4+Cj4gPj4gVGhpcyBoYXMgYWxyZWFkeSBiZWVuIHJlcG9y dGVkIHRocmVlIG1vbnRocyBhZ28sIGJ1dCBmb3IgYSBtdWNoIG9sZGVyCj4gPj4gR1BVLCBzZWUg dGhlIHRocmVhZCBzdGFydGluZyBhdAo+ID4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE2LUp1bmUvMTEwMDUwLmh0bWwuCj4gPj4gVGhlIHN5bXB0 b21zIGFyZSBleGFjdGx5IHRoZSBzYW1lIGFzIGRlc2NyaWJlZCBieSBCb3JpcyBQZXRrb3YgaW4g dGhhdAo+ID4+IHRocmVhZDogYWZ0ZXIgInN5c3RlbWN0bCBoaWJlcm5hdGUiIHRoZSBzY3JlZW4g Z29lcyBibGFuaywgYnV0IHRoZQo+ID4+IG1hY2hpbmUgcmVtYWlucyBwb3dlcmVkIG9uIGFuZCBu ZWVkcyB0byBiZSBwb3dlci1jeWNsZWQuCj4gPj4KPiA+PiBBbnkgc3VnZ2VzdGlvbnMgd291bGQg YmUgd2VsY29tZS4KPiA+Pgo+ID4+IENoZWVycywKPiA+PiAgICAgICAgU3Zlbgo+ID4KPiA+IEkg Z3Vlc3Mgd2UgY2FuIGludmVydCB0aGUgbG9naWMgYW5kIG9ubHkgZG8gaXQgZm9yIHRoZSBHUFUg Zm9yIHdoaWNoIGl0IGZpeAo+ID4gaGliZXJuYXRpb24uCj4gCj4gRG8geW91IHJlbWVtYmVyIHdo aWNoIGFzaWNzIHRoaXMgZml4ZWQ/Cj4gCgpObyB0aGF0J3MgdGhlIGlzc3VlLCBpIGRvbid0IGhh dmUgaHcgYW55bW9yZSBidXQgYWNjb3JkaW5nIHRvIGJ1ZyBpdCBpcyBBTUQgRmlyZVBybwpNNTE3 MCBhbmQgTTYxNzAgd2hpY2ggd291bGQgbWFrZSB0aGVtIGFtZGdwdSBhZmFpY3QgYnV0IGkgcmVt ZW1iZXIgdGhlIGh3IHdhcyB1c2luZwpyYWRlb24gc28gaSBhbSBub3Qgc3VyZSBob3cgdG8gZmln dXJlIG91dCB3aGF0IEdQVSBpdCB3YXMgcmVhbGx5LgoKQnVnIGh0dHBzOi8vYnVnemlsbGEucmVk aGF0LmNvbS9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTAwOQoKQ2hlZXJzLApKw6lyw7RtZQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbcIOPFA convert rfc822-to-8bit (ORCPT ); Thu, 15 Sep 2016 11:05:00 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:37623 "EHLO mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753714AbcIOPEd (ORCPT ); Thu, 15 Sep 2016 11:04:33 -0400 Date: Thu, 15 Sep 2016 11:04:25 -0400 (EDT) From: Jerome Glisse To: Alex Deucher Cc: Sven Joachim , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Maling list - DRI developers , lkml Message-ID: <1369221908.859909.1473951865913.JavaMail.zimbra@redhat.com> In-Reply-To: References: <87a8fmq355.fsf@turtle.gmx.de> <688782233.2035106.1473128731891.JavaMail.zimbra@redhat.com> Subject: Re: Hibernation broken since commit 274ad65c9d02 ("drm/radeon: hard reset r600 and newer GPU when hibernating.") MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.19.40.126] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF34 (Linux)/8.0.6_GA_5922) Thread-Topic: Hibernation broken since commit 274ad65c9d02 ("drm/radeon: hard reset r600 and newer GPU when hibernating.") Thread-Index: aoM294yptGUpivxU/AXNJlxMOeC3pQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Sep 5, 2016 at 10:25 PM, Jerome Glisse wrote: > >> Recently I got myself a new laptop with the following integrated GPU: > >> > >> 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] > >> Mullins [Radeon R3 Graphics] (rev 40) > >> > >> I found that hibernation is broken in Linux 4.7+ (it works in Linux 4.6) > >> and bisected it to commit 274ad65c9d02 ("drm/radeon: hard reset r600 and > >> newer GPU when hibernating."). > >> > >> This has already been reported three months ago, but for a much older > >> GPU, see the thread starting at > >> https://lists.freedesktop.org/archives/dri-devel/2016-June/110050.html. > >> The symptoms are exactly the same as described by Boris Petkov in that > >> thread: after "systemctl hibernate" the screen goes blank, but the > >> machine remains powered on and needs to be power-cycled. > >> > >> Any suggestions would be welcome. > >> > >> Cheers, > >> Sven > > > > I guess we can invert the logic and only do it for the GPU for which it fix > > hibernation. > > Do you remember which asics this fixed? > No that's the issue, i don't have hw anymore but according to bug it is AMD FirePro M5170 and M6170 which would make them amdgpu afaict but i remember the hw was using radeon so i am not sure how to figure out what GPU it was really. Bug https://bugzilla.redhat.com/show_bug.cgi?id=1269009 Cheers, Jérôme