All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: backports@vger.kernel.org
Subject: Re: [PATCH 1/9] lib/bpgit.py: make git describe --long optional
Date: Wed, 22 May 2013 14:02:02 +0200	[thread overview]
Message-ID: <1369224122.8207.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1369222478-30577-2-git-send-email-mcgrof@do-not-panic.com> (sfid-20130522_133455_410970_C278E6E9)

Why not do:
 
> -def describe(rev='HEAD', tree=None):
> -    process = subprocess.Popen(['git', 'describe', '--always', '--long', rev],
> +def describe(rev='HEAD', tree=None, get_long=False):
> +    cmd = ['git', 'describe', '--always']
> +
> +    if (get_long):
> +        cmd.append('--long')
> +
> +    cmd.append(rev)

def describe(rev='HEAD', tree=None, extra_args=[]):
    cmd = ['git', 'describe', '--always']
    cmd.extend(extra_args)
    if rev is not None:
        cmd.append(rev)
    process = ...

that way you can do

bpgit.describe(rev=None, extra_args=['--dirty'])

or

bpgit.describe(extra_args=['--long'])


and don't need two different patches.

johannes


  reply	other threads:[~2013-05-22 12:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 11:34 [PATCH 0/9] backports: add kernel uploading support Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 1/9] lib/bpgit.py: make git describe --long optional Luis R. Rodriguez
2013-05-22 12:02   ` Johannes Berg [this message]
2013-05-22 21:49     ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 2/9] lib/bpgit.py: add git describe --dirty support Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 3/9] lib/bpgit.py: add git status support Luis R. Rodriguez
2013-05-22 12:02   ` Johannes Berg
2013-05-23  0:28     ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 4/9] lib/bpgit.py: add git clean support Luis R. Rodriguez
2013-05-22 12:03   ` Johannes Berg
2013-05-23  0:28     ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 5/9] lib/bpgit.py: add git tree verification support Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 6/9] lib/bpgit.py: add support for git paranoia Luis R. Rodriguez
2013-05-22 12:05   ` Johannes Berg
2013-05-23  0:37     ` Luis R. Rodriguez
2013-05-23 15:25       ` Johannes Berg
2013-05-23 21:02         ` Luis R. Rodriguez
2013-05-28 20:02           ` Luis R. Rodriguez
2013-05-28 20:14             ` Luis R. Rodriguez
2013-05-28 20:23               ` Johannes Berg
2013-07-27 17:11                 ` Luis R. Rodriguez
2013-05-28 20:17             ` Johannes Berg
2013-05-22 11:34 ` [PATCH 7/9] lib/bpgpg.py: add simple gpg helpers for --armor --detach-sign Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 8/9] lib/bpkup.py: add or own kernel uploader helper lib Luis R. Rodriguez
2013-05-22 12:06   ` Johannes Berg
2013-05-23  0:43     ` Luis R. Rodriguez
2013-05-22 11:34 ` [PATCH 9/9] gentree.py: add kernel upload support Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369224122.8207.3.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=backports@vger.kernel.org \
    --cc=mcgrof@do-not-panic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.