From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx: fix clocks for cspi
Date: Thu, 23 May 2013 16:01:14 +0400 [thread overview]
Message-ID: <1369310474.965158503@f320.mail.ru> (raw)
In-Reply-To: <1369309085-31146-1-git-send-email-jonas@microbit.se>
> The CSPI controller has only one clock, but the driver spi-imx.c needs clock "per" to calculate bitrate divisor.
>
> Signed-off-by: Jonas Andersson <jonas@microbit.se>
> ---
> arch/arm/boot/dts/imx25.dtsi | 12 ++++++------
> arch/arm/boot/dts/imx27.dtsi | 6 +++---
> arch/arm/boot/dts/imx51.dtsi | 2 +-
> arch/arm/boot/dts/imx53.dtsi | 2 +-
> 4 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index d2550e0..7011539 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -141,8 +141,8 @@
> #size-cells = <0>;
> compatible = "fsl,imx25-cspi", "fsl,imx35-cspi";
> reg = <0x43fa4000 0x4000>;
> - clocks = <&clks 62>;
> - clock-names = "ipg";
> + clocks = <&clks 62>, <&clks 62>;
> + clock-names = "ipg", "per";
> interrupts = <14>;
> status = "disabled";
> };
Why you do not use "dummy" clock for "per" here?
This variant will request/enable one clock two times.
---
next prev parent reply other threads:[~2013-05-23 12:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 11:38 [PATCH] ARM: dts: imx: fix clocks for cspi Jonas Andersson
2013-05-23 11:57 ` Sascha Hauer
2013-05-23 12:01 ` Alexander Shiyan [this message]
2013-05-23 12:10 ` Re[2]: " Alexander Shiyan
2013-05-23 12:36 ` Sascha Hauer
2013-05-23 14:28 ` Re[2]: " Alexander Shiyan
2013-05-23 17:33 ` Sascha Hauer
2013-05-24 4:16 ` Re[2]: " Alexander Shiyan
2013-06-25 15:05 ` Michael Grzeschik
2013-05-24 5:42 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369310474.965158503@f320.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.