From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ob0-x234.google.com ([2607:f8b0:4003:c01::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhNfQ-00038B-2n for kexec@lists.infradead.org; Tue, 28 May 2013 17:26:36 +0000 Received: by mail-ob0-f180.google.com with SMTP id eh20so1396337obb.11 for ; Tue, 28 May 2013 10:26:14 -0700 (PDT) Date: Tue, 28 May 2013 12:26:06 -0500 From: Rob Landley Subject: Re: [PATCH v2 2/7] Documentation/devices.txt: Mark /dev/oldmem obsolete References: <1369721851.2776.37@driftwood> <51A44DD5.5050301@cn.fujitsu.com> In-Reply-To: <51A44DD5.5050301@cn.fujitsu.com> (from zhangyanfei@cn.fujitsu.com on Tue May 28 01:25:25 2013) Message-Id: <1369761966.2776.39@driftwood> MIME-Version: 1.0 Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="Flowed"; DelSp="Yes" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Zhang Yanfei Cc: "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , HATAYAMA Daisuke , Simon Horman , "Eric W. Biederman" , "H. Peter Anvin" , Andrew Morton , Vivek Goyal , Zhang Yanfei T24gMDUvMjgvMjAxMyAwMToyNToyNSBBTSwgWmhhbmcgWWFuZmVpIHdyb3RlOgo+IE9uIDA1LzI4 LzIwMTMgMDI6MTcgUE0sIFJvYiBMYW5kbGV5IHdyb3RlOgo+ID4gT24gMDUvMjYvMjAxMyAwODo1 NDoxOSBQTSwgWmhhbmcgWWFuZmVpIHdyb3RlOgo+ID4+IOS6jiAyMDEz5bm0MDXmnIgyN+aXpSAw OTo0NiwgSEFUQVlBTUEgRGFpc3VrZSDlhpnpgZM6Cj4gPj4gPiAoMjAxMy8wNS8yNiAxNTozNiks IFpoYW5nIFlhbmZlaSB3cm90ZToKPiA+PiA+PiBGcm9tOiBaaGFuZyBZYW5mZWkgPHpoYW5neWFu ZmVpQGNuLmZ1aml0c3UuY29tPgo+ID4+ID4+Cj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogWmhhbmcg WWFuZmVpIDx6aGFuZ3lhbmZlaUBjbi5mdWppdHN1LmNvbT4KPiA+PiA+PiBDYzogRGF2ZSBKb25l cyA8ZGF2ZWpAcmVkaGF0LmNvbT4KPiA+PiA+PiAtLS0KPiA+PiA+PiAgIERvY3VtZW50YXRpb24v ZGV2aWNlcy50eHQgfCAgICAzICstLQo+ID4+ID4+ICAgMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPj4gPj4KPiA+PiA+PiBkaWZmIC0tZ2l0IGEvRG9j dW1lbnRhdGlvbi9kZXZpY2VzLnR4dCAgCj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXMudHh0Cj4g Pj4gPj4gaW5kZXggMDhmMDFlNy4uYzhlNDAwMiAxMDA2NDQKPiA+PiA+PiAtLS0gYS9Eb2N1bWVu dGF0aW9uL2RldmljZXMudHh0Cj4gPj4gPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2VzLnR4 dAo+ID4+ID4+IEBAIC0xMDAsOCArMTAwLDcgQEAgWW91ciBjb29wZXJhdGlvbiBpcyBhcHByZWNp YXRlZC4KPiA+PiA+PiAgICAgICAgICAgIDEwID0gL2Rldi9haW8gICAgICAgIEFzeW5jaHJvbm91 cyBJL08gbm90aWZpY2F0aW9uICAKPiBpbnRlcmZhY2UKPiA+PiA+PiAgICAgICAgICAgIDExID0g L2Rldi9rbXNnICAgICAgICBXcml0ZXMgdG8gdGhpcyBjb21lIG91dCBhcyAgCj4gcHJpbnRrJ3Ms IHJlYWRzCj4gPj4gPj4gICAgICAgICAgICAgICAgICAgICAgIGV4cG9ydCB0aGUgYnVmZmVyZWQg cHJpbnRrIHJlY29yZHMuCj4gPj4gPj4gLSAgICAgICAgIDEyID0gL2Rldi9vbGRtZW0gICAgVXNl ZCBieSBjcmFzaGR1bXAga2VybmVscyB0byAgCj4gYWNjZXNzCj4gPj4gPj4gLSAgICAgICAgICAg ICAgICAgICAgdGhlIG1lbW9yeSBvZiB0aGUga2VybmVsIHRoYXQgY3Jhc2hlZC4KPiA+PiA+PiAr ICAgICAgICAgMTIgPSAvZGV2L29sZG1lbSAgICBPQlNPTEVURQo+ID4+ID4+Cj4gPj4gPj4gICAg IDEgYmxvY2sgICAgUkFNIGRpc2sKPiA+PiA+PiAgICAgICAgICAgICAwID0gL2Rldi9yYW0wICAg ICAgICBGaXJzdCBSQU0gZGlzawo+ID4+ID4+Cj4gPj4gPgo+ID4+ID4gVGhpcyBpcyB0aGUgbmV3 IHBhdGNoLiBMb29raW5nIGF0IG90aGVyIHBhcnRzIG9mIGRldmljZXMudHh0LCAgCj4gb2Jzb2xl dGUgaXMKPiA+PiA+IHNvbWV0aW1lcyB1c2VkIHRvZ2V0aGVyIHdpdGggdW51c2VkLiBJIGd1ZXNz IG9ic29sZXRlIG1lYW5zIHRoaXMgIAo+IGlzIG9sZCBpbnRlcmZhY2Ugc28KPiA+PiA+IGRvbid0 IHVzZSBpdCBhcyBtdWNoIGFzIHBvc3NpYmxlIGFuZCB1bnVzZWQgbWVhbnMgdGhpcyBpcyBub3Qg IAo+IHVzZWQgYXQgYWxsIG5vdy4KPiA+PiA+IFlvdSByZW1vdmUgb2xkIG1lbW9yeSBpbnRlcmZh Y2UgY29tcGxldGVseSBpbiB0aGlzIHBhdGNoIHNldCwgc28gIAo+IGlzIGl0IGJldHRlciB0byBh ZGQKPiA+PiA+IHVudXNlZCwgdG9vPwo+ID4+ID4KPiA+Pgo+ID4+IERvZXMgb2Jzb2xldGUgYWxz byBtZWFuICJub3QgdXNlZCBhbnltb3JlIj8gSSBkb24ndCBrbm93LiBJIHRoaW5rICAKPiB3ZSBj YW4gd2FpdCBmb3Igc29tZSBuYXRpdmUKPiA+PiBFbmdsaXNoIHNwZWFrZXJzIHRvIGNvbW1lbnQg b24gdGhpcy4KPiA+Cj4gPiBPYnNvbGV0ZSBpbXBsaWVzIHRoYXQgaXQgc2hvdWxkbid0IGJlIHVz ZWQgYW55bW9yZS4gVGhlcmUgYXJlICAKPiBleGNlcHRpb25zIHRvIGV2ZXJ5dGhpbmcsIG9mIGNv dXJzZS4uLgo+ID4KPiA+IChVbnVzZWQgbWVhbnMgbm90aGluZyBpcyB1c2luZyBpdC4gSWYgdGhl cmUncyBzdGlsbCBjb2RlIHVzaW5nIGl0LCAgCj4gaXQncyBub3QgdW51c2VkLiBTbyB5ZWFoIHVu dXNlZCB3b3VsZCBpbXBseSByZW1vdmVkLikKPiA+Cj4gCj4gU28sIGNvdWxkIEkganVzdCB1c2Ug VU5TRUQgdG8gcmVwbGFjZSBPQlNPTEVURSBoZXJlPyBPciB1c2UgIAo+ICJPQlNPTEVURS9VTlVT RUQiPwoKT2Jzb2xldGUgaXMgZmluZS4KCk9ic29sZXRlIG1lYW5zIGl0IHdhcyB1c2VkIGF0IHNv bWUgcG9pbnQsIGFuZCB0aHVzIHJldXNpbmcgaXQgbWlnaHQgIApjb25mdXNlIG9yIGNvbmZsY2l0 IHdpdGggbGVnYWN5IHNvZnR3YXJlLiBVbnVzZWQgY291bGQganVzdCBtZWFuIHRoYXQgIAp3ZSBs ZWZ0IGEgZ2FwIGZvciBzb21lIHJlYXNvbiwgaXQgZG9lc24ndCBpbXBseSBpdCBldmVyIHdhcyB1 c2VkLgoKRXhwbGljaXRseSBkb2N1bWVudGluZyAidW51c2VkIiBpcyBraW5kIG9mIHNpbGx5OiBh bGwgdGhlIG9uZXMgd2UgIApfZG9uJ3RfIGRvY3VtZW50IGFyZSBwcmVzdW1hYmx5IHVudXNlZC4g T2Jzb2xldGUgY2FycmllcyB3aXRoIGl0IGEgdmVyeSAgCm1pbGQgd2FybmluZyBhYm91dCBsZWdh Y3kgc29mdHdhcmUsIHdoaWNoIGlzIHByZXN1bWFibHkgd2h5IHdlIHN0aWxsICAKYm90aGVyIHRv IG1lbnRpb24gaXQgYXQgYWxsIGluc3RlYWQgb2YganVzdCByZW1vdmluZyB0aGUgZW50cnkuCgoo VGhlbiBhZ2FpbiB0aGUgcG9pbnQgd2FzIHRoYXQgbm90aGluZyBldmVyIHVzZWQgdGhpcyBpbnRl cmZhY2UgaW4gdGhlICAKZmlyc3QgcGxhY2UuIFBlcnNvbmFsbHkgSSdkIGp1c3QgaGF2ZSByZW1v dmVkIHRoZSBlbnRyeS4uLikKClJvYgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964800Ab3E1R0Q (ORCPT ); Tue, 28 May 2013 13:26:16 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:43885 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934735Ab3E1R0O convert rfc822-to-8bit (ORCPT ); Tue, 28 May 2013 13:26:14 -0400 Date: Tue, 28 May 2013 12:26:06 -0500 From: Rob Landley Subject: Re: [PATCH v2 2/7] Documentation/devices.txt: Mark /dev/oldmem obsolete To: Zhang Yanfei Cc: "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , HATAYAMA Daisuke , Simon Horman , "Eric W. Biederman" , "H. Peter Anvin" , Andrew Morton , Vivek Goyal , Zhang Yanfei References: <1369721851.2776.37@driftwood> <51A44DD5.5050301@cn.fujitsu.com> In-Reply-To: <51A44DD5.5050301@cn.fujitsu.com> (from zhangyanfei@cn.fujitsu.com on Tue May 28 01:25:25 2013) X-Mailer: Balsa 2.4.11 Message-Id: <1369761966.2776.39@driftwood> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp=Yes; Format=Flowed Content-Disposition: inline Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/28/2013 01:25:25 AM, Zhang Yanfei wrote: > On 05/28/2013 02:17 PM, Rob Landley wrote: > > On 05/26/2013 08:54:19 PM, Zhang Yanfei wrote: > >> 于 2013年05月27日 09:46, HATAYAMA Daisuke 写道: > >> > (2013/05/26 15:36), Zhang Yanfei wrote: > >> >> From: Zhang Yanfei > >> >> > >> >> Signed-off-by: Zhang Yanfei > >> >> Cc: Dave Jones > >> >> --- > >> >> Documentation/devices.txt | 3 +-- > >> >> 1 files changed, 1 insertions(+), 2 deletions(-) > >> >> > >> >> diff --git a/Documentation/devices.txt > b/Documentation/devices.txt > >> >> index 08f01e7..c8e4002 100644 > >> >> --- a/Documentation/devices.txt > >> >> +++ b/Documentation/devices.txt > >> >> @@ -100,8 +100,7 @@ Your cooperation is appreciated. > >> >> 10 = /dev/aio Asynchronous I/O notification > interface > >> >> 11 = /dev/kmsg Writes to this come out as > printk's, reads > >> >> export the buffered printk records. > >> >> - 12 = /dev/oldmem Used by crashdump kernels to > access > >> >> - the memory of the kernel that crashed. > >> >> + 12 = /dev/oldmem OBSOLETE > >> >> > >> >> 1 block RAM disk > >> >> 0 = /dev/ram0 First RAM disk > >> >> > >> > > >> > This is the new patch. Looking at other parts of devices.txt, > obsolete is > >> > sometimes used together with unused. I guess obsolete means this > is old interface so > >> > don't use it as much as possible and unused means this is not > used at all now. > >> > You remove old memory interface completely in this patch set, so > is it better to add > >> > unused, too? > >> > > >> > >> Does obsolete also mean "not used anymore"? I don't know. I think > we can wait for some native > >> English speakers to comment on this. > > > > Obsolete implies that it shouldn't be used anymore. There are > exceptions to everything, of course... > > > > (Unused means nothing is using it. If there's still code using it, > it's not unused. So yeah unused would imply removed.) > > > > So, could I just use UNSED to replace OBSOLETE here? Or use > "OBSOLETE/UNUSED"? Obsolete is fine. Obsolete means it was used at some point, and thus reusing it might confuse or conflcit with legacy software. Unused could just mean that we left a gap for some reason, it doesn't imply it ever was used. Explicitly documenting "unused" is kind of silly: all the ones we _don't_ document are presumably unused. Obsolete carries with it a very mild warning about legacy software, which is presumably why we still bother to mention it at all instead of just removing the entry. (Then again the point was that nothing ever used this interface in the first place. Personally I'd just have removed the entry...) Rob