All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: <xen-devel@lists.xen.org>
Cc: David Vrabel <david.vrabel@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	John Stultz <john.stultz@linaro.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] x86/xen: sync the CMOS RTC as well as the Xen wallclock
Date: Tue, 28 May 2013 19:22:47 +0100	[thread overview]
Message-ID: <1369765368-10823-2-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1369765368-10823-1-git-send-email-david.vrabel@citrix.com>

From: David Vrabel <david.vrabel@citrix.com>

Adjustments to Xen's persistent_clock via update_persistent_clock()
don't actually persist, as the xen_set_walltime() just notifies other
domN guests that it has been updated, and does not modify the
underlying CMOS clock.

Thus, this patch modifies xen_set_wallclock() so it will set the
underlying CMOS clock when called from dom0, ensuring the
persistent_clock will be correct on the next hardware boot.

Dom0 does not support accessing EFI runtime services and Xen does not
run on Moorsetown platforms so the CMOS RTC is the only supported
hardware clock.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 arch/x86/xen/time.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index a1947ac..4656165 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -14,6 +14,7 @@
 #include <linux/kernel_stat.h>
 #include <linux/math64.h>
 #include <linux/gfp.h>
+#include <linux/mc146818rtc.h>
 
 #include <asm/pvclock.h>
 #include <asm/xen/hypervisor.h>
@@ -199,17 +200,25 @@ static void xen_get_wallclock(struct timespec *now)
 static int xen_set_wallclock(const struct timespec *now)
 {
 	struct xen_platform_op op;
+	int ret;
 
 	/* do nothing for domU */
 	if (!xen_initial_domain())
 		return -1;
 
+	/* Set the Xen wallclock. */
 	op.cmd = XENPF_settime;
 	op.u.settime.secs = now->tv_sec;
 	op.u.settime.nsecs = now->tv_nsec;
 	op.u.settime.system_time = xen_clocksource_read();
 
-	return HYPERVISOR_dom0_op(&op);
+	ret = HYPERVISOR_dom0_op(&op);
+	if (ret)
+		return ret;
+
+	/* Set the hardware RTC. */
+	return mach_set_rtc_mmss(now);
+
 }
 
 static struct clocksource xen_clocksource __read_mostly = {
-- 
1.7.2.5


  reply	other threads:[~2013-05-28 18:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 18:22 [PATCHv2 0/2] xen: maintain an accurate persistent clock in more cases David Vrabel
2013-05-28 18:22 ` David Vrabel [this message]
2013-05-28 19:01   ` [PATCH 1/2] x86/xen: sync the CMOS RTC as well as the Xen wallclock John Stultz
2013-05-28 19:05     ` Konrad Rzeszutek Wilk
2013-05-28 18:22 ` [PATCH 2/2] x86/xen: sync the wallclock when the system time changes David Vrabel
2013-05-28 18:53   ` John Stultz
2013-05-29  7:42     ` [Xen-devel] " Jan Beulich
2013-05-29  9:42     ` David Vrabel
2013-06-04  1:22       ` Marcelo Tosatti
2013-05-29  7:39   ` [Xen-devel] " Jan Beulich
2013-05-29  9:48     ` David Vrabel
2013-05-29  7:47   ` Jan Beulich
2013-05-29  9:37     ` David Vrabel
2013-05-29 19:58       ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369765368-10823-2-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=john.stultz@linaro.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.