From: Artem Bityutskiy <dedekind1@gmail.com>
To: Christian Riesch <christian.riesch@omicron.at>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 1/4] mtd: cfi_cmdset_0002: Add support for reading OTP
Date: Wed, 29 May 2013 10:11:22 +0300 [thread overview]
Message-ID: <1369811482.5446.216.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <38c84e40-1171-4040-bc8b-ec51a0485819@mary.at.omicron.at>
On Fri, 2013-04-26 at 21:10 +0200, Christian Riesch wrote:
> +static int cfi_amdstd_get_fact_prot_info(struct mtd_info *mtd,
> + struct otp_info *buf,
> size_t len)
> +{
> + size_t retlen;
> + int ret;
> +
> + ret = cfi_amdstd_otp_walk(mtd, 0, len, &retlen, (u_char *)buf,
> NULL, 0);
> + return ret ? : retlen;
> +}
Hmm, I thought we would return 0 in case of success and a negative error
code in case of error. Returning retlen looks wrong.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-05-29 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1367003430-24584-1-git-send-email-christian.riesch@omicron.at>
2013-04-26 19:10 ` [PATCH v2 1/4] mtd: cfi_cmdset_0002: Add support for reading OTP Christian Riesch
2013-05-29 7:11 ` Artem Bityutskiy [this message]
2013-05-29 12:54 ` Christian Riesch
2013-05-29 13:53 ` Artem Bityutskiy
2013-05-29 14:36 ` Christian Riesch
2013-06-03 9:40 ` Artem Bityutskiy
2013-06-04 11:30 ` Christian Riesch
2013-04-26 19:10 ` [PATCH v2 2/4] mtd: cfi_cmdset_0002: Invalidate cache after entering/exiting OTP memory Christian Riesch
2013-04-26 19:10 ` [PATCH v2 3/4] mtd: cfi_cmdset_0002: Add support for writing " Christian Riesch
2013-04-26 19:10 ` [PATCH v2 4/4] mtd: cfi_cmdset_0002: Add support for locking " Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369811482.5446.216.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=christian.riesch@omicron.at \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.