From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/3] lx6464es: use %*phN to print small buffer in hex form
Date: Wed, 29 May 2013 14:29:24 +0300 [thread overview]
Message-ID: <1369826964.29283.235.camel@smile> (raw)
In-Reply-To: <s5hd2sa6qgu.wl%tiwai@suse.de>
On Wed, 2013-05-29 at 12:16 +0200, Takashi Iwai wrote:
> > strcpy(card->driver, "LX6464ES");
> > - sprintf(card->id, "LX6464ES_%02X%02X%02X",
> > - chip->mac_address[3], chip->mac_address[4], chip->mac_address[5]);
> > + sprintf(card->id, "LX6464ES_%3phN", chip->mac_address + 3);
>
> The same problem as my previous comment. The case incompatible.
Here is card->id, which might be used by userspace in defined form.
I rather agree with your objection here.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-05-29 11:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 10:03 [PATCH 1/3] lx6464es: remove useles pci_set_drvdata(pdev, NULL) Andy Shevchenko
2013-05-29 10:03 ` [PATCH 2/3] lx6464es: dump MAC in standard form Andy Shevchenko
2013-05-29 10:15 ` Takashi Iwai
2013-05-29 11:00 ` Andy Shevchenko
2013-05-29 11:03 ` Takashi Iwai
2013-05-29 11:31 ` Andy Shevchenko
2013-05-29 12:15 ` Takashi Iwai
2013-05-29 10:03 ` [PATCH 3/3] lx6464es: use %*phN to print small buffer in hex form Andy Shevchenko
2013-05-29 10:16 ` Takashi Iwai
2013-05-29 11:29 ` Andy Shevchenko [this message]
2013-05-29 10:17 ` [PATCH 1/3] lx6464es: remove useles pci_set_drvdata(pdev, NULL) Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369826964.29283.235.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.