diff for duplicates of <1369869272.18630.47@snotra> diff --git a/a/1.txt b/N1/1.txt index 0c3b0ee..da7b186 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,22 +4,22 @@ On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote: > >> On 05/29/2013 09:35 AM, Scott Wood wrote: > >> > On 05/28/2013 06:30:40 PM, Alexey Kardashevskiy wrote: > >> >> >> >>> @@ -939,6 +940,9 @@ struct kvm_s390_ucas_mapping { -> >> >> >> >>> #define KVM_GET_DEVICE_ATTR _IOW(KVMIO, 0xe2, +> >> >> >> >>> #define KVM_GET_DEVICE_ATTR _IOW(KVMIO, 0xe2, =20 > struct > >> >> >> >>> kvm_device_attr) -> >> >> >> >>> #define KVM_HAS_DEVICE_ATTR _IOW(KVMIO, 0xe3, +> >> >> >> >>> #define KVM_HAS_DEVICE_ATTR _IOW(KVMIO, 0xe3, =20 > struct > >> >> >> >>> kvm_device_attr) > >> >> >> >>> > >> >> >> >>> +/* ioctl for SPAPR TCE IOMMU */ -> >> >> >> >>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, +> >> >> >> >>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, =20 > struct > >> >> >> >>> kvm_create_spapr_tce_iommu) > >> >> >> >> > >> >> >> >> Shouldn't this go under the vm ioctl section? > >> >> >> > >> >> >> -> >> >> >> The KVM_CREATE_SPAPR_TCE_IOMMU ioctl (the version for +> >> >> >> The KVM_CREATE_SPAPR_TCE_IOMMU ioctl (the version for =20 > emulated > >> >> devices) is > >> >> >> in this section so I decided to keep them together. Wrong? @@ -35,21 +35,21 @@ On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote: > >> > >> Sorry, I meant this ioctl - KVM_CREATE_SPAPR_TCE. > > -> > But you didn't put it in the same section as KVM_CREATE_SPAPR_TCE. +> > But you didn't put it in the same section as KVM_CREATE_SPAPR_TCE. =20 > 0xe0 > > begins a different section. -> +>=20 > It is not really obvious that there are sections as no comment defines > those :) There is a comment /* ioctls for fds returned by KVM_CREATE_DEVICE */ -Putting KVM_CREATE_DEVICE in there was mainly to avoid dealing with the -ioctl number conflict mess in the vm-ioctl section, but at least that +Putting KVM_CREATE_DEVICE in there was mainly to avoid dealing with the =20 +ioctl number conflict mess in the vm-ioctl section, but at least that =20 one is related to the device control API. :-) > But yes, makes sense to move it up a bit and change the code to 0xad. 0xad is KVM_KVMCLOCK_CTRL --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 4d21528..19f7816 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,15 +6,15 @@ "ref\051A68AE9.6070709@ozlabs.ru\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling\0" - "Date\0Wed, 29 May 2013 23:14:32 +0000\0" + "Date\0Wed, 29 May 2013 18:14:32 -0500\0" "To\0Alexey Kardashevskiy <aik@ozlabs.ru>\0" - "Cc\0David Gibson <david@gibson.dropbear.id.au>" - kvm@vger.kernel.org - linux-kernel@vger.kernel.org - kvm-ppc@vger.kernel.org + "Cc\0kvm@vger.kernel.org" Alexander Graf <agraf@suse.de> + kvm-ppc@vger.kernel.org + linux-kernel@vger.kernel.org Paul Mackerras <paulus@samba.org> - " linuxppc-dev@lists.ozlabs.org\0" + linuxppc-dev@lists.ozlabs.org + " David Gibson <david@gibson.dropbear.id.au>\0" "\00:1\0" "b\0" "On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote:\n" @@ -23,22 +23,22 @@ "> >> On 05/29/2013 09:35 AM, Scott Wood wrote:\n" "> >> > On 05/28/2013 06:30:40 PM, Alexey Kardashevskiy wrote:\n" "> >> >> >> >>> @@ -939,6 +940,9 @@ struct kvm_s390_ucas_mapping {\n" - "> >> >> >> >>> #define KVM_GET_DEVICE_ATTR _IOW(KVMIO, 0xe2, \n" + "> >> >> >> >>> #define KVM_GET_DEVICE_ATTR _IOW(KVMIO, 0xe2, =20\n" "> struct\n" "> >> >> >> >>> kvm_device_attr)\n" - "> >> >> >> >>> #define KVM_HAS_DEVICE_ATTR _IOW(KVMIO, 0xe3, \n" + "> >> >> >> >>> #define KVM_HAS_DEVICE_ATTR _IOW(KVMIO, 0xe3, =20\n" "> struct\n" "> >> >> >> >>> kvm_device_attr)\n" "> >> >> >> >>>\n" "> >> >> >> >>> +/* ioctl for SPAPR TCE IOMMU */\n" - "> >> >> >> >>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, \n" + "> >> >> >> >>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, =20\n" "> struct\n" "> >> >> >> >>> kvm_create_spapr_tce_iommu)\n" "> >> >> >> >>\n" "> >> >> >> >> Shouldn't this go under the vm ioctl section?\n" "> >> >> >>\n" "> >> >> >>\n" - "> >> >> >> The KVM_CREATE_SPAPR_TCE_IOMMU ioctl (the version for \n" + "> >> >> >> The KVM_CREATE_SPAPR_TCE_IOMMU ioctl (the version for =20\n" "> emulated\n" "> >> >> devices) is\n" "> >> >> >> in this section so I decided to keep them together. Wrong?\n" @@ -54,23 +54,23 @@ "> >>\n" "> >> Sorry, I meant this ioctl - KVM_CREATE_SPAPR_TCE.\n" "> >\n" - "> > But you didn't put it in the same section as KVM_CREATE_SPAPR_TCE. \n" + "> > But you didn't put it in the same section as KVM_CREATE_SPAPR_TCE. =20\n" "> 0xe0\n" "> > begins a different section.\n" - "> \n" + ">=20\n" "> It is not really obvious that there are sections as no comment defines\n" "> those :)\n" "\n" "There is a comment /* ioctls for fds returned by KVM_CREATE_DEVICE */\n" "\n" - "Putting KVM_CREATE_DEVICE in there was mainly to avoid dealing with the \n" - "ioctl number conflict mess in the vm-ioctl section, but at least that \n" + "Putting KVM_CREATE_DEVICE in there was mainly to avoid dealing with the =20\n" + "ioctl number conflict mess in the vm-ioctl section, but at least that =20\n" "one is related to the device control API. :-)\n" "\n" "> But yes, makes sense to move it up a bit and change the code to 0xad.\n" "\n" "0xad is KVM_KVMCLOCK_CTRL\n" "\n" - -Scott + -Scott= -43bde683a82e150cb1312361513c6e8018aecbb2e364cdd1df08033cc81adebd +c3f8dfefd3684cb00e454262c9041f16dd569149a7c66091e62330f843095c98
diff --git a/a/content_digest b/N2/content_digest index 4d21528..1c3b570 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -6,15 +6,15 @@ "ref\051A68AE9.6070709@ozlabs.ru\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling\0" - "Date\0Wed, 29 May 2013 23:14:32 +0000\0" + "Date\0Wed, 29 May 2013 18:14:32 -0500\0" "To\0Alexey Kardashevskiy <aik@ozlabs.ru>\0" - "Cc\0David Gibson <david@gibson.dropbear.id.au>" - kvm@vger.kernel.org - linux-kernel@vger.kernel.org - kvm-ppc@vger.kernel.org + "Cc\0kvm@vger.kernel.org" Alexander Graf <agraf@suse.de> + kvm-ppc@vger.kernel.org + linux-kernel@vger.kernel.org Paul Mackerras <paulus@samba.org> - " linuxppc-dev@lists.ozlabs.org\0" + linuxppc-dev@lists.ozlabs.org + " David Gibson <david@gibson.dropbear.id.au>\0" "\00:1\0" "b\0" "On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote:\n" @@ -73,4 +73,4 @@ "\n" -Scott -43bde683a82e150cb1312361513c6e8018aecbb2e364cdd1df08033cc81adebd +61ede74b17ea17023850b89db8cfa37df910bbd45734ad4e50d4c27cdd85beda
diff --git a/a/content_digest b/N3/content_digest index 4d21528..c6453ed 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -6,15 +6,15 @@ "ref\051A68AE9.6070709@ozlabs.ru\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling\0" - "Date\0Wed, 29 May 2013 23:14:32 +0000\0" + "Date\0Wed, 29 May 2013 18:14:32 -0500\0" "To\0Alexey Kardashevskiy <aik@ozlabs.ru>\0" "Cc\0David Gibson <david@gibson.dropbear.id.au>" - kvm@vger.kernel.org - linux-kernel@vger.kernel.org - kvm-ppc@vger.kernel.org + <kvm@vger.kernel.org> + <linux-kernel@vger.kernel.org> + <kvm-ppc@vger.kernel.org> Alexander Graf <agraf@suse.de> Paul Mackerras <paulus@samba.org> - " linuxppc-dev@lists.ozlabs.org\0" + " <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote:\n" @@ -73,4 +73,4 @@ "\n" -Scott -43bde683a82e150cb1312361513c6e8018aecbb2e364cdd1df08033cc81adebd +d5d99bfec3550cc7ef3a0c3853f18f02b6c8ec1a8ce7116e2543942c2cd0190e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.