From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code Date: Thu, 30 May 2013 22:32:09 +0000 Message-ID: <1369953129.11620.15.camel@x230> References: <20130523115801.GJ14575@console-pimps.org> <20130523203234.GD20913@sgi.com> <20130524074331.GL14575@console-pimps.org> <20130529210115.GC28027@sgi.com> <20130529224645.GA16582@sgi.com> <1369880172.17397.11.camel@linux-s257.site> <20130530221737.GA11105@sgi.com> <1369952512.11620.14.camel@x230> <20130530222836.GB11105@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20130530222836.GB11105-sJ/iWh9BUns@public.gmane.org> Content-Language: en-US Content-ID: <19611AE13F041C49A746B8C0303F99BF-HX+pjaQZbrqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russ Anderson Cc: joeyli , Jiri Kosina , Matt Fleming , "matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov List-Id: linux-efi@vger.kernel.org T24gVGh1LCAyMDEzLTA1LTMwIGF0IDE3OjI4IC0wNTAwLCBSdXNzIEFuZGVyc29uIHdyb3RlOg0K PiBPbiBUaHUsIE1heSAzMCwgMjAxMyBhdCAxMDoyMTo1M1BNICswMDAwLCBNYXR0aGV3IEdhcnJl dHQgd3JvdGU6DQo+ID4gT24gVGh1LCAyMDEzLTA1LTMwIGF0IDE3OjE3IC0wNTAwLCBSdXNzIEFu ZGVyc29uIHdyb3RlOg0KPiA+IA0KPiA+ID4gVGhhdCdzIGEgZ3JlYXQgaWRlYS4gIFRoaXMgcGF0 Y2ggbW92ZXMgdGhlIFF1ZXJ5VmFyaWFibGVJbmZvKCkNCj4gPiA+IGNhbGwgZnJvbSBib290aW1l IHRvIHJ1bnRpbWUsIGluIGVmaV9sYXRlX2luaXQoKS4gIFRoZSBhdHRhY2hlZA0KPiA+ID4gcGF0 Y2ggaXMgY29uc2lzdGVudCB3aXRoIHRoZSBVRUZJIHNwZWMgYW5kIGF2b2lkcyB0aGUgcHJvYmxl bS4NCj4gPiANCj4gPiBObywgdGhhdCBkZWZlYXRzIHRoZSBlbnRpcmUgcG9pbnQgb2YgdGhlIG9y aWdpbmFsIHBhdGNoLg0KPiANCj4gSG93IHNvPyAgSXQgaXMgc3RpbGwgY2FsbGluZyBRdWVyeVZh cmlhYmxlSW5mbygpDQo+IGJlZm9yZSB0aGUgZGF0YSBpcyB1c2VkLg0KDQpXZSB3YW50IHRvIGtu b3cgaG93IG11Y2ggc3BhY2UgaXMgdXNlZCBieSB2YXJpYWJsZXMgdGhhdCBhcmVuJ3QgdmlzaWJs ZQ0KYXQgcnVudGltZS4NCg0KLS0gDQpNYXR0aGV3IEdhcnJldHQgfCBtamc1OUBzcmNmLnVjYW0u b3JnDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759827Ab3E3WcU (ORCPT ); Thu, 30 May 2013 18:32:20 -0400 Received: from mail-bn1lp0153.outbound.protection.outlook.com ([207.46.163.153]:48328 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751140Ab3E3WcN (ORCPT ); Thu, 30 May 2013 18:32:13 -0400 From: Matthew Garrett To: Russ Anderson CC: joeyli , Jiri Kosina , Matt Fleming , "matt.fleming@intel.com" , "linux-efi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "Thomas Gleixner" , "H. Peter Anvin" , Borislav Petkov Subject: Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code Thread-Topic: [regression, bisected] x86: efi: Pass boot services variable info to runtime code Thread-Index: AQHOXYWFcUqvqo+O5EOQ++qV+11m6g== Date: Thu, 30 May 2013 22:32:09 +0000 Message-ID: <1369953129.11620.15.camel@x230> References: <20130523115801.GJ14575@console-pimps.org> <20130523203234.GD20913@sgi.com> <20130524074331.GL14575@console-pimps.org> <20130529210115.GC28027@sgi.com> <20130529224645.GA16582@sgi.com> <1369880172.17397.11.camel@linux-s257.site> <20130530221737.GA11105@sgi.com> <1369952512.11620.14.camel@x230> <20130530222836.GB11105@sgi.com> In-Reply-To: <20130530222836.GB11105@sgi.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.4] x-forefront-antispam-report: SFV:SKI;SFS:;DIR:OUT;SFP:;SCL:-1;SRVR:BY2PR05MB222;H:BY2PR05MB222.namprd05.prod.outlook.com;LANG:en; Content-Type: text/plain; charset="utf-8" Content-ID: <19611AE13F041C49A746B8C0303F99BF@namprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r4UMWNnQ020993 On Thu, 2013-05-30 at 17:28 -0500, Russ Anderson wrote: > On Thu, May 30, 2013 at 10:21:53PM +0000, Matthew Garrett wrote: > > On Thu, 2013-05-30 at 17:17 -0500, Russ Anderson wrote: > > > > > That's a great idea. This patch moves the QueryVariableInfo() > > > call from bootime to runtime, in efi_late_init(). The attached > > > patch is consistent with the UEFI spec and avoids the problem. > > > > No, that defeats the entire point of the original patch. > > How so? It is still calling QueryVariableInfo() > before the data is used. We want to know how much space is used by variables that aren't visible at runtime. -- Matthew Garrett | mjg59@srcf.ucam.org {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I