From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD4E606A33B for ; Wed, 4 Nov 2026 11:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=2HPcvgDB Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F243410E8A0; Wed, 4 Nov 2026 11:12:09 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67BBE10FB5E for ; Wed, 4 Nov 2026 11:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=Sq72/jE1QWYRdcK1hoiu7bRYxYUswJNBNRjBOWyiKL8=; b=2HPcvgDB89z9MCCbZPrKTjDdSe a2iOhzncH45XWbpf9h5Z8prpD2YftEz7/e5hwuvWn+QuCeuR+A985T/5nMETf+5nDv4C/OGiEYWiN yHNn/W7mCluK0Avj86ssbgeDhbC5MybjVA9WWWhZe6nnpnYsMAqhE8dncxIx4P5Sw9H0FPt3JwUjA V2dW8uAPnS6oH6s/atFbE1YQM3BrqEBVTBRoCa6Px+Gf2R9yjpHPLpIRsFY0/nmSSP+QIih6+Ebkj gVyTKzfad0lXgE4JzqsC3FtSmP5P7yTqCtINcMmCiSDl37j6H7J+F/DKy534XRIjzr18Rpw0TYvFZ 34n1vy7Q==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Tomeu Vizoso , Oded Gabbay , Igor Paunovic Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Hugo , Robert Foss , Sidong Yang , Diederik de Haas , Sebastian Reichel , Jiaxing Hu , Nicolas Dufresne , Jonas Karlman , Guangshuo Li , =?UTF-8?B?SMO8c2V5aW4=?= BIYIK , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Paunovic Subject: Re: [PATCH v2 05/11] accel/rocket: request the core clocks by name Date: Wed, 04 Nov 2026 12:11:52 +0100 Message-ID: <13701281.ZYm5mLc6kN@diego> In-Reply-To: <20260922080114.44662-6-royalnet026@gmail.com> References: <20260922080114.44662-1-royalnet026@gmail.com> <20260922080114.44662-6-royalnet026@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Am Dienstag, 22. September 2026, 10:01:08 Mitteleurop=C3=A4ische Normalzeit= schrieb Igor Paunovic: > rocket_core_init() hands core->clks to devm_clk_bulk_get() without ever > setting the .id members. The rocket_core array is allocated with > devm_kcalloc() in rocket_device_init(), and rocket_probe() only fills in > .rdev, .dev and .index, so all four clk_bulk_data entries are requested > with a NULL con_id (unlike core->resets, whose ids are set a few lines > above). >=20 > clk_get(dev, NULL) ends up in of_clk_get_hw(np, 0, NULL), and > of_parse_clkspec() only consults "clock-names" when a name was passed, > so the index stays 0 for all four entries. Every entry therefore ends up > holding a handle to the *first* clock of the DT "clocks" property, i.e. > ACLK_NPUn. Nothing fails: probe succeeds and the driver believes it owns > four different clocks. >=20 > The consequence is that rocket_device_runtime_resume() prepares and > enables the AXI clock four times, while hclk, pclk and - most > importantly - the NPU compute clock ("npu", SCMI_CLK_NPU on RK3588) are > never prepared or enabled by this driver at all. The NPU still works > only because the Rockchip power-domain driver sets GENPD_FLAG_PM_CLK and > its attach_dev() callback walks the device node with of_clk_get() and > adds every clock to the pm_clk list, so genpd happens to keep the > remaining clocks running. The bug is therefore latent today, but it > means the driver holds no reference to the clock that actually feeds the > NPU, which stands in the way of any future frequency scaling > (OPP/devfreq) work. >=20 > Found on an Orange Pi 5 Plus (RK3588) by reading the live clock tree: > /sys/kernel/debug/clk/clk_summary shows four "fdab0000.npu" consumer > handles on aclk_npu0 (and likewise on aclk_npu1/aclk_npu2 for the other > two cores), while hclk_npu0, pclk_npu_root and scmi_clk_npu have no > "fdab0000.npu" consumer at all - their only consumers are the > "npu@fdab0000" handles created by the power-domain driver via > of_clk_get(). >=20 > Set the ids explicitly, in the order mandated by the binding > (Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml): > aclk, hclk, npu, pclk. After the change the driver holds one handle per > distinct clock and clk_bulk_prepare_enable() covers all four. >=20 > Note that this is a user-visible tightening for out-of-tree DTs: the > old NULL-id requests resolved by index and succeeded no matter what > "clock-names" contained, while the named requests fail probe with > -ENOENT when one of the four names is missing. That is the right > outcome for in-tree users - the binding requires exactly these four > clock-names and rk3588-base.dtsi carries them on all three cores - but > a DT that relied on the permissive lookup goes from silently running on > the wrong clock handles to not probing at all, so record the change > here where git log will find it. >=20 > Fixes: ed98261b4168 ("accel/rocket: Add a new driver for Rockchip's NPU") > Assisted-by: LLM sparse checkpatch > Signed-off-by: Igor Paunovic > Tested-by: Sidong Yang > Tested-by: Diederik de Haas # NanoPC-T6 LTS, N= anoPC-T6 Plus > Reviewed-by: Sebastian Reichel > Reviewed-by: Jiaxing Hu > --- > Same diff and the same message text (his copy re-wraps the lines) as > 01/14 of Jiaxing Hu's RK3576 series, which carries this patch as well; > whichever lands first, the other drops it. The trailers differ: Jiaxing > asked me to drop his Signed-off-by from my own posting of it, as he did > not pass this copy along, and Assisted-by is added because an LLM helped > with the checks on this v2. >=20 > drivers/accel/rocket/rocket_core.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/accel/rocket/rocket_core.c b/drivers/accel/rocket/ro= cket_core.c > index b3b2fa9ba645a..5dd260bacbff6 100644 > --- a/drivers/accel/rocket/rocket_core.c > +++ b/drivers/accel/rocket/rocket_core.c > @@ -28,6 +28,10 @@ int rocket_core_init(struct rocket_core *core) > if (err) > return dev_err_probe(dev, err, "failed to get resets for core %d\n", c= ore->index); > =20 > + core->clks[0].id =3D "aclk"; > + core->clks[1].id =3D "hclk"; > + core->clks[2].id =3D "npu"; > + core->clks[3].id =3D "pclk"; additionally, while reading the followup patches, please introduce some constants for the indices. ROCKET_CLK_ACLK, ... or some other name. Because when you access them later by index, that makes things harder to read and follow (especially in the future) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CEE606A331 for ; Wed, 4 Nov 2026 11:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=D+Yb/d/T; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=2HPcvgDB DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=M4exRwHTHmXK83kc/4IbADckkeO0q8TN4BUGJMMkI+0=; b=D+Yb/d/To9w9pWM4I6bvitzn1P sWz/s05nF5F9LerKCOmOVB5vf0x0WONwucKO+9m06hp/ScGdZQz0TXZrcQgqnoD5HJr+fAnLo2P/r aweLxfgABDx6mb9GDkuV7BPK4hexmr/wpr6rVgrvt3s4+IThG49628H20NabeRvBX+i/IH3t/liYe IU+B8fPDP1+J+VVdprXMbJhuGu48qsyDcNtjIF24eRaT9sq3rP1V1MM+UC4GGk8VQ9Z+3EX3t+A0z Fk54V2iI9NOBuaJI7FpR0IfYcQtGh5YOsMWU48zJ9FJDJzk6BsldcfC/4AyQT6BvAy9vv4DRcfc1l tRtodPhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOYuZ-000000057LR-3FvN; Wed, 04 Nov 2026 11:12:11 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOYuY-000000057L0-0W4f; Wed, 04 Nov 2026 11:12:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=Sq72/jE1QWYRdcK1hoiu7bRYxYUswJNBNRjBOWyiKL8=; b=2HPcvgDB89z9MCCbZPrKTjDdSe a2iOhzncH45XWbpf9h5Z8prpD2YftEz7/e5hwuvWn+QuCeuR+A985T/5nMETf+5nDv4C/OGiEYWiN yHNn/W7mCluK0Avj86ssbgeDhbC5MybjVA9WWWhZe6nnpnYsMAqhE8dncxIx4P5Sw9H0FPt3JwUjA V2dW8uAPnS6oH6s/atFbE1YQM3BrqEBVTBRoCa6Px+Gf2R9yjpHPLpIRsFY0/nmSSP+QIih6+Ebkj gVyTKzfad0lXgE4JzqsC3FtSmP5P7yTqCtINcMmCiSDl37j6H7J+F/DKy534XRIjzr18Rpw0TYvFZ 34n1vy7Q==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Tomeu Vizoso , Oded Gabbay , Igor Paunovic Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Hugo , Robert Foss , Sidong Yang , Diederik de Haas , Sebastian Reichel , Jiaxing Hu , Nicolas Dufresne , Jonas Karlman , Guangshuo Li , =?UTF-8?B?SMO8c2V5aW4=?= BIYIK , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Paunovic Subject: Re: [PATCH v2 05/11] accel/rocket: request the core clocks by name Date: Wed, 04 Nov 2026 12:11:52 +0100 Message-ID: <13701281.ZYm5mLc6kN@diego> In-Reply-To: <20260922080114.44662-6-royalnet026@gmail.com> References: <20260922080114.44662-1-royalnet026@gmail.com> <20260922080114.44662-6-royalnet026@gmail.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_031210_188327_0BC0F3D4 X-CRM114-Status: GOOD ( 30.56 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gRGllbnN0YWcsIDIyLiBTZXB0ZW1iZXIgMjAyNiwgMTA6MDE6MDggTWl0dGVsZXVyb3DDpGlz Y2hlIE5vcm1hbHplaXQgc2NocmllYiBJZ29yIFBhdW5vdmljOgo+IHJvY2tldF9jb3JlX2luaXQo KSBoYW5kcyBjb3JlLT5jbGtzIHRvIGRldm1fY2xrX2J1bGtfZ2V0KCkgd2l0aG91dCBldmVyCj4g c2V0dGluZyB0aGUgLmlkIG1lbWJlcnMuIFRoZSByb2NrZXRfY29yZSBhcnJheSBpcyBhbGxvY2F0 ZWQgd2l0aAo+IGRldm1fa2NhbGxvYygpIGluIHJvY2tldF9kZXZpY2VfaW5pdCgpLCBhbmQgcm9j a2V0X3Byb2JlKCkgb25seSBmaWxscyBpbgo+IC5yZGV2LCAuZGV2IGFuZCAuaW5kZXgsIHNvIGFs bCBmb3VyIGNsa19idWxrX2RhdGEgZW50cmllcyBhcmUgcmVxdWVzdGVkCj4gd2l0aCBhIE5VTEwg Y29uX2lkICh1bmxpa2UgY29yZS0+cmVzZXRzLCB3aG9zZSBpZHMgYXJlIHNldCBhIGZldyBsaW5l cwo+IGFib3ZlKS4KPiAKPiBjbGtfZ2V0KGRldiwgTlVMTCkgZW5kcyB1cCBpbiBvZl9jbGtfZ2V0 X2h3KG5wLCAwLCBOVUxMKSwgYW5kCj4gb2ZfcGFyc2VfY2xrc3BlYygpIG9ubHkgY29uc3VsdHMg ImNsb2NrLW5hbWVzIiB3aGVuIGEgbmFtZSB3YXMgcGFzc2VkLAo+IHNvIHRoZSBpbmRleCBzdGF5 cyAwIGZvciBhbGwgZm91ciBlbnRyaWVzLiBFdmVyeSBlbnRyeSB0aGVyZWZvcmUgZW5kcyB1cAo+ IGhvbGRpbmcgYSBoYW5kbGUgdG8gdGhlICpmaXJzdCogY2xvY2sgb2YgdGhlIERUICJjbG9ja3Mi IHByb3BlcnR5LCBpLmUuCj4gQUNMS19OUFVuLiBOb3RoaW5nIGZhaWxzOiBwcm9iZSBzdWNjZWVk cyBhbmQgdGhlIGRyaXZlciBiZWxpZXZlcyBpdCBvd25zCj4gZm91ciBkaWZmZXJlbnQgY2xvY2tz Lgo+IAo+IFRoZSBjb25zZXF1ZW5jZSBpcyB0aGF0IHJvY2tldF9kZXZpY2VfcnVudGltZV9yZXN1 bWUoKSBwcmVwYXJlcyBhbmQKPiBlbmFibGVzIHRoZSBBWEkgY2xvY2sgZm91ciB0aW1lcywgd2hp bGUgaGNsaywgcGNsayBhbmQgLSBtb3N0Cj4gaW1wb3J0YW50bHkgLSB0aGUgTlBVIGNvbXB1dGUg Y2xvY2sgKCJucHUiLCBTQ01JX0NMS19OUFUgb24gUkszNTg4KSBhcmUKPiBuZXZlciBwcmVwYXJl ZCBvciBlbmFibGVkIGJ5IHRoaXMgZHJpdmVyIGF0IGFsbC4gVGhlIE5QVSBzdGlsbCB3b3Jrcwo+ IG9ubHkgYmVjYXVzZSB0aGUgUm9ja2NoaXAgcG93ZXItZG9tYWluIGRyaXZlciBzZXRzIEdFTlBE X0ZMQUdfUE1fQ0xLIGFuZAo+IGl0cyBhdHRhY2hfZGV2KCkgY2FsbGJhY2sgd2Fsa3MgdGhlIGRl dmljZSBub2RlIHdpdGggb2ZfY2xrX2dldCgpIGFuZAo+IGFkZHMgZXZlcnkgY2xvY2sgdG8gdGhl IHBtX2NsayBsaXN0LCBzbyBnZW5wZCBoYXBwZW5zIHRvIGtlZXAgdGhlCj4gcmVtYWluaW5nIGNs b2NrcyBydW5uaW5nLiBUaGUgYnVnIGlzIHRoZXJlZm9yZSBsYXRlbnQgdG9kYXksIGJ1dCBpdAo+ IG1lYW5zIHRoZSBkcml2ZXIgaG9sZHMgbm8gcmVmZXJlbmNlIHRvIHRoZSBjbG9jayB0aGF0IGFj dHVhbGx5IGZlZWRzIHRoZQo+IE5QVSwgd2hpY2ggc3RhbmRzIGluIHRoZSB3YXkgb2YgYW55IGZ1 dHVyZSBmcmVxdWVuY3kgc2NhbGluZwo+IChPUFAvZGV2ZnJlcSkgd29yay4KPiAKPiBGb3VuZCBv biBhbiBPcmFuZ2UgUGkgNSBQbHVzIChSSzM1ODgpIGJ5IHJlYWRpbmcgdGhlIGxpdmUgY2xvY2sg dHJlZToKPiAvc3lzL2tlcm5lbC9kZWJ1Zy9jbGsvY2xrX3N1bW1hcnkgc2hvd3MgZm91ciAiZmRh YjAwMDAubnB1IiBjb25zdW1lcgo+IGhhbmRsZXMgb24gYWNsa19ucHUwIChhbmQgbGlrZXdpc2Ug b24gYWNsa19ucHUxL2FjbGtfbnB1MiBmb3IgdGhlIG90aGVyCj4gdHdvIGNvcmVzKSwgd2hpbGUg aGNsa19ucHUwLCBwY2xrX25wdV9yb290IGFuZCBzY21pX2Nsa19ucHUgaGF2ZSBubwo+ICJmZGFi MDAwMC5ucHUiIGNvbnN1bWVyIGF0IGFsbCAtIHRoZWlyIG9ubHkgY29uc3VtZXJzIGFyZSB0aGUK PiAibnB1QGZkYWIwMDAwIiBoYW5kbGVzIGNyZWF0ZWQgYnkgdGhlIHBvd2VyLWRvbWFpbiBkcml2 ZXIgdmlhCj4gb2ZfY2xrX2dldCgpLgo+IAo+IFNldCB0aGUgaWRzIGV4cGxpY2l0bHksIGluIHRo ZSBvcmRlciBtYW5kYXRlZCBieSB0aGUgYmluZGluZwo+IChEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvbnB1L3JvY2tjaGlwLHJrMzU4OC1ya25uLWNvcmUueWFtbCk6Cj4gYWNsaywg aGNsaywgbnB1LCBwY2xrLiBBZnRlciB0aGUgY2hhbmdlIHRoZSBkcml2ZXIgaG9sZHMgb25lIGhh bmRsZSBwZXIKPiBkaXN0aW5jdCBjbG9jayBhbmQgY2xrX2J1bGtfcHJlcGFyZV9lbmFibGUoKSBj b3ZlcnMgYWxsIGZvdXIuCj4gCj4gTm90ZSB0aGF0IHRoaXMgaXMgYSB1c2VyLXZpc2libGUgdGln aHRlbmluZyBmb3Igb3V0LW9mLXRyZWUgRFRzOiB0aGUKPiBvbGQgTlVMTC1pZCByZXF1ZXN0cyBy ZXNvbHZlZCBieSBpbmRleCBhbmQgc3VjY2VlZGVkIG5vIG1hdHRlciB3aGF0Cj4gImNsb2NrLW5h bWVzIiBjb250YWluZWQsIHdoaWxlIHRoZSBuYW1lZCByZXF1ZXN0cyBmYWlsIHByb2JlIHdpdGgK PiAtRU5PRU5UIHdoZW4gb25lIG9mIHRoZSBmb3VyIG5hbWVzIGlzIG1pc3NpbmcuIFRoYXQgaXMg dGhlIHJpZ2h0Cj4gb3V0Y29tZSBmb3IgaW4tdHJlZSB1c2VycyAtIHRoZSBiaW5kaW5nIHJlcXVp cmVzIGV4YWN0bHkgdGhlc2UgZm91cgo+IGNsb2NrLW5hbWVzIGFuZCByazM1ODgtYmFzZS5kdHNp IGNhcnJpZXMgdGhlbSBvbiBhbGwgdGhyZWUgY29yZXMgLSBidXQKPiBhIERUIHRoYXQgcmVsaWVk IG9uIHRoZSBwZXJtaXNzaXZlIGxvb2t1cCBnb2VzIGZyb20gc2lsZW50bHkgcnVubmluZyBvbgo+ IHRoZSB3cm9uZyBjbG9jayBoYW5kbGVzIHRvIG5vdCBwcm9iaW5nIGF0IGFsbCwgc28gcmVjb3Jk IHRoZSBjaGFuZ2UKPiBoZXJlIHdoZXJlIGdpdCBsb2cgd2lsbCBmaW5kIGl0Lgo+IAo+IEZpeGVz OiBlZDk4MjYxYjQxNjggKCJhY2NlbC9yb2NrZXQ6IEFkZCBhIG5ldyBkcml2ZXIgZm9yIFJvY2tj aGlwJ3MgTlBVIikKPiBBc3Npc3RlZC1ieTogTExNIHNwYXJzZSBjaGVja3BhdGNoCj4gU2lnbmVk LW9mZi1ieTogSWdvciBQYXVub3ZpYyA8cm95YWxuZXQwMjZAZ21haWwuY29tPgo+IFRlc3RlZC1i eTogU2lkb25nIFlhbmcgPHNpZG9uZy55YW5nQGZ1cmlvc2EuYWk+Cj4gVGVzdGVkLWJ5OiBEaWVk ZXJpayBkZSBIYWFzIDxkaWVkZXJpa0Bja25vdy10ZWNoLmNvbT4gICMgTmFub1BDLVQ2IExUUywg TmFub1BDLVQ2IFBsdXMKPiBSZXZpZXdlZC1ieTogU2ViYXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlh bi5yZWljaGVsQGNvbGxhYm9yYS5jb20+Cj4gUmV2aWV3ZWQtYnk6IEppYXhpbmcgSHUgPGdhaGlu Z0BnYWhpbmd3b28uY29tPgo+IC0tLQo+IFNhbWUgZGlmZiBhbmQgdGhlIHNhbWUgbWVzc2FnZSB0 ZXh0IChoaXMgY29weSByZS13cmFwcyB0aGUgbGluZXMpIGFzCj4gMDEvMTQgb2YgSmlheGluZyBI dSdzIFJLMzU3NiBzZXJpZXMsIHdoaWNoIGNhcnJpZXMgdGhpcyBwYXRjaCBhcyB3ZWxsOwo+IHdo aWNoZXZlciBsYW5kcyBmaXJzdCwgdGhlIG90aGVyIGRyb3BzIGl0LiBUaGUgdHJhaWxlcnMgZGlm ZmVyOiBKaWF4aW5nCj4gYXNrZWQgbWUgdG8gZHJvcCBoaXMgU2lnbmVkLW9mZi1ieSBmcm9tIG15 IG93biBwb3N0aW5nIG9mIGl0LCBhcyBoZSBkaWQKPiBub3QgcGFzcyB0aGlzIGNvcHkgYWxvbmcs IGFuZCBBc3Npc3RlZC1ieSBpcyBhZGRlZCBiZWNhdXNlIGFuIExMTSBoZWxwZWQKPiB3aXRoIHRo ZSBjaGVja3Mgb24gdGhpcyB2Mi4KPiAKPiAgZHJpdmVycy9hY2NlbC9yb2NrZXQvcm9ja2V0X2Nv cmUuYyB8IDQgKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvYWNjZWwvcm9ja2V0L3JvY2tldF9jb3JlLmMgYi9kcml2ZXJzL2Fj Y2VsL3JvY2tldC9yb2NrZXRfY29yZS5jCj4gaW5kZXggYjNiMmZhOWJhNjQ1YS4uNWRkMjYwYmFj YmZmNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2FjY2VsL3JvY2tldC9yb2NrZXRfY29yZS5jCj4g KysrIGIvZHJpdmVycy9hY2NlbC9yb2NrZXQvcm9ja2V0X2NvcmUuYwo+IEBAIC0yOCw2ICsyOCwx MCBAQCBpbnQgcm9ja2V0X2NvcmVfaW5pdChzdHJ1Y3Qgcm9ja2V0X2NvcmUgKmNvcmUpCj4gIAlp ZiAoZXJyKQo+ICAJCXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgZXJyLCAiZmFpbGVkIHRvIGdl dCByZXNldHMgZm9yIGNvcmUgJWRcbiIsIGNvcmUtPmluZGV4KTsKPiAgCj4gKwljb3JlLT5jbGtz WzBdLmlkID0gImFjbGsiOwo+ICsJY29yZS0+Y2xrc1sxXS5pZCA9ICJoY2xrIjsKPiArCWNvcmUt PmNsa3NbMl0uaWQgPSAibnB1IjsKPiArCWNvcmUtPmNsa3NbM10uaWQgPSAicGNsayI7CgphZGRp dGlvbmFsbHksIHdoaWxlIHJlYWRpbmcgdGhlIGZvbGxvd3VwIHBhdGNoZXMsIHBsZWFzZSBpbnRy b2R1Y2Ugc29tZQpjb25zdGFudHMgZm9yIHRoZSBpbmRpY2VzLiBST0NLRVRfQ0xLX0FDTEssIC4u LiBvciBzb21lIG90aGVyIG5hbWUuCkJlY2F1c2Ugd2hlbiB5b3UgYWNjZXNzIHRoZW0gbGF0ZXIg YnkgaW5kZXgsIHRoYXQgbWFrZXMgdGhpbmdzIGhhcmRlcgp0byByZWFkIGFuZCBmb2xsb3cgKGVz cGVjaWFsbHkgaW4gdGhlIGZ1dHVyZSkKCgpIZWlrbwoKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGlu dXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==