From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] icmp: avoid allocating large struct on stack
Date: Sun, 02 Jun 2013 09:14:42 +0800 [thread overview]
Message-ID: <1370135682.2637.1.camel@cr0> (raw)
In-Reply-To: <1370064152.24311.19.camel@edumazet-glaptop>
On Fri, 2013-05-31 at 22:22 -0700, Eric Dumazet wrote:
> On Sat, 2013-06-01 at 11:24 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat.com>
> >
> > struct icmp_bxm is a large struct, reduce stack usage
> > by allocating it on heap.
> >
>
> Strange, I posted a patch like that some days ago.
Strange, why it isn't merged. :)
>
> Please.
>
> Read carefully this code and tell me if you do not leak memory.
Right, I missed some kfree.
>
> For the record my patch was saving more stack space :
Please submit it as a normal patch?
prev parent reply other threads:[~2013-06-02 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 3:24 [Patch net-next] icmp: avoid allocating large struct on stack Cong Wang
2013-06-01 3:34 ` Joe Perches
2013-06-01 3:42 ` Cong Wang
2013-06-01 5:22 ` Eric Dumazet
2013-06-02 1:14 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370135682.2637.1.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.