From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>,
git@vger.kernel.org, David Michael Barr <davidbarr@google.com>,
Jeff King <peff@peff.net>,
Michael Haggerty <mhagger@alum.mit.edu>,
Sverre Rabbelier <srabbelier@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] Add explanatory comment for transport-helpers refs mapping.
Date: Tue, 17 Jul 2012 11:56:56 +0200 [thread overview]
Message-ID: <13702454.DmcNg44yyH@flobuntu> (raw)
In-Reply-To: <20120717032725.GC3071@burratino>
transport-helpers can advertise the 'refspec' capability,
if not a default refspec *:* is assumed. This could be helpful
information for the reader.
Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
---
transport-helper.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/transport-helper.c b/transport-helper.c
index d6daad5..4a763a7 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -484,8 +484,18 @@ static int fetch_with_import(struct transport *transport,
if (posn->status & REF_STATUS_UPTODATE)
continue;
if (data->refspecs)
+ /*
+ * If the remote-helper advertised the refpec capability, we
+ * retrieve the local, private ref from it. The imported data is
+ * expected there. (see Documentation/git-remote-helpers.*).
+ */
private = apply_refspecs(data->refspecs, data->refspec_nr, posn-
>name);
else
+ /*
+ * else, the default refspec *:* is implied. The remote-helper has
+ * to import the remote heads directly to the local heads.
+ * remote-helpers using 'import' should have the refspec capability.
+ */
private = xstrdup(posn->name);
if (private) {
read_ref(private, posn->old_sha1);
--
1.7.9.5
next prev parent reply other threads:[~2012-07-17 9:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 13:38 [RFC/PATCH 0/4] GSOC remote-svn Florian Achleitner
2012-07-11 13:38 ` [PATCH 1/4] vcs-svn: add fast_export_note to create notes Florian Achleitner
2012-07-11 13:38 ` [PATCH 2/4] Allow reading svn dumps from files via file:// urls Florian Achleitner
2012-07-11 13:38 ` [PATCH 3/4] Create a note for every imported commit containing svn metadata Florian Achleitner
2012-07-11 13:38 ` [PATCH 4/4] When debug==1, start fast-import with "--stats" instead of "--quiet" Florian Achleitner
2012-07-11 14:29 ` [PATCH 2/4] Allow reading svn dumps from files via file:// urls Dmitry Ivankov
2012-07-11 17:00 ` Junio C Hamano
2012-07-11 17:49 ` Stephen Bash
2012-07-15 14:26 ` [PATCH] Fix overwritten remote ref on with fast-import Florian Achleitner
2012-07-16 0:30 ` Jonathan Nieder
2012-07-16 4:33 ` Junio C Hamano
2012-07-16 22:33 ` Florian Achleitner
2012-07-17 3:27 ` Jonathan Nieder
2012-07-17 9:54 ` Florian Achleitner
2012-07-17 13:48 ` Jonathan Nieder
2012-07-17 20:52 ` Florian Achleitner
2012-07-17 21:02 ` Jonathan Nieder
2012-07-17 22:25 ` Florian Achleitner
2012-07-17 9:56 ` Florian Achleitner [this message]
2012-07-17 16:04 ` [PATCH] Add explanatory comment for transport-helpers refs mapping Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13702454.DmcNg44yyH@flobuntu \
--to=florian.achleitner.2.6.31@gmail.com \
--cc=davidbarr@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.