From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re[2]: [PATCH 1/3] leds: leds-mc13783: Prepare driver to support MC13892 LEDs
Date: Mon, 03 Jun 2013 20:45:26 +0400 [thread overview]
Message-ID: <1370277926.852575788@f77.mail.ru> (raw)
In-Reply-To: <51ACC5CC.3000700@epfl.ch>
> Hi
>
> > @@ -341,51 +362,55 @@ static int mc13783_led_probe(struct platform_device *pdev)
> >
> > err_register:
> > for (i = i - 1; i >= 0; i--) {
> > - led_classdev_unregister(&led[i].cdev);
> > cancel_work_sync(&led[i].work);
> > + led_classdev_unregister(&led[i].cdev);
> > }
> >
> > return ret;
> > }
> >
> > +static int mc13xxx_led_remove(struct platform_device *pdev)
> (..)
> >
> > for (i = 0; i < pdata->num_leds; i++) {
> > - led_classdev_unregister(&led[i].cdev);
> > cancel_work_sync(&led[i].work);
> > + led_classdev_unregister(&led[i].cdev);
> > }
> >
>
>
> Why changing the order ?
Now I realize that was a mistake.
Thanks.
---
next prev parent reply other threads:[~2013-06-03 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 15:38 [PATCH 1/3] leds: leds-mc13783: Prepare driver to support MC13892 LEDs Alexander Shiyan
2013-06-03 15:38 ` [PATCH 2/3] leds: leds-mc13783: Add MC13892 LED support Alexander Shiyan
2013-06-03 15:38 ` [PATCH 3/3] leds: leds-mc13783: Rename unit to indicate various MC13xxx chips support Alexander Shiyan
2013-06-07 19:25 ` Bryan Wu
2013-06-07 19:53 ` Re[2]: " Alexander Shiyan
2013-06-03 16:35 ` [PATCH 1/3] leds: leds-mc13783: Prepare driver to support MC13892 LEDs Philippe Rétornaz
2013-06-03 16:45 ` Alexander Shiyan [this message]
2013-06-07 22:18 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370277926.852575788@f77.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.