From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
John Greene <jogreene@redhat.com>
Subject: Re: using ieee80211_restart_hw()
Date: Mon, 03 Jun 2013 19:23:13 +0200 [thread overview]
Message-ID: <1370280193.8227.25.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <51ACCDFE.5090003@broadcom.com>
Hi,
> In brcmsmac a fatal error in the device results in calling
> ieee80211_restart_hw(). This was done under the assumption that mac80211
> would reconfigure everything doing .start(), .add_interface() etc, but
> looking at a log in redhat bugzilla makes me suspicious about that.
>
> The only reason I could find in ieee80211_reconfig is that
> local->open_count would be zero, right?
>
> At the time of the fatal error AMPDU packets were being transmitted so I
> assume local->open_count would *not* be zero as it seems to match the
> state of the netdev interface.
Not sure what you're asking ... restart_hw() should reconfigure
everything just like you said, but maybe your driver is not cleaning up
properly before the restart so something in there fails? restart_hw()
expects to only do start/add_interface etc, not remove_interface/stop
etc.
johannes
prev parent reply other threads:[~2013-06-03 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 17:10 using ieee80211_restart_hw() Arend van Spriel
2013-06-03 17:23 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370280193.8227.25.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=jogreene@redhat.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.