All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH/RFC 0/5] Another try for a new memtest implementation
Date: Tue,  4 Jun 2013 01:13:47 +0200	[thread overview]
Message-ID: <1370301232-12962-1-git-send-email-alex.aring@gmail.com> (raw)

Hi,

this is a new try to get a new memtest implementation into barebox.

I removed the ADDRESS_IN_REGIONS macro, which was a very ugly solution.
The new memtest command used a list and save all unused sdram_regions
of each bank. Then running the mem_test routine on these regions.
After that the memtest command will release the requested sdram_regions.

I removed the start and stop command arguments to make the implementation
easier/understandable and it's not necessary anyway.

Maybe it's better to remove the silent ALIGN and ALIGN_DOWN from the start
and end address in the common mem_test routine, because addresses are already
align.
It is difficult to explain because a end address has the form of 0xXXXXffff
and a ALIGN_DOWN on it with a mask of 3 we have a calculated end address of
0xXXXXfffA which is wrong. (0xXXXXffff - 4) - 1...

Another question is:
Can someone test it with more than one bank, please? :-)

Regards
Alex

Alexander Aring (5):
  common: fix codestyle in ALIGN macros
  common: add ALIGN_DOWN macro
  memtest: remove memtest command
  common: add memtest.c  with mem_test routine
  commands: add new memtest command

 commands/Kconfig   |  17 +-
 commands/Makefile  |   2 +-
 commands/memtest.c | 489 +++++++++++++++++++++--------------------------------
 common/Makefile    |   1 +
 common/memtest.c   | 313 ++++++++++++++++++++++++++++++++++
 include/common.h   |   5 +-
 include/memtest.h  |  14 ++
 7 files changed, 535 insertions(+), 306 deletions(-)
 create mode 100644 common/memtest.c
 create mode 100644 include/memtest.h

-- 
1.8.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2013-06-03 23:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 23:13 Alexander Aring [this message]
2013-06-03 23:13 ` [PATCH 1/5] common: fix codestyle in ALIGN macros Alexander Aring
2013-06-03 23:13 ` [PATCH 2/5] common: add ALIGN_DOWN macro Alexander Aring
2013-06-03 23:13 ` [PATCH 3/5] memtest: remove memtest command Alexander Aring
2013-06-03 23:13 ` [PATCH 4/5] common: add memtest.c with mem_test routine Alexander Aring
2013-06-03 23:13 ` [PATCH 5/5] commands: add new memtest command Alexander Aring
2013-06-05 21:15 ` [PATCH/RFC 0/5] Another try for a new memtest implementation Sascha Hauer
2013-06-06  7:52 ` antonynpavlov
2013-06-06 17:52   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370301232-12962-1-git-send-email-alex.aring@gmail.com \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.