From: Johannes Berg <johannes@sipsolutions.net>
To: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>,
"John W . Linville" <linville@tuxdriver.com>,
Jouni Malinen <jouni@qca.qualcomm.com>
Subject: Re: [PATCH v8] cfg80211: P2P find phase offload
Date: Tue, 04 Jun 2013 12:43:31 +0200 [thread overview]
Message-ID: <1370342611.8287.12.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1370328271-9523-2-git-send-email-qca_vkondrat@qca.qualcomm.com>
On Tue, 2013-06-04 at 09:44 +0300, Vladimir Kondratiev wrote:
> + if (genlmsg_end(msg, hdr) < 0) {
> + nlmsg_free(msg);
> + return;
> + }
I'm guessing you're going to (have to) respin for Ilan's comments --
please remove the bogus error checking here then, genlmsg_end() can only
ever return >= 0 since it returns msg->len.
johannes
next prev parent reply other threads:[~2013-06-04 10:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 6:44 [PATCH v8] P2P find phase offload Vladimir Kondratiev
2013-06-04 6:44 ` [PATCH v8] cfg80211: " Vladimir Kondratiev
2013-06-04 10:07 ` Peer, Ilan
2013-06-04 11:24 ` Vladimir Kondratiev
2013-06-04 12:07 ` Johannes Berg
2013-06-04 14:03 ` Vladimir Kondratiev
2013-06-04 14:29 ` Johannes Berg
2013-06-04 14:35 ` Malinen, Jouni
2013-06-04 16:47 ` Vladimir Kondratiev
2013-06-04 18:30 ` Jouni Malinen
2013-06-05 7:10 ` Vladimir Kondratiev
2013-06-05 7:53 ` Johannes Berg
2013-06-05 13:30 ` Vladimir Kondratiev
2013-06-11 12:12 ` Johannes Berg
2013-06-05 7:46 ` Johannes Berg
2013-06-05 8:10 ` Arend van Spriel
2013-06-05 8:18 ` Johannes Berg
2013-06-05 8:38 ` Arend van Spriel
2013-06-05 16:26 ` Vladimir Kondratiev
2013-06-05 8:12 ` Jouni Malinen
2013-06-04 12:10 ` Peer, Ilan
2013-06-04 10:43 ` Johannes Berg [this message]
2013-06-04 6:51 ` [PATCH v8] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370342611.8287.12.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.