From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc85xx:Add iprot input arg in create_TLB0/1_entry
Date: Tue, 4 Jun 2013 11:37:45 -0500 [thread overview]
Message-ID: <1370363865.748.2@snotra> (raw)
In-Reply-To: <1370363777.748.1@snotra> (from scottwood@freescale.com on Tue Jun 4 11:36:17 2013)
On 06/04/2013 11:36:17 AM, Scott Wood wrote:
> On 06/04/2013 05:24:41 AM, Prabhakar Kushwaha wrote:
>> create_tlb1_entry and create_tlb0_entry creates TLB entries with
>> IPROT
>> bit set by default. Any TLB entries with IPROT = 1 can not be
>> invalidated.
>>
>> Add IPROT as input argument for TLB entry creation APIs.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>> Based upon git://git.denx.de/u-boot.git branch master
>
> NACK as discussed in the thread where you suggested this.
Sigh, didn't notice this was the external list, so I'll elaborate. We
never want to create a non-IPROT entry, as we don't have a TLB miss
handler that will replace entries that have been invalidated. This
will be especially important if we ever run U-Boot inside a virtual
machine. And yes, this means that the current TLB0 usage should go
away as well.
-Scott
next prev parent reply other threads:[~2013-06-04 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 10:24 [U-Boot] [PATCH] powerpc/mpc85xx:Add iprot input arg in create_TLB0/1_entry Prabhakar Kushwaha
2013-06-04 16:36 ` Scott Wood
2013-06-04 16:37 ` Scott Wood [this message]
2013-06-05 3:20 ` Prabhakar Kushwaha
2013-06-05 18:35 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370363865.748.2@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.