diff for duplicates of <1370384088.748.17@snotra> diff --git a/a/1.txt b/N1/1.txt index e7363a0..77a7a89 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,24 +1,24 @@ On 06/03/2013 03:54:24 PM, Mihai Caraman wrote: -> SPE_FP interrupts are shared with ALTIVEC. Refactor SPE_FP exit +> SPE_FP interrupts are shared with ALTIVEC. Refactor SPE_FP exit =20 > handling > to detect KVM support for the featured unit at run-time, in order to > accommodate ALTIVEC later. -> +>=20 > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> > --- -> arch/powerpc/kvm/booke.c | 80 +> arch/powerpc/kvm/booke.c | 80 =20 > ++++++++++++++++++++++++++++++++++------------ > 1 files changed, 59 insertions(+), 21 deletions(-) -> +>=20 > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 1020119..d082bbc 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c -> @@ -822,6 +822,15 @@ static void kvmppc_restart_interrupt(struct +> @@ -822,6 +822,15 @@ static void kvmppc_restart_interrupt(struct =20 > kvm_vcpu *vcpu, > } > } -> +>=20 > +static inline bool kvmppc_supports_spe(void) > +{ > +#ifdef CONFIG_SPE @@ -33,30 +33,30 @@ Whitespace > /** > * kvmppc_handle_exit > * -> @@ -931,42 +940,71 @@ int kvmppc_handle_exit(struct kvm_run *run, +> @@ -931,42 +940,71 @@ int kvmppc_handle_exit(struct kvm_run *run, =20 > struct kvm_vcpu *vcpu, -> r = RESUME_GUEST; +> r =3D RESUME_GUEST; > break; -> +>=20 > -#ifdef CONFIG_SPE > case BOOKE_INTERRUPT_SPE_UNAVAIL: { > - if (vcpu->arch.shared->msr & MSR_SPE) > - kvmppc_vcpu_enable_spe(vcpu); > - else > - kvmppc_booke_queue_irqprio(vcpu, -> - +> - =20 > BOOKE_IRQPRIO_SPE_UNAVAIL); > + /* -> + * The interrupt is shared, KVM support for the +> + * The interrupt is shared, KVM support for the =20 > featured unit > + * is detected at run-time. > + */ -This is a decent comment for the changelog, but for the code itself it -seems fairly obvious if you look at the definition of +This is a decent comment for the changelog, but for the code itself it =20 +seems fairly obvious if you look at the definition of =20 kvmppc_supports_spe(). -> + bool handled = false; +> + bool handled =3D false; > + > + if (kvmppc_supports_spe()) { > +#ifdef CONFIG_SPE @@ -66,11 +66,11 @@ Didn't you already check this using kvmppc_supports_spe()? > case BOOKE_INTERRUPT_SPE_FP_ROUND: > +#ifdef CONFIG_SPE -> kvmppc_booke_queue_irqprio(vcpu, +> kvmppc_booke_queue_irqprio(vcpu, =20 > BOOKE_IRQPRIO_SPE_FP_ROUND); -> r = RESUME_GUEST; +> r =3D RESUME_GUEST; > break; Why not use kvmppc_supports_spe() here, for consistency? --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 66c4839..5812859 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,35 +2,35 @@ "ref\01370292868-2697-3-git-send-email-mihai.caraman@freescale.com\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH 2/6] KVM: PPC: Book3E: Refactor SPE_FP exit handling\0" - "Date\0Tue, 04 Jun 2013 22:14:48 +0000\0" + "Date\0Tue, 4 Jun 2013 17:14:48 -0500\0" "To\0Mihai Caraman <mihai.caraman@freescale.com>\0" - "Cc\0kvm-ppc@vger.kernel.org" - kvm@vger.kernel.org + "Cc\0Mihai Caraman <mihai.caraman@freescale.com>" linuxppc-dev@lists.ozlabs.org - " Mihai Caraman <mihai.caraman@freescale.com>\0" + kvm@vger.kernel.org + " kvm-ppc@vger.kernel.org\0" "\00:1\0" "b\0" "On 06/03/2013 03:54:24 PM, Mihai Caraman wrote:\n" - "> SPE_FP interrupts are shared with ALTIVEC. Refactor SPE_FP exit \n" + "> SPE_FP interrupts are shared with ALTIVEC. Refactor SPE_FP exit =20\n" "> handling\n" "> to detect KVM support for the featured unit at run-time, in order to\n" "> accommodate ALTIVEC later.\n" - "> \n" + ">=20\n" "> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>\n" "> ---\n" - "> arch/powerpc/kvm/booke.c | 80 \n" + "> arch/powerpc/kvm/booke.c | 80 =20\n" "> ++++++++++++++++++++++++++++++++++------------\n" "> 1 files changed, 59 insertions(+), 21 deletions(-)\n" - "> \n" + ">=20\n" "> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c\n" "> index 1020119..d082bbc 100644\n" "> --- a/arch/powerpc/kvm/booke.c\n" "> +++ b/arch/powerpc/kvm/booke.c\n" - "> @@ -822,6 +822,15 @@ static void kvmppc_restart_interrupt(struct \n" + "> @@ -822,6 +822,15 @@ static void kvmppc_restart_interrupt(struct =20\n" "> kvm_vcpu *vcpu,\n" "> \t}\n" "> }\n" - "> \n" + ">=20\n" "> +static inline bool kvmppc_supports_spe(void)\n" "> +{\n" "> +#ifdef CONFIG_SPE\n" @@ -45,30 +45,30 @@ "> /**\n" "> * kvmppc_handle_exit\n" "> *\n" - "> @@ -931,42 +940,71 @@ int kvmppc_handle_exit(struct kvm_run *run, \n" + "> @@ -931,42 +940,71 @@ int kvmppc_handle_exit(struct kvm_run *run, =20\n" "> struct kvm_vcpu *vcpu,\n" - "> \t\tr = RESUME_GUEST;\n" + "> \t\tr =3D RESUME_GUEST;\n" "> \t\tbreak;\n" - "> \n" + ">=20\n" "> -#ifdef CONFIG_SPE\n" "> \tcase BOOKE_INTERRUPT_SPE_UNAVAIL: {\n" "> -\t\tif (vcpu->arch.shared->msr & MSR_SPE)\n" "> -\t\t\tkvmppc_vcpu_enable_spe(vcpu);\n" "> -\t\telse\n" "> -\t\t\tkvmppc_booke_queue_irqprio(vcpu,\n" - "> -\t\t\t\t\t\t \n" + "> -\t\t\t\t\t\t =20\n" "> BOOKE_IRQPRIO_SPE_UNAVAIL);\n" "> +\t\t/*\n" - "> +\t\t * The interrupt is shared, KVM support for the \n" + "> +\t\t * The interrupt is shared, KVM support for the =20\n" "> featured unit\n" "> +\t\t * is detected at run-time.\n" "> +\t\t */\n" "\n" - "This is a decent comment for the changelog, but for the code itself it \n" - "seems fairly obvious if you look at the definition of \n" + "This is a decent comment for the changelog, but for the code itself it =20\n" + "seems fairly obvious if you look at the definition of =20\n" "kvmppc_supports_spe().\n" "\n" - "> +\t\tbool handled = false;\n" + "> +\t\tbool handled =3D false;\n" "> +\n" "> +\t\tif (kvmppc_supports_spe()) {\n" "> +#ifdef CONFIG_SPE\n" @@ -78,13 +78,13 @@ "\n" "> \tcase BOOKE_INTERRUPT_SPE_FP_ROUND:\n" "> +#ifdef CONFIG_SPE\n" - "> \t\tkvmppc_booke_queue_irqprio(vcpu, \n" + "> \t\tkvmppc_booke_queue_irqprio(vcpu, =20\n" "> BOOKE_IRQPRIO_SPE_FP_ROUND);\n" - "> \t\tr = RESUME_GUEST;\n" + "> \t\tr =3D RESUME_GUEST;\n" "> \t\tbreak;\n" "\n" "Why not use kvmppc_supports_spe() here, for consistency?\n" "\n" - -Scott + -Scott= -490a24c61d6622838270c85c892056294bb4f926a3c2b3a6592cf354c0a87004 +cf3849e36104c1fb016eefe7c960d3e1bda5ca505e56fc6ba2191b10699f0e9c
diff --git a/a/content_digest b/N2/content_digest index 66c4839..063109a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,11 +2,11 @@ "ref\01370292868-2697-3-git-send-email-mihai.caraman@freescale.com\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH 2/6] KVM: PPC: Book3E: Refactor SPE_FP exit handling\0" - "Date\0Tue, 04 Jun 2013 22:14:48 +0000\0" + "Date\0Tue, 4 Jun 2013 17:14:48 -0500\0" "To\0Mihai Caraman <mihai.caraman@freescale.com>\0" - "Cc\0kvm-ppc@vger.kernel.org" - kvm@vger.kernel.org - linuxppc-dev@lists.ozlabs.org + "Cc\0<kvm-ppc@vger.kernel.org>" + <kvm@vger.kernel.org> + <linuxppc-dev@lists.ozlabs.org> " Mihai Caraman <mihai.caraman@freescale.com>\0" "\00:1\0" "b\0" @@ -87,4 +87,4 @@ "\n" -Scott -490a24c61d6622838270c85c892056294bb4f926a3c2b3a6592cf354c0a87004 +60a04d8bb1677b4b5ebaee62f03fe41efa69aa2d5e9d1c8d2b2a07ef35c3de1a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.