From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: linuxppc <linuxppc-dev@lists.ozlabs.org>, Kevin Hao <haokexin@gmail.com>
Subject: Re: [PATCH] powerpc/pci: check the bus address instead of resource address in pcibios_fixup_resources
Date: Thu, 06 Jun 2013 08:38:11 +1000 [thread overview]
Message-ID: <1370471891.3766.244.camel@pasglop> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B726F@saturn3.aculab.com>
On Wed, 2013-06-05 at 14:10 +0100, David Laight wrote:
> > If a BAR has the value of 0, we would assume that it is unset yet and
> > then mark the resource as unset and would reassign it later.
>
> IIRC the PCI spec allows a BAR address of zero.
> Certainly some sparc systems have assigned 0 to a BAR.
> So assuming a BAR of 0 means it is unset may not be
> true for all systems.
Yes, look at the code and the comment above :-) It tries to make a
guess... which so far has worked well for us.
Note that people assigning 0 to BARs are asking for trouble anyway.
Cheers,
Ben.
prev parent reply other threads:[~2013-06-05 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 12:26 [PATCH] powerpc/pci: check the bus address instead of resource address in pcibios_fixup_resources Kevin Hao
2013-06-05 13:10 ` David Laight
2013-06-05 22:38 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370471891.3766.244.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=David.Laight@ACULAB.COM \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.