From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: hw state readout support for pixel_multiplier Date: Thu, 06 Jun 2013 14:50:15 +0300 Message-ID: <1370519415.23133.5.camel@intelbox> References: <1370444517.8530.16.camel@intelbox> <1370515525-7535-1-git-send-email-daniel.vetter@ffwll.ch> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 6312EE5D0B for ; Thu, 6 Jun 2013 04:50:18 -0700 (PDT) In-Reply-To: <1370515525-7535-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, 2013-06-06 at 12:45 +0200, Daniel Vetter wrote: > Incomplete since ilk+ support needs proper pch dpll tracking first. > SDVO get_config parts based on a patch from Jesse Barnes, but fixed up > to actually work. > > v2: Make sure that we call encoder->get_config _after_ we > get_pipe_config to be consistent in both setup_hw_state and the > modeset state checker. Otherwise the clever trick with handling the > pixel mutliplier on i915G/GM where the encoder overrides the default > value of 1 from the crtc get_pipe_config function doesn't work. > Spotted by Imre Deak. > > v3: Actually cross-check the pixel mutliplier (but not on pch split > platforms for now). Now actually also tested on a i915G with a sdvo > encoder plugged in. > > Cc: > Cc: Jesse Barnes > Signed-off-by: Daniel Vetter Looks ok, Reviewed-by: Imre Deak