From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] libxl: add LIBXL_HAVE_ for outstanding_pages and outstanding_memkb Date: Fri, 7 Jun 2013 15:54:17 +0200 Message-ID: <1370613257.17802.36.camel@Solace> References: <20130606223316.14533.86930.stgit@hit-nxdomain.opendns.com> <20130606225041.14533.77390.stgit@hit-nxdomain.opendns.com> <20130607134956.GB25649@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6577578732198997354==" Return-path: In-Reply-To: <20130607134956.GB25649@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Ian Campbell , George Dunlap , Jim Fehlig , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============6577578732198997354== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-fIW3KIG8hgUF9vG//m1t" --=-fIW3KIG8hgUF9vG//m1t Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2013-06-07 at 06:49 -0700, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote: > > Commits d0782481 and bec8f17e added these two fields in libxl_physinfo >=20 > One usually includes right after the git commit the title > of the patches, so: >=20 > d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and > ... > Ok, I think I see why that could be useful. Note taken, thanks. :-) > > and in libxl_dominfo, respectively, but did not include the needed > > LIBXL_HAVE_ runes. Adding them. > >=20 > > Signed-off-by: Dario Faggioli >=20 > Besides the above mention commit description part (And one tweak below) > please also add > Reviewed-by: Konrad Rzeszutek Wilk >=20 > or Acked-by - whichever George is looking for. >=20 Ok, thanks again. George, Ian, should I respin incorporating Konrad's feedback (both to the changelog and to the code comment, of course)? Is this fine for being picked up in 4.3? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-fIW3KIG8hgUF9vG//m1t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEABECAAYFAlGx5gkACgkQk4XaBE3IOsQ1RACfTZQsjJOZePIMLl1/uWrUewFs FskAn1cmo3o/h11I1BDs8il/lm4R3a3V =PmeU -----END PGP SIGNATURE----- --=-fIW3KIG8hgUF9vG//m1t-- --===============6577578732198997354== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6577578732198997354==--