From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe005.messaging.microsoft.com [216.32.181.185]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 1E6562C0091 for ; Wed, 12 Jun 2013 03:01:02 +1000 (EST) Date: Tue, 11 Jun 2013 12:00:51 -0500 From: Scott Wood Subject: Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX To: Rojhalat Ibrahim In-Reply-To: <10631172.HfDeIDHqX3@pcimr> (from imr@rtschenk.de on Tue Jun 11 02:24:28 2013) Message-ID: <1370970051.18413.24@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Michael Guntsche List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/11/2013 02:24:28 AM, Rojhalat Ibrahim wrote: > On Monday 10 June 2013 17:52:33 Scott Wood wrote: > > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote: > > > Good evening, > > > > > > This patch does not fix the problem, during boot the kernel still > > > panics. I had a closer look at the commit and the following patch > > > fixes it for me.... > > > > > > diff --git a/arch/powerpc/sysdev/fsl_pci.c > > > b/arch/powerpc/sysdev/fsl_pci.c > > > index 028ac1f..21b687f 100644 > > > --- a/arch/powerpc/sysdev/fsl_pci.c > > > +++ b/arch/powerpc/sysdev/fsl_pci.c > > > @@ -814,7 +814,7 @@ int __init mpc83xx_add_bridge(struct =20 > device_node > > > *dev) > > > > > > if (ret) > > > > > > goto err0; > > > > > > } else { > > > > > > - fsl_setup_indirect_pci(hose, rsrc_cfg.start, > > > + setup_indirect_pci(hose, rsrc_cfg.start, > > > > > > rsrc_cfg.start + 4, 0); > > > > > > } > > > > The only difference here is that you're not setting hose->ops to > > fsl_indirect_pci_ops. Do you know why that is helping, and what > > hose->ops is set to instead? > > > > -Scott >=20 > The difference is only the read function in hose->ops, which is set to > indirect_read_config instead of fsl_indirect_read_config. >=20 > fsl_indirect_read_config calls fsl_pcie_check_link, which is where =20 > the Oops > occurs. Why is fsl_pcie_check_link being called for non-PCIe buses? > Mike, can you find out where exactly in fsl_pcie_check_link the bad =20 > access > happens? Enabling CONFIG_DEBUG_BUGVERBOSE might help. Why does it matter? You shouldn't be calling that function at all. -Scott= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755465Ab3FKRBA (ORCPT ); Tue, 11 Jun 2013 13:01:00 -0400 Received: from ch1ehsobe005.messaging.microsoft.com ([216.32.181.185]:19255 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154Ab3FKRA6 convert rfc822-to-8bit (ORCPT ); Tue, 11 Jun 2013 13:00:58 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -4 X-BigFish: VS-4(zzbb2dI98dI9371I1432Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzzz2dh2a8h668h839h944hd2bhf0ah1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h16a6h1758h1898h18e1h1946h19b5h1ad9h1b0ah1d0ch1d2eh1d3fh1dc1h1dfeh1dffh1e23h1155h) Date: Tue, 11 Jun 2013 12:00:51 -0500 From: Scott Wood Subject: Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX To: Rojhalat Ibrahim CC: Michael Guntsche , , In-Reply-To: <10631172.HfDeIDHqX3@pcimr> (from imr@rtschenk.de on Tue Jun 11 02:24:28 2013) X-Mailer: Balsa 2.4.12 Message-ID: <1370970051.18413.24@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2013 02:24:28 AM, Rojhalat Ibrahim wrote: > On Monday 10 June 2013 17:52:33 Scott Wood wrote: > > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote: > > > Good evening, > > > > > > This patch does not fix the problem, during boot the kernel still > > > panics. I had a closer look at the commit and the following patch > > > fixes it for me.... > > > > > > diff --git a/arch/powerpc/sysdev/fsl_pci.c > > > b/arch/powerpc/sysdev/fsl_pci.c > > > index 028ac1f..21b687f 100644 > > > --- a/arch/powerpc/sysdev/fsl_pci.c > > > +++ b/arch/powerpc/sysdev/fsl_pci.c > > > @@ -814,7 +814,7 @@ int __init mpc83xx_add_bridge(struct > device_node > > > *dev) > > > > > > if (ret) > > > > > > goto err0; > > > > > > } else { > > > > > > - fsl_setup_indirect_pci(hose, rsrc_cfg.start, > > > + setup_indirect_pci(hose, rsrc_cfg.start, > > > > > > rsrc_cfg.start + 4, 0); > > > > > > } > > > > The only difference here is that you're not setting hose->ops to > > fsl_indirect_pci_ops. Do you know why that is helping, and what > > hose->ops is set to instead? > > > > -Scott > > The difference is only the read function in hose->ops, which is set to > indirect_read_config instead of fsl_indirect_read_config. > > fsl_indirect_read_config calls fsl_pcie_check_link, which is where > the Oops > occurs. Why is fsl_pcie_check_link being called for non-PCIe buses? > Mike, can you find out where exactly in fsl_pcie_check_link the bad > access > happens? Enabling CONFIG_DEBUG_BUGVERBOSE might help. Why does it matter? You shouldn't be calling that function at all. -Scott