From: Johannes Berg <johannes@sipsolutions.net>
To: "Thomas Hühn" <thomas@net.t-labs.tu-berlin.de>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
nbd@nbd.name
Subject: Re: [PATCH] carl9170: make use of the new rate control API
Date: Tue, 11 Jun 2013 21:24:28 +0200 [thread overview]
Message-ID: <1370978668.8356.67.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1E3747D2-BD9C-4136-B17F-9227E24136D5@net.t-labs.tu-berlin.de>
On Tue, 2013-06-11 at 21:17 +0200, Thomas Hühn wrote:
> Hi Christian,
>
> I have not seen that patch in wireless-next, that's why I overlooked it… sorry.
>
> >
> > ???
> >
> > carl9170 already supports the new rate control API (Patch from 2013-04-23).
> > <http://permalink.gmane.org/gmane.linux.kernel.wireless.general/107657>
> >
> > Can you please tell me what you think is missing?
> >
>
> You patch looks good to me.
> As I just saw an ath9k patch for rcu protection when ieee80211_get_tx_rates() is called.
> Should this be done in carl9170 as well ?
I think that patch is wrong actually, probably should just do the rcu
protection inside the function. However the patch is completely wrong
anyway (C isn't python) so ...
johannes
next prev parent reply other threads:[~2013-06-11 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 15:57 [PATCH] carl9170: make use of the new rate control API Thomas Huehn
2013-06-11 17:46 ` Christian Lamparter
2013-06-11 19:17 ` Thomas Hühn
2013-06-11 19:24 ` Johannes Berg [this message]
2013-06-11 19:49 ` Christian Lamparter
2013-06-11 19:53 ` Johannes Berg
2013-06-12 18:53 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370978668.8356.67.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@nbd.name \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.