diff for duplicates of <1371061871.18413.44@snotra> diff --git a/a/1.txt b/N1/1.txt index 060831f..6d2e1bd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,48 +1,48 @@ On 06/12/2013 10:08:29 AM, Sebastian Andrzej Siewior wrote: > On 06/12/2013 02:47 PM, Oded Gabbay wrote: -> > This patch fixes a bug in the fsl_pq_mdio.c module and in relevant =20 +> > This patch fixes a bug in the fsl_pq_mdio.c module and in relevant > device-tree -> > files regarding the correct offset of the tbipa register in the =20 +> > files regarding the correct offset of the tbipa register in the > eTSEC > > controller in some of Freescale's PQ3 and QorIQ SoC. -> > The bug happens when the mdio in the device tree is configured to =20 +> > The bug happens when the mdio in the device tree is configured to > be compatible -> > to "fsl,gianfar-tbi". Because the mdio device in the device tree =20 +> > to "fsl,gianfar-tbi". Because the mdio device in the device tree > points to -> > addresses 25520, 26520 or 27520 (depends on the controller ID), the =20 +> > addresses 25520, 26520 or 27520 (depends on the controller ID), the > variable -> > priv->map at function fsl_pq_mdio_probe, points to that address. =20 +> > priv->map at function fsl_pq_mdio_probe, points to that address. > However, -> > later in the function there is a write to register tbipa that is =20 +> > later in the function there is a write to register tbipa that is > actually -> > located at 25030, 26030 or 27030. Because the correct address is =20 +> > located at 25030, 26030 or 27030. Because the correct address is > not io mapped, > > the contents are written to a different register in the controller. -> > The fix sets the address of the mdio device to start at 25000, =20 +> > The fix sets the address of the mdio device to start at 25000, > 26000 or 27000 > > and changes the mii_offset field to 0x520 in the relevant entry > > (fsl,gianfar-tbi) of the fsl_pq_mdio_match array. > > -> > Note: This patch may break MDIO functionallity of some old =20 +> > Note: This patch may break MDIO functionallity of some old > Freescale's SoC -> > until Freescale will fix their device tree files. Basically, every =20 +> > until Freescale will fix their device tree files. Basically, every > device tree -> > which contains an mdio device that is compatible to =20 +> > which contains an mdio device that is compatible to > "fsl,gianfar-tbi" should be > > examined. ->=20 +> > Not as is. -> Please add a check for the original address. If it has 0x520 at the =20 +> Please add a check for the original address. If it has 0x520 at the > end > print a warning and fix it up. Please add to the patch description > which register is modified instead if this patch is not applied. > Depending on how critical this it might has to go stable. -I'm not sure it's stable material if this is something that has never =20 +I'm not sure it's stable material if this is something that has never worked... -The device tree binding will also need to be fixed to note the =20 -difference in "reg" between "fsl,gianfar-mdio" and "fsl-gianfar-tbi" -- =20 +The device tree binding will also need to be fixed to note the +difference in "reg" between "fsl,gianfar-mdio" and "fsl-gianfar-tbi" -- and should give an example of the latter. --Scott= +-Scott diff --git a/a/content_digest b/N1/content_digest index e8474a4..b9be0f0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,65 +4,65 @@ "Subject\0Re: [PATCH] MDIO: FSL_PQ_MDIO: Fix bug on incorrect offset of tbipa register\0" "Date\0Wed, 12 Jun 2013 13:31:11 -0500\0" "To\0Sebastian Andrzej Siewior <bigeasy@linutronix.de>\0" - "Cc\0stef.van.os@prodrive.nl" - Oded Gabbay <ogabbay@advaoptical.com> - netdev@vger.kernel.org - Dongsheng.Wang@freescale.com - timur@tabi.org - paulus@samba.org - linuxppc-dev@lists.ozlabs.org - davem@davemloft.net - linux-kernel@vger.kernel.org - " B38951@freescale.com\0" + "Cc\0Oded Gabbay <ogabbay@advaoptical.com>" + <stef.van.os@prodrive.nl> + <timur@tabi.org> + <Dongsheng.Wang@freescale.com> + <paulus@samba.org> + <netdev@vger.kernel.org> + <linuxppc-dev@lists.ozlabs.org> + <davem@davemloft.net> + <linux-kernel@vger.kernel.org> + " <B38951@freescale.com>\0" "\00:1\0" "b\0" "On 06/12/2013 10:08:29 AM, Sebastian Andrzej Siewior wrote:\n" "> On 06/12/2013 02:47 PM, Oded Gabbay wrote:\n" - "> > This patch fixes a bug in the fsl_pq_mdio.c module and in relevant =20\n" + "> > This patch fixes a bug in the fsl_pq_mdio.c module and in relevant \n" "> device-tree\n" - "> > files regarding the correct offset of the tbipa register in the =20\n" + "> > files regarding the correct offset of the tbipa register in the \n" "> eTSEC\n" "> > controller in some of Freescale's PQ3 and QorIQ SoC.\n" - "> > The bug happens when the mdio in the device tree is configured to =20\n" + "> > The bug happens when the mdio in the device tree is configured to \n" "> be compatible\n" - "> > to \"fsl,gianfar-tbi\". Because the mdio device in the device tree =20\n" + "> > to \"fsl,gianfar-tbi\". Because the mdio device in the device tree \n" "> points to\n" - "> > addresses 25520, 26520 or 27520 (depends on the controller ID), the =20\n" + "> > addresses 25520, 26520 or 27520 (depends on the controller ID), the \n" "> variable\n" - "> > priv->map at function fsl_pq_mdio_probe, points to that address. =20\n" + "> > priv->map at function fsl_pq_mdio_probe, points to that address. \n" "> However,\n" - "> > later in the function there is a write to register tbipa that is =20\n" + "> > later in the function there is a write to register tbipa that is \n" "> actually\n" - "> > located at 25030, 26030 or 27030. Because the correct address is =20\n" + "> > located at 25030, 26030 or 27030. Because the correct address is \n" "> not io mapped,\n" "> > the contents are written to a different register in the controller.\n" - "> > The fix sets the address of the mdio device to start at 25000, =20\n" + "> > The fix sets the address of the mdio device to start at 25000, \n" "> 26000 or 27000\n" "> > and changes the mii_offset field to 0x520 in the relevant entry\n" "> > (fsl,gianfar-tbi) of the fsl_pq_mdio_match array.\n" "> >\n" - "> > Note: This patch may break MDIO functionallity of some old =20\n" + "> > Note: This patch may break MDIO functionallity of some old \n" "> Freescale's SoC\n" - "> > until Freescale will fix their device tree files. Basically, every =20\n" + "> > until Freescale will fix their device tree files. Basically, every \n" "> device tree\n" - "> > which contains an mdio device that is compatible to =20\n" + "> > which contains an mdio device that is compatible to \n" "> \"fsl,gianfar-tbi\" should be\n" "> > examined.\n" - ">=20\n" + "> \n" "> Not as is.\n" - "> Please add a check for the original address. If it has 0x520 at the =20\n" + "> Please add a check for the original address. If it has 0x520 at the \n" "> end\n" "> print a warning and fix it up. Please add to the patch description\n" "> which register is modified instead if this patch is not applied.\n" "> Depending on how critical this it might has to go stable.\n" "\n" - "I'm not sure it's stable material if this is something that has never =20\n" + "I'm not sure it's stable material if this is something that has never \n" "worked...\n" "\n" - "The device tree binding will also need to be fixed to note the =20\n" - "difference in \"reg\" between \"fsl,gianfar-mdio\" and \"fsl-gianfar-tbi\" -- =20\n" + "The device tree binding will also need to be fixed to note the \n" + "difference in \"reg\" between \"fsl,gianfar-mdio\" and \"fsl-gianfar-tbi\" -- \n" "and should give an example of the latter.\n" "\n" - -Scott= + -Scott -a4f7dee9bba04befcab6d2b08be4e7a7e153585066668f348dfc776422e2e781 +fd9d3f4afa3887bcf711a0637fd0730e982e72a14e7dd649512eff495ba1f095
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.