From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1UmrmO-0002X4-Cp
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 16:36:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1UmrmI-0000wd-86
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 16:36:28 -0400
Date: Wed, 12 Jun 2013 15:36:11 -0500
From: Scott Wood <scottwood@freescale.com>
In-Reply-To: <B3B2436D-9F3B-478E-BEBF-677760CE0765@suse.de> (from
	agraf@suse.de on Wed Jun 12 08:01:06 2013)
Message-ID: <1371069371.18413.50@snotra>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 8/9] kvm/openpic: in-kernel mpic
	support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 06/12/2013 08:01:06 AM, Alexander Graf wrote:
>=20
> On 01.05.2013, at 03:48, Scott Wood wrote:
> > +static void kvm_openpic_region_add(MemoryListener *listener,
> > +                                   MemoryRegionSection *section)
> > +{
> > +    KVMOpenPICState *opp =3D container_of(listener, KVMOpenPICState,
> > +                                        mem_listener);
> > +    struct kvm_device_attr attr;
> > +    uint64_t reg_base;
> > +    int ret;
> > +
> > +    if (section->address_space !=3D &address_space_memory) {
> > +        abort();
> > +    }
> > +
> > +    if (reg_base) {
>=20
> Check on uninitialized variable.

Oops, leftover debug code from when the code looked a bit different. :-P

I wonder why GCC (4.5) didn't warn about this.

-Scott=