All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev-owner@vger.kernel.org, netdev@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Patch net-next v3 1/3] igmp: fix return value of some functions
Date: Thu, 13 Jun 2013 16:44:15 +0800	[thread overview]
Message-ID: <1371113055.10194.13.camel@cr0> (raw)
In-Reply-To: <OF7613FEAD.8B74A56A-ON87257B86.00477CA0-87257B86.00477CA3@us.ibm.com>

On Mon, 2013-06-10 at 07:00 -0600, David Stevens wrote:
> 
> >On Mon, 2013-06-10 at 11:07 +0800, Cong Wang wrote: >  > Are you
> >suggesting to just make ip_mc_leave_src() void?  I meant
> >ip_mc_del_src() of course...
> 
> Yes. At least, unless you find text in the API standard that says
> this case should return an error.
> 

Right, I should keep the return value as it is.

      reply	other threads:[~2013-06-13  8:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  2:20 [Patch net-next v3 1/3] igmp: fix return value of some functions Cong Wang
2013-06-06  2:20 ` [Patch net-next v3 2/3] ipv6,mcast: " Cong Wang
2013-06-06  2:20 ` [Patch net-next v3 3/3] igmp: convert RTNL lock to a spinlock Cong Wang
2013-06-06  2:40   ` Eric Dumazet
2013-06-06  2:50     ` Cong Wang
2013-06-06 20:16 ` [Patch net-next v3 1/3] igmp: fix return value of some functions David Stevens
2013-06-08 10:56   ` Cong Wang
2013-06-09  2:12     ` David Stevens
2013-06-10  3:07       ` Cong Wang
2013-06-10  3:09         ` Cong Wang
2013-06-10 13:00           ` David Stevens
2013-06-13  8:44             ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371113055.10194.13.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev-owner@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.