All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] powerpc/85xx: Add P1023RDB board support
Date: Thu, 13 Jun 2013 15:03:35 -0500	[thread overview]
Message-ID: <1371153815.2028.20@snotra> (raw)
In-Reply-To: <1371109457-19894-1-git-send-email-Chunhe.Lan@freescale.com> (from Chunhe.Lan@freescale.com on Thu Jun 13 02:44:17 2013)

On 06/13/2013 02:44:17 AM, Chunhe Lan wrote:
> +/*
> + * Memory map
> + *
> + * 0x0000_0000	0x1fff_ffff	DDR			500M  
> Cacheable
> + * 0x8000_0000	0xbfff_ffff	PCI Express Mem		1G  
> non-cacheable
> + * 0xc000_0000	0xdfff_ffff	PCI			512M  
> non-cacheable
> + * 0xe100_0000	0xe3ff_ffff	PCI IO range		4M  
> non-cacheable
> + * 0xff00_0000	0xff3f_ffff	DPAA_QBMAN		4M
> + *
> + * Localbus non-cacheable
> + *
> + * 0xec00_0000	0xefff_ffff	NOR flash		64M NOR  
> flash
> + * 0xff60_0000	0xff7f_ffff	CCSR			2M  
> non-cacheable
> + * 0xffa0_0000	0xffaf_ffff	NAND			1M  
> non-cacheable
> + * 0xffd0_0000	0xffd0_3fff	L1 for stack		16K  
> Cacheable TLB0
> + */

Same comments as before -- only two of those last four are under the  
localbus, and only three are non-cacheable.

Also, DPAA_QBMAN should say "4M cacheable" rather than "4M" for  
consistency.  Also, please capitalize consistently ("non-cacheable" and  
"Cacheable"). :-)

-Scott

      reply	other threads:[~2013-06-13 20:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  7:44 [U-Boot] [PATCH v3] powerpc/85xx: Add P1023RDB board support Chunhe Lan
2013-06-13 20:03 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371153815.2028.20@snotra \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.