All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Xingchao <xingchao.wang@linux.intel.com>
To: tiwai@suse.de, daniel.vetter@ffwll.ch
Cc: alsa-devel@alsa-project.org,
	Wang Xingchao <xingchao.wang@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, david.henningsson@canonical.com
Subject: [PATCH 1/4] ALSA: hda - Haswell converter power state D0 verify
Date: Fri, 14 Jun 2013 23:20:26 +0800	[thread overview]
Message-ID: <1371223229-8236-2-git-send-email-xingchao.wang@linux.intel.com> (raw)
In-Reply-To: <1371223229-8236-1-git-send-email-xingchao.wang@linux.intel.com>

Haswell converters maybe in wrong power state before usage.
i.e. only converter 0 is in D0, converter 1/2 are in D3.
When pin choose converter 1/2, there's no audio output.

Signed-off-by: Wang Xingchao <xingchao.wang@linux.intel.com>
---
 sound/pci/hda/patch_hdmi.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index e12f7a0..8db5eb6 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1053,6 +1053,23 @@ static void haswell_verify_pin_D0(struct hda_codec *codec, hda_nid_t nid)
 	}
 }
 
+static void hsw_verify_cvt_D0(struct hdmi_spec *spec,
+			 struct hda_codec *codec)
+{
+	struct hdmi_spec_per_cvt *per_cvt;
+	int pwr, cvt_idx;
+
+	for (cvt_idx = 0; cvt_idx < spec->num_cvts; cvt_idx++) {
+		per_cvt = get_cvt(spec, cvt_idx);
+		pwr = snd_hda_codec_read(codec, per_cvt->cvt_nid, 0,
+				AC_VERB_GET_POWER_STATE, 0);
+		pwr = (pwr & AC_PWRST_ACTUAL) >> AC_PWRST_ACTUAL_SHIFT;
+		if (pwr != AC_PWRST_D0)
+			snd_hda_codec_write(codec, per_cvt->cvt_nid, 0, AC_VERB_SET_POWER_STATE,
+					    AC_PWRST_D0);
+	}
+}
+
 /*
  * Callbacks
  */
@@ -1122,6 +1139,9 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo,
 	per_pin = get_pin(spec, pin_idx);
 	eld = &per_pin->sink_eld;
 
+	if (codec->vendor_id == 0x80862807)
+		hsw_verify_cvt_D0(spec, codec);
+
 	/* Dynamically assign converter to stream */
 	for (cvt_idx = 0; cvt_idx < spec->num_cvts; cvt_idx++) {
 		per_cvt = get_cvt(spec, cvt_idx);
-- 
1.8.1.2

  reply	other threads:[~2013-06-14 15:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 15:20 [PATCH 0/4] Haswell Display audio routing bug fix Wang Xingchao
2013-06-14 15:20 ` Wang Xingchao [this message]
2013-06-17  9:00   ` [PATCH 1/4] ALSA: hda - Haswell converter power state D0 verify Takashi Iwai
2013-06-17 11:55     ` Wang, Xingchao
2013-06-14 15:20 ` [PATCH 2/4] ALSA: hda - Return error when open empty hdmi device Wang Xingchao
2013-06-17  8:23   ` David Henningsson
2013-06-17 11:54     ` Wang, Xingchao
2013-06-17 12:15       ` David Henningsson
2013-06-17 12:25         ` Wang, Xingchao
2013-06-18  3:23         ` Wang, Xingchao
2013-06-14 15:20 ` [PATCH 3/4] drm/i915: Add display audio routing APIs for ALSA Wang Xingchao
2013-06-14 19:18   ` Daniel Vetter
2013-06-17 12:52     ` Wang, Xingchao
2013-06-18  7:13       ` Daniel Vetter
2013-06-18  9:04         ` Wang, Xingchao
2013-06-14 15:20 ` [PATCH 4/4] ALSA: hda - Add display audio routing API for haswell Wang Xingchao
2013-06-17  9:03   ` Takashi Iwai
2013-06-17 12:53     ` Wang, Xingchao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371223229-8236-2-git-send-email-xingchao.wang@linux.intel.com \
    --to=xingchao.wang@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=david.henningsson@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.