From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chris Larson <clarson@kergoth.com>
Cc: "bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] bitbake: add event masks
Date: Fri, 14 Jun 2013 17:10:41 +0100 [thread overview]
Message-ID: <1371226241.20823.85.camel@ted> (raw)
In-Reply-To: <CABcZANm=WTC9e5QLepdt7im0mY++_g9a3fk0xvmJx3sKxpKp4w@mail.gmail.com>
On Fri, 2013-05-31 at 09:51 -0700, Chris Larson wrote:
> On Fri, May 31, 2013 at 7:19 AM, Bogdan Marinescu
> <bogdan.a.marinescu@intel.com> wrote:
> Add more arguments to an "addhandler" command. Each argument
> (after the
> first one, which is the name of the handler) is the name of an
> event class
> that the handler wants to be notified on. "*" is a shortcut
> for "listen
> to all events". This changes the current behaviour of bitbake,
> which is
> to broadcast all events to all listeners; instead, only the
> handlers
> that registered themselves to an event with "addhandler" will
> receive
> that event. This should improve performance, although only
> performance
> measurements will be confirm or deny this claim.
> This is part of the fix for YOCTO #3812, but implements
> filtering only
> for class event handlers; the other part (events filter for
> UIs) will be
> the subject of a different patch.
>
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
>
> Wouldn't it be simpler, as well as less invasive to the file format,
> to add an 'event' or 'events' flag to the handler which indicates what
> events it wishes to handle?
Agreed, FWIW I reworked this and merged it. Since we were messing around
with the bitbake minimum version in OE anyway, it seemed a good
opportunity.
Cheers,
Richard
prev parent reply other threads:[~2013-06-14 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 14:19 [PATCH] bitbake: add event masks Bogdan Marinescu
2013-05-31 16:51 ` Chris Larson
2013-06-14 16:10 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371226241.20823.85.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.