From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link Date: Fri, 14 Jun 2013 22:48:13 +0000 Message-ID: <1371250092.2490.7.camel@x230> References: <20130401235256.GA31966@google.com> <20130614141101.GA29452@google.com> <1371248853.2490.5.camel@x230> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <0E8CCCB434AFC340A3CCE0F33534D549@namprd05.prod.outlook.com> Sender: linux-pci-owner@vger.kernel.org To: Yinghai Lu Cc: Bjorn Helgaas , Roman Yepishev , Jiang Liu , "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman , Maxim Levitsky , Jussi Kivilinna List-Id: linux-acpi@vger.kernel.org T24gRnJpLCAyMDEzLTA2LTE0IGF0IDE1OjQwIC0wNzAwLCBZaW5naGFpIEx1IHdyb3RlOg0KPiBP biBGcmksIEp1biAxNCwgMjAxMyBhdCAzOjI3IFBNLCBNYXR0aGV3IEdhcnJldHQNCj4gPG1hdHRo ZXcuZ2FycmV0dEBuZWJ1bGEuY29tPiB3cm90ZToNCj4gPiBPbiBGcmksIDIwMTMtMDYtMTQgYXQg MTU6MTcgLTA3MDAsIFlpbmdoYWkgTHUgd3JvdGU6DQo+ID4NCj4gPj4gYWZ0ZXIgdGhvc2UgdHdv IHBhdGNoZXMsIGl0IGFzcG1fZGlzYWJsZWQgaXMgc2V0LCB2aWEgX29zYyBlYXJseSwNCj4gPj4g cHJlLTEuMSBkZXZpY2VzIGFzcG0gcmVnaXN0ZXIgd2lsbCBiZSB0b3VjaGVkIGV2ZW4gYXNwbV9m b3JjZSBpcyBub3Qgc3BlY2lmaWVkLg0KPiA+DQo+ID4gSSBkb24ndCBmb2xsb3cuIFdlIHdlcmUg cHJldmlvdXNseSBhdXRvbWF0aWNhbGx5IGRpc2FibGluZyBBU1BNIG9uDQo+ID4gcHJlLTEuMSBk ZXZpY2VzIGV2ZW4gaWYgX09TQyBkaWRuJ3QgZ2l2ZSB1cyBjb250cm9sLg0KPiANCj4gSSBkb24n dCB0aGluayBzbywgd2UganVzdCBtb3ZlZCBfT1NDIHN1cHBvcnQvY29udHJvbCBzZXR0aW5nIGJl Zm9yZSBwY2kgc2Nhbg0KPiBpbiAzLjggYW5kIHJldmVydCB0aGF0IGluIHYzLjkuDQoNClJpZ2h0 LCBzb3JyeSwgSSBkb24ndCBtZWFuIF9PU0MsIEkgbWVhbiB0aGUgRkFEVCBmbGFnLiBXZSB3ZXJl DQpwcmV2aW91c2x5IGF1dG9tYXRpY2FsbHkgZGlzYWJsaW5nIEFTUE0gb24gcHJlLTEuMSBkZXZp Y2VzIGV2ZW4gaWYgdGhlDQpGQURUIGZsYWcgd2FzIHNldC4NCg0KLS0gDQpNYXR0aGV3IEdhcnJl dHQgfCBtamc1OUBzcmNmLnVjYW0ub3JnDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bn1lp0155.outbound.protection.outlook.com ([207.46.163.155]:30864 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753689Ab3FNWsS (ORCPT ); Fri, 14 Jun 2013 18:48:18 -0400 From: Matthew Garrett To: Yinghai Lu CC: Bjorn Helgaas , Roman Yepishev , Jiang Liu , "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman , Maxim Levitsky , Jussi Kivilinna Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link Date: Fri, 14 Jun 2013 22:48:13 +0000 Message-ID: <1371250092.2490.7.camel@x230> References: <20130401235256.GA31966@google.com> <20130614141101.GA29452@google.com> <1371248853.2490.5.camel@x230> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDEzLTA2LTE0IGF0IDE1OjQwIC0wNzAwLCBZaW5naGFpIEx1IHdyb3RlOg0KPiBP biBGcmksIEp1biAxNCwgMjAxMyBhdCAzOjI3IFBNLCBNYXR0aGV3IEdhcnJldHQNCj4gPG1hdHRo ZXcuZ2FycmV0dEBuZWJ1bGEuY29tPiB3cm90ZToNCj4gPiBPbiBGcmksIDIwMTMtMDYtMTQgYXQg MTU6MTcgLTA3MDAsIFlpbmdoYWkgTHUgd3JvdGU6DQo+ID4NCj4gPj4gYWZ0ZXIgdGhvc2UgdHdv IHBhdGNoZXMsIGl0IGFzcG1fZGlzYWJsZWQgaXMgc2V0LCB2aWEgX29zYyBlYXJseSwNCj4gPj4g cHJlLTEuMSBkZXZpY2VzIGFzcG0gcmVnaXN0ZXIgd2lsbCBiZSB0b3VjaGVkIGV2ZW4gYXNwbV9m b3JjZSBpcyBub3Qgc3BlY2lmaWVkLg0KPiA+DQo+ID4gSSBkb24ndCBmb2xsb3cuIFdlIHdlcmUg cHJldmlvdXNseSBhdXRvbWF0aWNhbGx5IGRpc2FibGluZyBBU1BNIG9uDQo+ID4gcHJlLTEuMSBk ZXZpY2VzIGV2ZW4gaWYgX09TQyBkaWRuJ3QgZ2l2ZSB1cyBjb250cm9sLg0KPiANCj4gSSBkb24n dCB0aGluayBzbywgd2UganVzdCBtb3ZlZCBfT1NDIHN1cHBvcnQvY29udHJvbCBzZXR0aW5nIGJl Zm9yZSBwY2kgc2Nhbg0KPiBpbiAzLjggYW5kIHJldmVydCB0aGF0IGluIHYzLjkuDQoNClJpZ2h0 LCBzb3JyeSwgSSBkb24ndCBtZWFuIF9PU0MsIEkgbWVhbiB0aGUgRkFEVCBmbGFnLiBXZSB3ZXJl DQpwcmV2aW91c2x5IGF1dG9tYXRpY2FsbHkgZGlzYWJsaW5nIEFTUE0gb24gcHJlLTEuMSBkZXZp Y2VzIGV2ZW4gaWYgdGhlDQpGQURUIGZsYWcgd2FzIHNldC4NCg0KLS0gDQpNYXR0aGV3IEdhcnJl dHQgfCBtamc1OUBzcmNmLnVjYW0ub3JnDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753964Ab3FNWsU (ORCPT ); Fri, 14 Jun 2013 18:48:20 -0400 Received: from mail-bn1lp0155.outbound.protection.outlook.com ([207.46.163.155]:30864 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753689Ab3FNWsS (ORCPT ); Fri, 14 Jun 2013 18:48:18 -0400 From: Matthew Garrett To: Yinghai Lu CC: Bjorn Helgaas , Roman Yepishev , Jiang Liu , "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman , Maxim Levitsky , Jussi Kivilinna Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link Thread-Topic: [PATCH] PCI: Remove not needed check in disable aspm link Thread-Index: AQHOaSy7q8T6unfYO0y0KlbpsoIbopk1uWwAgAAOSICAAAKsgIAAA5wAgAACKQA= Date: Fri, 14 Jun 2013 22:48:13 +0000 Message-ID: <1371250092.2490.7.camel@x230> References: <20130401235256.GA31966@google.com> <20130614141101.GA29452@google.com> <1371248853.2490.5.camel@x230> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.4] x-forefront-antispam-report: SFV:SKI;SFS:;DIR:OUT;SFP:;SCL:-1;SRVR:BY2PR05MB221;H:BY2PR05MB222.namprd05.prod.outlook.com;LANG:en; Content-Type: text/plain; charset="utf-8" Content-ID: <0E8CCCB434AFC340A3CCE0F33534D549@namprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r5EMmP72008669 On Fri, 2013-06-14 at 15:40 -0700, Yinghai Lu wrote: > On Fri, Jun 14, 2013 at 3:27 PM, Matthew Garrett > wrote: > > On Fri, 2013-06-14 at 15:17 -0700, Yinghai Lu wrote: > > > >> after those two patches, it aspm_disabled is set, via _osc early, > >> pre-1.1 devices aspm register will be touched even aspm_force is not specified. > > > > I don't follow. We were previously automatically disabling ASPM on > > pre-1.1 devices even if _OSC didn't give us control. > > I don't think so, we just moved _OSC support/control setting before pci scan > in 3.8 and revert that in v3.9. Right, sorry, I don't mean _OSC, I mean the FADT flag. We were previously automatically disabling ASPM on pre-1.1 devices even if the FADT flag was set. -- Matthew Garrett | mjg59@srcf.ucam.org {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I